diff mbox series

PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()

Message ID 20230327073604.5449-1-cai.huoqing@linux.dev
State New
Headers
Series PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many() |

Commit Message

Cai Huoqing March 27, 2023, 7:36 a.m. UTC 
  Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
because pci_p2pmem_dma() is already removed.

Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
 drivers/pci/p2pdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Logan Gunthorpe March 27, 2023, 3:48 p.m. UTC | #1 
On 2023-03-27 01:36, Cai Huoqing wrote:
> Use pci_p2pdma_map_segment() instead of pci_p2pmem_dma(),
> because pci_p2pmem_dma() is already removed.
> 
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>

Thanks for noticing this!

> ---
>  drivers/pci/p2pdma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
> index 9e8205572830..4f1798ecf38f 100644
> --- a/drivers/pci/p2pdma.c
> +++ b/drivers/pci/p2pdma.c
> @@ -747,7 +747,7 @@ EXPORT_SYMBOL_GPL(pci_has_p2pmem);
>  /**
>   * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
>   *	the specified list of clients and shortest distance (as determined
> - *	by pci_p2pmem_dma())
> + *	by pci_p2pdma_map_segment())

Maybe we should just remove the reference to pci_p2pdma_map_segment()
completely. I don't see how that function helps the reader any more and
is really different section of the API anyway.

Logan
diff mbox series

Patch

diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 9e8205572830..4f1798ecf38f 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -747,7 +747,7 @@  EXPORT_SYMBOL_GPL(pci_has_p2pmem);
 /**
  * pci_p2pmem_find_many - find a peer-to-peer DMA memory device compatible with
  *	the specified list of clients and shortest distance (as determined
- *	by pci_p2pmem_dma())
+ *	by pci_p2pdma_map_segment())
  * @clients: array of devices to check (NULL-terminated)
  * @num_clients: number of client devices in the list
  *