diff mbox series

kmsan: fix a stale comment in kmsan_save_stack_with_flags()

Message ID 20230327034149.942-1-thunder.leizhen@huawei.com
State New
Headers
Series kmsan: fix a stale comment in kmsan_save_stack_with_flags() |

Commit Message

Zhen Lei March 27, 2023, 3:41 a.m. UTC 
  After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and
commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and
__alloc_pages_nodemask"), the comment is no longer accurate.
Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the
comment rather than update it.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 mm/kmsan/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Potapenko March 27, 2023, 11:05 a.m. UTC | #1 
On Mon, Mar 27, 2023 at 5:45 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>
> After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and
> commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and
> __alloc_pages_nodemask"), the comment is no longer accurate.
> Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the
> comment rather than update it.
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Alexander Potapenko <glider@google.com>

>
>         nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0);
>
> -       /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */
> +       /* Don't sleep. */

Thanks for spotting this!
diff mbox series

Patch

diff --git a/mm/kmsan/core.c b/mm/kmsan/core.c
index f710257d68670ee..7d1e4aa30bae622 100644
--- a/mm/kmsan/core.c
+++ b/mm/kmsan/core.c
@@ -73,7 +73,7 @@  depot_stack_handle_t kmsan_save_stack_with_flags(gfp_t flags,
 
 	nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0);
 
-	/* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */
+	/* Don't sleep. */
 	flags &= ~__GFP_DIRECT_RECLAIM;
 
 	handle = __stack_depot_save(entries, nr_entries, flags, true);