diff mbox series

staging: rtl8723bs: remove unused pHalData variable

Message ID 20230326122321.1352337-1-trix@redhat.com
State New
Headers
Series staging: rtl8723bs: remove unused pHalData variable |

Commit Message

Tom Rix March 26, 2023, 12:23 p.m. UTC 
  clang with W=1 reports
drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
  'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
        struct hal_com_data *pHalData;
                             ^
This variable is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Nam Cao March 26, 2023, 12:46 p.m. UTC | #1 
On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
>   'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
>         struct hal_com_data *pHalData;
>                              ^
> This variable is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> index e36f8c369a04..0cb2adcc1f78 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>  
>  void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
>  {
> -	struct hal_com_data *pHalData;
> -
> -
> -	pHalData = GET_HAL_DATA(padapter);
>  }

If this function doesn't do anything, does it not make more sense to
just remove this function entirely?

Best regards,
Nam
Greg KH March 26, 2023, 12:55 p.m. UTC | #2 
On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
> On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> > clang with W=1 reports
> > drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
> >   'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
> >         struct hal_com_data *pHalData;
> >                              ^
> > This variable is not used so remove it.
> > 
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> >  drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > index e36f8c369a04..0cb2adcc1f78 100644
> > --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
> >  
> >  void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
> >  {
> > -	struct hal_com_data *pHalData;
> > -
> > -
> > -	pHalData = GET_HAL_DATA(padapter);
> >  }
> 
> If this function doesn't do anything, does it not make more sense to
> just remove this function entirely?

This function is already removed in linux-next, so it doesn't matter :)

thanks,

greg k-h
Tom Rix March 26, 2023, 1:13 p.m. UTC | #3 
On 3/26/23 5:55 AM, Greg KH wrote:
> On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
>> On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
>>> clang with W=1 reports
>>> drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
>>>    'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
>>>          struct hal_com_data *pHalData;
>>>                               ^
>>> This variable is not used so remove it.
>>>
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>>   drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
>>>   1 file changed, 4 deletions(-)
>>>
>>> diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> index e36f8c369a04..0cb2adcc1f78 100644
>>> --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
>>> @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
>>>   
>>>   void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
>>>   {
>>> -	struct hal_com_data *pHalData;
>>> -
>>> -
>>> -	pHalData = GET_HAL_DATA(padapter);
>>>   }
>> If this function doesn't do anything, does it not make more sense to
>> just remove this function entirely?
> This function is already removed in linux-next, so it doesn't matter :)

My patch is against linux-next from tag next-20230324

Tom

>
> thanks,
>
> greg k-h
>
Greg KH March 26, 2023, 1:20 p.m. UTC | #4 
On Sun, Mar 26, 2023 at 06:13:16AM -0700, Tom Rix wrote:
> 
> On 3/26/23 5:55 AM, Greg KH wrote:
> > On Sun, Mar 26, 2023 at 02:46:52PM +0200, Nam Cao wrote:
> > > On Sun, Mar 26, 2023 at 08:23:21AM -0400, Tom Rix wrote:
> > > > clang with W=1 reports
> > > > drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:23: error: variable
> > > >    'pHalData' set but not used [-Werror,-Wunused-but-set-variable]
> > > >          struct hal_com_data *pHalData;
> > > >                               ^
> > > > This variable is not used so remove it.
> > > > 
> > > > Signed-off-by: Tom Rix <trix@redhat.com>
> > > > ---
> > > >   drivers/staging/rtl8723bs/hal/hal_btcoex.c | 4 ----
> > > >   1 file changed, 4 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > > > index e36f8c369a04..0cb2adcc1f78 100644
> > > > --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > > > +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
> > > > @@ -1179,10 +1179,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
> > > >   void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
> > > >   {
> > > > -	struct hal_com_data *pHalData;
> > > > -
> > > > -
> > > > -	pHalData = GET_HAL_DATA(padapter);
> > > >   }
> > > If this function doesn't do anything, does it not make more sense to
> > > just remove this function entirely?
> > This function is already removed in linux-next, so it doesn't matter :)
> 
> My patch is against linux-next from tag next-20230324

Ah, ok, well it will be gone in the next one, as this is already gone in
my tree.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
index e36f8c369a04..0cb2adcc1f78 100644
--- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c
+++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c
@@ -1179,10 +1179,6 @@  bool hal_btcoex_IsBtDisabled(struct adapter *padapter)
 
 void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType)
 {
-	struct hal_com_data *pHalData;
-
-
-	pHalData = GET_HAL_DATA(padapter);
 }
 
 void hal_btcoex_SetPgAntNum(struct adapter *padapter, u8 antNum)