From patchwork Sat Mar 25 17:33:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 74955 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp530202vqo; Sat, 25 Mar 2023 10:36:47 -0700 (PDT) X-Google-Smtp-Source: AKy350bdqIN2VA15mwt4Nq6D6eSN1YWo7csddShw9dOMI3Oeq7Tl4mRZbOWeTaZ9BWveOHos5kyS X-Received: by 2002:a17:902:fa46:b0:1a0:514c:c2d2 with SMTP id lb6-20020a170902fa4600b001a0514cc2d2mr5952884plb.68.1679765807297; Sat, 25 Mar 2023 10:36:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679765807; cv=none; d=google.com; s=arc-20160816; b=MPNi69fTZ3aQ+lH3p8nYyd0h4AvlvTrnw2yrNqVAaZVzYGe0nY17V+QO74p0SoP+AH 6dHOuHBGyR4RI3yrHc6KBOln8Ysf/AMZKpWl9QXHcAuPOXlQa6OSVFnr2Akic+wvx7aT C/MUuXKSRqhp4uiNcnl2lQxWIn2RdLLTMwehmSKetxiZk5CwptfE8MMPA34dSR3Q+Xi8 xTtXSoWiHPkmbL73T33mS2SKahjvnrLErPg3n05Mwl0hDUi8ogBo4dNTAvUzpCnfsScY +dDbjmhYp8jfVPPnOEHEAkaEnjM48bEu7s2gRRvsX7RCUoAOGWN/93kd+LxR+sd4e+hx PxJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WkqhMIgatpcxnL+zHWHZ8wmMPBfEMgxQ9GLo+81Qz2Y=; b=BCK/gf51X3TRJ+x/uqK849kFkTgHcuIcJ/nEc9Pky8lnddDbQ4nRlGKBpympWeRTfk P5sC1Qm2OclXxt+/dDWXwQcz2aXmJiEpUZpb7VOqBsGwF7zMSKpEM++5v32PtoBOFEyS uq9VvF6rCb8iGWeCa65RZmIfwNeQEcwqNEmMJR6hoqH6wsGszMThznr5mh/Qx2JXfUlO sHH80RLeJ9qqRWiV4RWaWOYxNT8ptY63mhBddlPIYBw27n3o4y21mjkwdcn/Bv8oWryw 628LxMjwQ11kMKjm+W5yW6ffVBjSH31wXZnP+ZB7ifEgQ2cITGFMsFioCROYuPsCeC0T ZhYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=urQ3eGiS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h5-20020a170902f54500b001a216fddd02si4604446plf.648.2023.03.25.10.36.34; Sat, 25 Mar 2023 10:36:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=urQ3eGiS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbjCYReZ (ORCPT + 99 others); Sat, 25 Mar 2023 13:34:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231801AbjCYReG (ORCPT ); Sat, 25 Mar 2023 13:34:06 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5458E3A1 for ; Sat, 25 Mar 2023 10:34:00 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id m16so3708014qvi.12 for ; Sat, 25 Mar 2023 10:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1679765640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WkqhMIgatpcxnL+zHWHZ8wmMPBfEMgxQ9GLo+81Qz2Y=; b=urQ3eGiSW39KOAg6HtdLQrdsQBhLE8fe/4vhcVkRPGPen+juA88G3/CNjtLggI5yz+ /Hsq3yl9CS37DT4iPWQayHWqbtRy9ZytQ8GAhvPbolMecAoOjwgCOLok1U+uYBLXNFGT fF2bATwed5QWM3wvD1atFjToYeb3jtgI3zZSQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679765640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WkqhMIgatpcxnL+zHWHZ8wmMPBfEMgxQ9GLo+81Qz2Y=; b=b9OmN0FfC+lJeTNdF24o1YooetMMrcOod7dB/w2EJElz6Pe9ORgHFRmIr4xr0PXQJP NqksVOhRng5WReSUNLkaWN6FS+rsU2+l9/ApdCEdixK9NTw6ArCmCvODZHVv2gGeRNbc FWgDKVzYYhfZ8ghPGO1hbU9+i/awX0AgdHcnLkoZPweHFEziRmCGqn73O45jmBSZIK6a UVRttUCecPShNsi8Qv7XpO9/G7FZwIiaLk6zkpqoUwqFFGoXSwKULdvUy9Ikk6er9vt9 +sQNxnSJz8q7VdqHLOhdli7VQbg01s3puQs9dM0HFGg/w0xyZgY3fFv6KmVM36tDak5/ iigA== X-Gm-Message-State: AAQBX9cZxF6/QKUch2UlxH7zAi0gm65YXz7Mn5C9CgBKSEB+QPAYBiDZ luc5/hbt1imU2jOLGgKUPUS6rOgOhxStnl70HRg= X-Received: by 2002:a05:6214:27c6:b0:574:97e9:e21c with SMTP id ge6-20020a05621427c600b0057497e9e21cmr11359421qvb.4.1679765639777; Sat, 25 Mar 2023 10:33:59 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id m4-20020ac84444000000b003e37ee54b5dsm6762764qtn.90.2023.03.25.10.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 10:33:59 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , "Paul E. McKenney" Cc: Zqiang , Anna-Maria Behnsen , Frederic Weisbecker , Joel Fernandes , linux-trace-kernel@vger.kernel.org Subject: [PATCH v2 07/13] rcu: Fix missing TICK_DEP_MASK_RCU_EXP dependency check Date: Sat, 25 Mar 2023 17:33:10 +0000 Message-Id: <20230325173316.3118674-8-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230325173316.3118674-1-joel@joelfernandes.org> References: <20230325173316.3118674-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761362111147394130?= X-GMAIL-MSGID: =?utf-8?q?1761362111147394130?= From: Zqiang This commit adds checks for the TICK_DEP_MASK_RCU_EXP bit, thus enabling RCU expedited grace periods to actually force-enable scheduling-clock interrupts on holdout CPUs. Fixes: df1e849ae455 ("rcu: Enable tick for nohz_full CPUs slow to provide expedited QS") Signed-off-by: Zqiang Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Frederic Weisbecker Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Anna-Maria Behnsen Acked-by: Frederic Weisbecker Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- include/trace/events/timer.h | 3 ++- kernel/time/tick-sched.c | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/trace/events/timer.h b/include/trace/events/timer.h index 2e713a7d9aa3..3e8619c72f77 100644 --- a/include/trace/events/timer.h +++ b/include/trace/events/timer.h @@ -371,7 +371,8 @@ TRACE_EVENT(itimer_expire, tick_dep_name(PERF_EVENTS) \ tick_dep_name(SCHED) \ tick_dep_name(CLOCK_UNSTABLE) \ - tick_dep_name_end(RCU) + tick_dep_name(RCU) \ + tick_dep_name_end(RCU_EXP) #undef tick_dep_name #undef tick_dep_mask_name diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 68d81a4283c8..a46506f7ec6d 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -281,6 +281,11 @@ static bool check_tick_dependency(atomic_t *dep) return true; } + if (val & TICK_DEP_MASK_RCU_EXP) { + trace_tick_stop(0, TICK_DEP_MASK_RCU_EXP); + return true; + } + return false; }