From patchwork Sat Mar 25 17:33:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 74957 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp530212vqo; Sat, 25 Mar 2023 10:36:49 -0700 (PDT) X-Google-Smtp-Source: AK7set9OfwEOXo2AvWvXEEQ5s4dM8EtQhTC6wHww7g24TgnuJwqYaIffYXYqjEvFd3HCvUAQAXjJ X-Received: by 2002:a05:6a20:4f24:b0:d9:3750:3a64 with SMTP id gi36-20020a056a204f2400b000d937503a64mr5897671pzb.8.1679765808912; Sat, 25 Mar 2023 10:36:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679765808; cv=none; d=google.com; s=arc-20160816; b=KyQGkmEIpl8kPoMMmQhlJrFKiAQgp2kCmHozyOBCiuEniZDe352lhyThshWWYQSN1Y z5yzaSkczL/8xf/k2n5/d+pn34ieLvBXNC/qriVCu4k2mAiHcAN+5kZSlyZZp7pdsRPw es6T+8+1yA+DYj36wgH3rvv2hY327RmXE9m51ItO/FurUthIAvWuYhgVg0fyZPWb5VMB hbqIUDpB3MMSMaaK/zDmfoqeFvCAxURcSVWBtLu0ARQulHWOvuqtSyFGRMGU2Cro/7ti DbPPD+UtochOydyjt8NwOR9LqpNLVPAIkRLc7ry84l8B7FCCZxpK0A3ZtOTfZoi3S2mO ouFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UZ68ufo3dlSNYy/wHT1VSjdWSVn/9QVi14RF92IRYWI=; b=mCE1iEn83ublHRdr+u6VKgvrp/sznmwC6nJO8Kwrl1Pun7v4BI+myC8tqpczL8eA6g ziyl9gm2hzfAfQlxf3ERoBQ0+Xj2zXER8nhQGiTXzYDQ2vAUuYJl2MVb2F+pgAFUhVkS DFYJCXcxrhODxmxy0JWIy3VcYcX7DH4zyExAtjabAGD+s6hJjt19WRq4C6K9zbVVbVhI A31pSTIuGeKcOb9Uk6N83o4/X+pwYPeCoUjSxslxJXKrbgVHdV90T77gw24GQh7tGN4C QYQQXcUpHW6u2Rt3hHx/wiU6You/Q8aL9dNyFUsAJitrxAK1M/MQ/Rre3V20HW0I0q6J i32A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=rewB8GWR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020a056a00174600b0062607a24e9bsi24898525pfc.68.2023.03.25.10.36.36; Sat, 25 Mar 2023 10:36:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=rewB8GWR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbjCYReU (ORCPT + 99 others); Sat, 25 Mar 2023 13:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231642AbjCYReF (ORCPT ); Sat, 25 Mar 2023 13:34:05 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7036293EA for ; Sat, 25 Mar 2023 10:33:58 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id g9so3760484qvt.8 for ; Sat, 25 Mar 2023 10:33:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1679765637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UZ68ufo3dlSNYy/wHT1VSjdWSVn/9QVi14RF92IRYWI=; b=rewB8GWRioBBXQ0+OtU3LnwuoNElryIFbsJ7aKxQ3weFJvUOxiEB/P7UxUewPyMZSL 0r1HOCc3xjU0O2QHqnA+X150fPaSTJMKWlTF94ORW6ja26gZ/PHxJeG7i9BdXKBpJKvN b0lzksxsctNEHyjKRiwt0rOdpfybqKxHJnJAk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679765637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UZ68ufo3dlSNYy/wHT1VSjdWSVn/9QVi14RF92IRYWI=; b=Y98DE1hS/KLlnAHVSUgRJKcMrrzf9ndejnq2rfPpfDNQx7txFaW7Q55xL9nnYFGo5C GXJ7CXkWYrgypHHxOTzQkfqkKCKgDzidI+N4iuUzEq7oXt4iktAssOmDEceK6BUf06x3 ECgVYxXiMino5T1jRQet9+CRMxPzP5NkUKcIuQhtyUVXHz6ECuBOFAFUantMYSffeBIM 9q4vrK3qJR9l8ZLLjaMU4IoJYr+jQ1qu5/YamUSXwclevAyOWxk2enK5mhNZ2AlTlmSA 8tW/sg7eOXTBOnNKs7ZRjTt4QPqToKEJJXiSHj44Q8a0daeWGdNwF/RE/6W79hWL7hJ8 ZDpA== X-Gm-Message-State: AAQBX9dWGzNA5Bo25Im94pJc2y+7BCGhhdAfgvEoXXuHMoIbCIoUnoQv 8SMnLVfo6giHyP+j+e0HzM1A5pb5ElKXBGH5UbU= X-Received: by 2002:a05:6214:2604:b0:5ab:e259:b2a9 with SMTP id gu4-20020a056214260400b005abe259b2a9mr13217724qvb.14.1679765637340; Sat, 25 Mar 2023 10:33:57 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id m4-20020ac84444000000b003e37ee54b5dsm6762764qtn.90.2023.03.25.10.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 10:33:56 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu Cc: Xu Panda , Yang Yang , "Paul E . McKenney" , Joel Fernandes , linux-trace-kernel@vger.kernel.org Subject: [PATCH v2 05/13] rcu/trace: use strscpy() to instead of strncpy() Date: Sat, 25 Mar 2023 17:33:08 +0000 Message-Id: <20230325173316.3118674-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230325173316.3118674-1-joel@joelfernandes.org> References: <20230325173316.3118674-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761362112896030984?= X-GMAIL-MSGID: =?utf-8?q?1761362112896030984?= From: Xu Panda This commit saves a line of code by switching from strncpy() to strscpy() by permitting the later NUL assignment to be removed. While in the area, save another line by taking advantage of 100 characters. Signed-off-by: Xu Panda Signed-off-by: Yang Yang Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) --- include/trace/events/rcu.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h index 90b2fb0292cb..c19ac1fa8a60 100644 --- a/include/trace/events/rcu.h +++ b/include/trace/events/rcu.h @@ -776,9 +776,7 @@ TRACE_EVENT_RCU(rcu_torture_read, ), TP_fast_assign( - strncpy(__entry->rcutorturename, rcutorturename, - RCUTORTURENAME_LEN); - __entry->rcutorturename[RCUTORTURENAME_LEN - 1] = 0; + strscpy(__entry->rcutorturename, rcutorturename, RCUTORTURENAME_LEN); __entry->rhp = rhp; __entry->secs = secs; __entry->c_old = c_old;