diff mbox series

bcma: remove unused mips_read32 function

Message ID 20230324190647.2654293-1-trix@redhat.com
State New
Headers
Series bcma: remove unused mips_read32 function |

Commit Message

Tom Rix March 24, 2023, 7:06 p.m. UTC 
  clang with W=1 reports
drivers/bcma/driver_mips.c:49:19: error: unused function
  'mips_read32' [-Werror,-Wunused-function]
static inline u32 mips_read32(struct bcma_drv_mips *mcore,
                  ^
This function is not used so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/bcma/driver_mips.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Simon Horman March 26, 2023, 9:37 a.m. UTC | #1 
On Fri, Mar 24, 2023 at 03:06:47PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/bcma/driver_mips.c:49:19: error: unused function
>   'mips_read32' [-Werror,-Wunused-function]
> static inline u32 mips_read32(struct bcma_drv_mips *mcore,
>                   ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Kalle Valo March 31, 2023, 3:05 p.m. UTC | #2 
Tom Rix <trix@redhat.com> wrote:

> clang with W=1 reports
> drivers/bcma/driver_mips.c:49:19: error: unused function
>   'mips_read32' [-Werror,-Wunused-function]
> static inline u32 mips_read32(struct bcma_drv_mips *mcore,
>                   ^
> This function is not used so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>

Patch applied to wireless-next.git, thanks.

21898a40b2f8 bcma: remove unused mips_read32 function
diff mbox series

Patch

diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
index 4f01e6b17bb9..9be0806eb033 100644
--- a/drivers/bcma/driver_mips.c
+++ b/drivers/bcma/driver_mips.c
@@ -46,12 +46,6 @@  static inline bool bcma_core_mips_bcm5357b0_quirk(struct bcma_device *dev)
 	       dev->id.id == BCMA_CORE_USB20_HOST;
 }
 
-static inline u32 mips_read32(struct bcma_drv_mips *mcore,
-			      u16 offset)
-{
-	return bcma_read32(mcore->core, offset);
-}
-
 static u32 bcma_core_mips_irqflag(struct bcma_device *dev)
 {
 	u32 flag;