From patchwork Fri Mar 24 16:52:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 74636 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp776872vqo; Fri, 24 Mar 2023 10:03:51 -0700 (PDT) X-Google-Smtp-Source: AKy350Z7DAcFnYSl4skNncWc06BJv/rnrewzwJbUOaQtm4I6oc3Jc6zSe6TG/Jw8QC1Iyyt6rJ8s X-Received: by 2002:a17:902:c404:b0:19d:611:2815 with SMTP id k4-20020a170902c40400b0019d06112815mr3812936plk.42.1679677431334; Fri, 24 Mar 2023 10:03:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679677431; cv=none; d=google.com; s=arc-20160816; b=Em+cbmjaUUbCUE40iACFMkgWATyOVDc7lV+hAtv/KI7w4ywpjZMY0HC0azedPkTXQO ZhYd8PEZM3hMEPUe4EygQqoIuBOPHjQmg+GYqHvA+k2RJ/pzE46rwTdq+qCYzUurCsto 88N05NmFAvAKo4HrjlaFbq75eJjISCx6JzRB3YcZp1E+RPsxRrLY4fZXbjDMO5DD/Tu9 zIVWgz2F5HwDMrkW3Te/T1wBR8Rr+zaBkKQyeNhU9WQ8s+Jsgol1h1+YUSRDDI2du0Ni aq70aswFvZSnU2Nr+iGXFt8HDCr9HjESRCDCA3QasczFse+A91EnUqmnj4BH9d4aUHGj WTGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yryH7vC/nq+vPaNPZHPoVGq5Z2O/K90ppTi/YYO51JY=; b=oAYa3Lm5TLMNOFcdpdeduNsKpXzWIFm3C+Y6Ex2aybABRb/rWmL7jggayEw7c/QPKs OPopwzRlmeRdKvLNYp5ghluUY5M9K4rSIVFh7Irz1eG8T33XVw8K8MTGhfT7B8evvaqs 7g9CznoHcCb3Rh9E6fST6zH6BiSSZPq0W9cN+4M/LkAWAyQPp6ov30SxDzztBf8lXzIA 2xYnAgqcrSNIuyV7duyOxfi6VvWsB2qneLuO2iHDDNwnk3Km57MF21OAEFty6/sr5HYO MRcvtWEP60+dLbc+9KVIyH3GL72qGJfv8BlSvAGQmQhk804mUB0ncxtnZ6XrTdiaAcqd eC4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=kIIIpztV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x186-20020a6386c3000000b005002c1ba496si22118495pgd.305.2023.03.24.10.03.22; Fri, 24 Mar 2023 10:03:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=kIIIpztV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231740AbjCXQwq (ORCPT + 99 others); Fri, 24 Mar 2023 12:52:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230471AbjCXQwn (ORCPT ); Fri, 24 Mar 2023 12:52:43 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D595A20A04 for ; Fri, 24 Mar 2023 09:52:42 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id dw14so1652285pfb.6 for ; Fri, 24 Mar 2023 09:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679676762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yryH7vC/nq+vPaNPZHPoVGq5Z2O/K90ppTi/YYO51JY=; b=kIIIpztVKyE5TXz0P71w7WJI5CmZz5r8zbxD43sBhuip0MZ7zB23xN35SkJY+xhzXO eyRs/LSQ6MknuWfh1pjW8hABr6NQjdoz3VZd0EDX5xJvzhaBFpK0cCFxbguwNKZmjTXa ju50zmTka9Y8mBIIS9sylBwGlI1aGTmctFZOPDoKg2Dq+/ZaiyRyRKR8MrkCbcmRry7L y/jjP9f2wRNbFoDD+JG+2avvTMjWpFKaoPi/1y6n/PqBsZcWNHoypqbySXVuMkh1iCbP 8RDdgVo9+yhglsNlqubZpyBJmvxMymK2kR2hhCb+eW9dGJt+IiSkoeHfV2MjA9Mc33Tn 6hKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679676762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yryH7vC/nq+vPaNPZHPoVGq5Z2O/K90ppTi/YYO51JY=; b=Zwmo2+DX7Ym979bb6Jioc94fkyivIoDPnrdAvK3MpOtlSrzbvCBuD3rvRwR6U6Fgbp fexRGTJDcNLhViT1D+XIAHUcG2PJCDIh3iEj6YnJ0Foy+nLgPFK+/sLdpVdmJUl4AXv8 Qw+8g+HWFlJaB8Q6UhQPKPyXVrNKgz/EEdDH8XCsTiMt7jiAmBhkL8d8m4dpPx2RB739 Eub3/r5R2IlkKN3OZWuLJX/APgrr45xU53M3ayj4UXoZYNVjAXcN5djyIJ7s4qm/xl8/ +VBWmQ2k+naM/GIBKGi+FUPPDX/8GtlsFv5r7KGr5U22gnewMv1Zy7zsPzWjq07kLkYG dh9g== X-Gm-Message-State: AAQBX9d+KsPzcZGCHoV7cXHx+WdyjGOOWrCTgBzgojxk1DsbQnDhvSQg rjKLzV6IavFu6gwEctP0lgWG4JGqBVY= X-Received: by 2002:a62:5254:0:b0:626:286d:b701 with SMTP id g81-20020a625254000000b00626286db701mr3768348pfb.20.1679676761902; Fri, 24 Mar 2023 09:52:41 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a5-20020aa780c5000000b0062b5a55835dsm1420289pfn.213.2023.03.24.09.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 09:52:40 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Broadcom internal kernel review list , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE) Subject: [PATCH 1/3] memory: brcmstb_memc: Cache configuration register value Date: Fri, 24 Mar 2023 09:52:29 -0700 Message-Id: <20230324165231.3468069-2-f.fainelli@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324165231.3468069-1-f.fainelli@gmail.com> References: <20230324165231.3468069-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761269442436817927?= X-GMAIL-MSGID: =?utf-8?q?1761269442436817927?= The configuration register does not change once the DDR controller is configured, in preparation for providing more information about the DDR type/width in subsequent changes, store this value so we can retrieve it. Signed-off-by: Florian Fainelli --- drivers/memory/brcmstb_memc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/memory/brcmstb_memc.c b/drivers/memory/brcmstb_memc.c index 233a53f5bce1..67c75e21c95e 100644 --- a/drivers/memory/brcmstb_memc.c +++ b/drivers/memory/brcmstb_memc.c @@ -29,18 +29,15 @@ struct brcmstb_memc { struct device *dev; void __iomem *ddr_ctrl; unsigned int timeout_cycles; + u32 config_reg; u32 frequency; u32 srpd_offset; }; static int brcmstb_memc_uses_lpddr4(struct brcmstb_memc *memc) { - void __iomem *config = memc->ddr_ctrl + REG_MEMC_CNTRLR_CONFIG; - u32 reg; - - reg = readl_relaxed(config) & CNTRLR_CONFIG_MASK; - - return reg == CNTRLR_CONFIG_LPDDR4_SHIFT; + return (memc->config_reg & CNTRLR_CONFIG_MASK) == + CNTRLR_CONFIG_LPDDR4_SHIFT; } static int brcmstb_memc_srpd_config(struct brcmstb_memc *memc, @@ -148,6 +145,9 @@ static int brcmstb_memc_probe(struct platform_device *pdev) of_property_read_u32(pdev->dev.of_node, "clock-frequency", &memc->frequency); + memc->config_reg = readl_relaxed(memc->ddr_ctrl + + REG_MEMC_CNTRLR_CONFIG); + ret = sysfs_create_group(&dev->kobj, &dev_attr_group); if (ret) return ret;