From patchwork Fri Mar 24 08:43:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Straube X-Patchwork-Id: 74440 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp479933vqo; Fri, 24 Mar 2023 02:10:13 -0700 (PDT) X-Google-Smtp-Source: AKy350Y9+MYIf3CZeWwEI2TYEHRf50eSpOZKMdtmtTBYdsZSOWNncwy7BvNIbVsSLtSDm1qDMn5A X-Received: by 2002:a17:902:f9c8:b0:19a:9055:6658 with SMTP id kz8-20020a170902f9c800b0019a90556658mr6735268plb.18.1679649013559; Fri, 24 Mar 2023 02:10:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679649013; cv=none; d=google.com; s=arc-20160816; b=PqI5t+FJDUukkRaHuhOg76LIKEi8Yeqghr9Yz6FTzsbkIN9R0D4c9aLRdBPaDl73DX dJikRGw7eygOD7VGPupY/vBqSiRDN+YrwBCdcJxE3G7iZlu985mWHrG1gHoIbRAHF0UM 2ozNZ8GOXvTlbeVmdKy1wnSkbH6KggaOuHhrBg2r3PuUzFCySgpiQjA6ynE+8Y0DBKNI 7i2y9mvUKbVwIOSRlHaABLQiDKPvk/Cet71PTlTtexzrdg1hizKYT0MyfIEHaT93+8DV cD6C7aXZH6Mh1wKePF29fHiz5613FUwnW7VpuU+YDfpL5qFsjgFeqErliH1bb+1DjQiM 8kbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hoF1dEts5ZEjp1FZMKp6l1BB4iGLDqqZHFHPN/cDT+w=; b=gZ/MlTpWiR4GwIRMBfl9BafHguoNmc9ayIyP+N/iBxR6Q5yU2A75rDQnd4aoWk97UH 4uymLrCvu3RvbQ2gp9J+083HulQcUFI/m5i2Dtimu3BXGmQamy/DqYC3YkTDqiqxluT0 OkBK3/E5HqTEVA0jO4T48PNuykHDsFL98GGa4TDgL9UG02QL5hbCvs64x80/4NNsIA0P 38bUC+zIV1SLwFbGY4u2KUJC0Nj4aU4wDGLKmkzv0LsfoxCwC8UqRVEsb54z/zqEadMK edRBL3ptbI0H1Ns1pdmcH4/w+b0ygVshWvYvvgFt1T4zU52MsOA2t8U0Y8BU5aAYoi/Q qbQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q2VJ6600; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c12-20020a170902848c00b0019ca3e987dbsi19326065plo.631.2023.03.24.02.09.59; Fri, 24 Mar 2023 02:10:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Q2VJ6600; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231715AbjCXIoE (ORCPT + 99 others); Fri, 24 Mar 2023 04:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbjCXInv (ORCPT ); Fri, 24 Mar 2023 04:43:51 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32DE17CF3 for ; Fri, 24 Mar 2023 01:43:46 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id y4so4961450edo.2 for ; Fri, 24 Mar 2023 01:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679647425; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hoF1dEts5ZEjp1FZMKp6l1BB4iGLDqqZHFHPN/cDT+w=; b=Q2VJ6600mh7wJmjZ84lQ+DLwBgjP/ZkP4WG27uAKbRDfk1tllcRibWV7wshgCtm7oo Su11VKIashAdjwci+IPkcdpp1rAp8VJ8Wc65gIEFwMzqQRIeDYOEnZrgyze3dbnj0AUw ATs0FmLx3rBffOTbS1qsxi+DUOsnHG5I69RLu7papZ+9u9iSOeP+YlsSoGVpBtLrhIfR hV6yhGiKenwGfzaEiAem4TT7Px47IlWhh3m6O7S9ueqYzblYlSDYFjCdy5QuRnuqjrmC b4b36nDqPnPQtOdzgdcxo7Gug6Gk1KFoBi4FLl4snqZ/jYw+2BlcEh37deY8TBPu5a/U REpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679647425; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hoF1dEts5ZEjp1FZMKp6l1BB4iGLDqqZHFHPN/cDT+w=; b=exe2ec2ZRTJQSJDuoBsAk1a0wIE560DlITHnTbMbuwZUR3sTpQ7W3avoUloh5MkcUu NnGBU+SMZWlajJ0YJ5OV7Wlq8bVc3XgnFRIKFNOrvGOeo1gnD4LktLHWpMAV6jqVyo08 +JM9IXKhoSXY//3sBGCLIeXuutM9i82Lf5TeFNoUP0l3pV9zLhYJYr8eubHSyU5Mu3jf yGGXQGF8QyHOuYpgZ3IE2AMjP/MTDLYL++rIMO4Z0Bb3kkWc0BH6dGBcVq/ABesrbY3b mu01jI5pg48t6yIBngn0QcsIOiUVIBJx+o1I8i0y0JbaenJdSTZpH4NfEFR+tHNKDOiV fzPQ== X-Gm-Message-State: AAQBX9c1Wply8kFea/NVtQYWaJcO/Pw5CEMUgJatrMv/9f+cHBNZ3vMj lWjDb3a//Wg2NeW3ukCm+yk= X-Received: by 2002:a17:906:4e0a:b0:931:829c:9d58 with SMTP id z10-20020a1709064e0a00b00931829c9d58mr1792963eju.23.1679647424996; Fri, 24 Mar 2023 01:43:44 -0700 (PDT) Received: from localhost.localdomain (ip5f5abbaa.dynamic.kabel-deutschland.de. [95.90.187.170]) by smtp.gmail.com with ESMTPSA id m2-20020a50d7c2000000b00501fc87352fsm3541841edj.13.2023.03.24.01.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 01:43:44 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH] staging: rtl8723bs: remove hal_btcoex_SetChipType() Date: Fri, 24 Mar 2023 09:43:34 +0100 Message-Id: <20230324084334.12183-1-straube.linux@gmail.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761239644132128541?= X-GMAIL-MSGID: =?utf-8?q?1761239644132128541?= Remove the function hal_btcoex_SetChipType() as it does nothing and produces the following gcc warning when compiling with W=1. drivers/staging/rtl8723bs/hal/hal_btcoex.c:1182:30: warning: variable 'pHalData' set but not used [-Wunused-but-set-variable] 1182 | struct hal_com_data *pHalData; | ^~~~~~~~ Signed-off-by: Michael Straube Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 8 -------- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 - drivers/staging/rtl8723bs/include/hal_btcoex.h | 1 - 3 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/rtl8723bs/hal/hal_btcoex.c index e36f8c369a04..e26b789b9cdd 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -1177,14 +1177,6 @@ bool hal_btcoex_IsBtDisabled(struct adapter *padapter) return false; } -void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType) -{ - struct hal_com_data *pHalData; - - - pHalData = GET_HAL_DATA(padapter); -} - void hal_btcoex_SetPgAntNum(struct adapter *padapter, u8 antNum) { struct hal_com_data *pHalData; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 0fcae6871108..c3c1b49674d3 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -2304,7 +2304,6 @@ void Hal_EfuseParseBTCoexistInfo_8723B( } hal_btcoex_SetBTCoexist(padapter, pHalData->EEPROMBluetoothCoexist); - hal_btcoex_SetChipType(padapter, pHalData->EEPROMBluetoothType); hal_btcoex_SetPgAntNum(padapter, pHalData->EEPROMBluetoothAntNum == Ant_x2 ? 2 : 1); if (pHalData->EEPROMBluetoothAntNum == Ant_x1) hal_btcoex_SetSingleAntPath(padapter, pHalData->ant_path); diff --git a/drivers/staging/rtl8723bs/include/hal_btcoex.h b/drivers/staging/rtl8723bs/include/hal_btcoex.h index fb167642da01..525cce3574fe 100644 --- a/drivers/staging/rtl8723bs/include/hal_btcoex.h +++ b/drivers/staging/rtl8723bs/include/hal_btcoex.h @@ -23,7 +23,6 @@ struct bt_coexist { void hal_btcoex_SetBTCoexist(struct adapter *padapter, u8 bBtExist); bool hal_btcoex_IsBtExist(struct adapter *padapter); bool hal_btcoex_IsBtDisabled(struct adapter *); -void hal_btcoex_SetChipType(struct adapter *padapter, u8 chipType); void hal_btcoex_SetPgAntNum(struct adapter *padapter, u8 antNum); void hal_btcoex_SetSingleAntPath(struct adapter *padapter, u8 singleAntPath);