From patchwork Thu Mar 23 19:06:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Beau Belgrave X-Patchwork-Id: 74174 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp3085544wrt; Thu, 23 Mar 2023 12:08:08 -0700 (PDT) X-Google-Smtp-Source: AK7set9B4Ys9ZEmc53g612vnFBJeqFsa8wMxeaSOkDM7T2DVt8KA8qmNJzGTmjRDSZuWF9fXkE3O X-Received: by 2002:a05:6a20:8009:b0:d9:e5db:5287 with SMTP id e9-20020a056a20800900b000d9e5db5287mr609613pza.4.1679598488427; Thu, 23 Mar 2023 12:08:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679598488; cv=none; d=google.com; s=arc-20160816; b=RqU++tgJUsvi93wMl7wwvWO+UzgcRMy9rzoqVsXlGS7ERibRu9DI2bWj0V9ct+ul8O J810Y+aEndKVcF8BltXPBKDW/CqzlQxs4UPm/Ucoflk2y610RkrzARCXlqRIhufdsxMg DyrZOiFCfWCg8p7IedM3PE3ZRnL4Lxf5Z927gOp4t3i82sYbcCqG4dxQdXHaFM7GQaFw xiMdDqchQbPSC8LymQwoG2WH18UupdpUTtd0GdocARt1yzdchimUOrbpFFym1nTyJe9O ALMtGH9RGv9gw3p9zZAwNQqk0JqcfrzCy50SWTpcR4CyZjxF1+RnjIonpjL9nTo5S+fb XH7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=dmkEXknb1A0Qhw2AWPTXryudmpuAFo4IqxhDoe6dNiw=; b=VnBspzjYfa1srlampENBULEKux1Bz9i4/7vFBRq1PEqB5D0Ulzj0m49BkyfOqt4mmB Q48N4gfhSqT4+ZeBfQEi+zuZHD4r8ZcXhEBXLGg+YLGCOH4KLL+POnjTlP1yw4sJp/i9 /v79O5mGlzU6pPpJNq3aBQtgO0bnb0ACxMbK8pTQ2SJcNFMKGv6Md+HgWTu/M/7hSRRL MJ6kacv8D95/L6XjyedopYaL7J7+tJJD0B+kqJa6ASYaabLBcG/TGHzJFqGzJEbhMD6a r5gn3PlipNt3x4ovAggrV4L0SUfy9f2nGkpFylDHGawEciI48u8UvYKDSRiZVv45aSLu Ib9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=P6MesIwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c16-20020a056a00249000b006281f2d375dsi6222585pfv.132.2023.03.23.12.07.54; Thu, 23 Mar 2023 12:08:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=P6MesIwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231735AbjCWTGx (ORCPT + 99 others); Thu, 23 Mar 2023 15:06:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231636AbjCWTGi (ORCPT ); Thu, 23 Mar 2023 15:06:38 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4EEAD33449; Thu, 23 Mar 2023 12:06:33 -0700 (PDT) Received: from W11-BEAU-MD.localdomain (unknown [76.135.27.212]) by linux.microsoft.com (Postfix) with ESMTPSA id 7CFCE20FC3CF; Thu, 23 Mar 2023 12:06:17 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7CFCE20FC3CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1679598377; bh=dmkEXknb1A0Qhw2AWPTXryudmpuAFo4IqxhDoe6dNiw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P6MesIwOojUCuQ3GuY7LjicEPdHYhGGiJQ+CLacm4xFS3stHwHJQoJTlvELbhrp+o QhEPZcaTIQYaIwcGDCBf2ezN2TCYtIuMYH83fwOTCwPa3Mz8GowW+tWbMgGdCwaFrA WBvnVy6owmiFugDjS1/g/mkA32fYLpZvgBT8FRgQ= From: Beau Belgrave To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, dcook@linux.microsoft.com, alanau@linux.microsoft.com, brauner@kernel.org, akpm@linux-foundation.org, ebiederm@xmission.com, keescook@chromium.org, tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [RESEND PATCH v8 08/11] tracing/user_events: Use write ABI in example Date: Thu, 23 Mar 2023 12:06:07 -0700 Message-Id: <20230323190610.251-9-beaub@linux.microsoft.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230323190610.251-1-beaub@linux.microsoft.com> References: <20230323190610.251-1-beaub@linux.microsoft.com> MIME-Version: 1.0 X-Spam-Status: No, score=-17.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761186664712745791?= X-GMAIL-MSGID: =?utf-8?q?1761186664712745791?= The ABI has changed to use a remote write approach. Update the example to show the expected use of this new ABI. Also remove debugfs path and use tracefs to ensure example works in more environments. Signed-off-by: Beau Belgrave --- samples/user_events/example.c | 47 +++++++---------------------------- 1 file changed, 9 insertions(+), 38 deletions(-) diff --git a/samples/user_events/example.c b/samples/user_events/example.c index d06dc24156ec..28165a096697 100644 --- a/samples/user_events/example.c +++ b/samples/user_events/example.c @@ -9,51 +9,28 @@ #include #include #include +#include #include #include #include -#include -#include #include -#if __BITS_PER_LONG == 64 -#define endian_swap(x) htole64(x) -#else -#define endian_swap(x) htole32(x) -#endif +const char *data_file = "/sys/kernel/tracing/user_events_data"; +int enabled = 0; -/* Assumes debugfs is mounted */ -const char *data_file = "/sys/kernel/debug/tracing/user_events_data"; -const char *status_file = "/sys/kernel/debug/tracing/user_events_status"; - -static int event_status(long **status) -{ - int fd = open(status_file, O_RDONLY); - - *status = mmap(NULL, sysconf(_SC_PAGESIZE), PROT_READ, - MAP_SHARED, fd, 0); - - close(fd); - - if (*status == MAP_FAILED) - return -1; - - return 0; -} - -static int event_reg(int fd, const char *command, long *index, long *mask, - int *write) +static int event_reg(int fd, const char *command, int *write, int *enabled) { struct user_reg reg = {0}; reg.size = sizeof(reg); + reg.enable_bit = 31; + reg.enable_size = sizeof(*enabled); + reg.enable_addr = (__u64)enabled; reg.name_args = (__u64)command; if (ioctl(fd, DIAG_IOCSREG, ®) == -1) return -1; - *index = reg.status_bit / __BITS_PER_LONG; - *mask = endian_swap(1L << (reg.status_bit % __BITS_PER_LONG)); *write = reg.write_index; return 0; @@ -62,17 +39,12 @@ static int event_reg(int fd, const char *command, long *index, long *mask, int main(int argc, char **argv) { int data_fd, write; - long index, mask; - long *status_page; struct iovec io[2]; __u32 count = 0; - if (event_status(&status_page) == -1) - return errno; - data_fd = open(data_file, O_RDWR); - if (event_reg(data_fd, "test u32 count", &index, &mask, &write) == -1) + if (event_reg(data_fd, "test u32 count", &write, &enabled) == -1) return errno; /* Setup iovec */ @@ -80,13 +52,12 @@ int main(int argc, char **argv) io[0].iov_len = sizeof(write); io[1].iov_base = &count; io[1].iov_len = sizeof(count); - ask: printf("Press enter to check status...\n"); getchar(); /* Check if anyone is listening */ - if (status_page[index] & mask) { + if (enabled) { /* Yep, trace out our data */ writev(data_fd, (const struct iovec *)io, 2);