From patchwork Thu Mar 23 16:13:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 74117 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp3026227wrt; Thu, 23 Mar 2023 10:00:03 -0700 (PDT) X-Google-Smtp-Source: AK7set/JW4HohJYJCAkuwC8/XeB6XrG1QfKB2UgKqqDoUS5KTaDN+hRv7kCcBf2JWPT16ZvmsAc4 X-Received: by 2002:a05:6402:944:b0:4ad:f811:e267 with SMTP id h4-20020a056402094400b004adf811e267mr6372940edz.12.1679590803326; Thu, 23 Mar 2023 10:00:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679590803; cv=none; d=google.com; s=arc-20160816; b=yw2mfPBsBrwyXZwg0/BkVznGxUxcEcaUgJpY7fIN2mkKet6FnFGQPHxDxIOVQOMAeI T78YfdEAWSOHKY1fNS3SN7qmEmoY0yDVtX2b/LFAHRJ8EFdoq7N3gazyMUGQaCMUiMPo WsSYQnqirs2iq8S2xRutR9QuHOlMG5xFTN1qXVpCFaD9tqzpZmJvRai9oWphwW3ttX8u Sjt8AY0bBOMH4CTmhMeaNjZNV0VtHm9eqEFVdsTOmBCLvlPfNMcgUQZPb0lggedyLKHJ HhWuUcRNj38oR0wql8S+ay0BpVoR/7g6GMBpy+9Phz7860PS8ADyrESFBcxrJ5pqRzdf dlng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KbMR0xrX13/vpqXtbfb3ZQ/trhkNWEMduVf+oaF3Fe8=; b=hbfwpBdYh6kK+5ATpKRurI6I/jkZkOmT7qrVMuI4ntV5vWMoKokAYsNRG400juZunJ Bgcc7811v0oRiKIko7k4ywK++zqghQkMCwjqzIrzjG4LwjDh/y3D6RHTb5JshHdFdE4e 6eHY4vkxfz4RUdPwq2PbL4IhE3PKCWLSudPID4saSM3rHXuzCrAyI796Ew7Ec3rKJg7t yYZakNuXxG1cEgNC9WLcP5/yW7tq65FQqOqY56qR+UD0zVObe2jxwUo4Lq/FwO52X3S0 ZSz3S5BvDbSx6wKdng5am8rfz2wK/fevx5ILFLV3pn6JQXmIE7fuHClMh0mRP77Tgep/ Bo9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="ePgoR3e/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c10-20020aa7df0a000000b004fe1ad4197dsi17809704edy.412.2023.03.23.09.59.36; Thu, 23 Mar 2023 10:00:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="ePgoR3e/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbjCWQPP (ORCPT + 99 others); Thu, 23 Mar 2023 12:15:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231748AbjCWQOs (ORCPT ); Thu, 23 Mar 2023 12:14:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B870F3524F for ; Thu, 23 Mar 2023 09:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679588029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KbMR0xrX13/vpqXtbfb3ZQ/trhkNWEMduVf+oaF3Fe8=; b=ePgoR3e/HJUjVc/izt8I1GH6kbxr4FjvnQ7mvCU0iH2RnJHJnPNm7F4STlIC3CucMWmXrD 4DmqvQHPkxSc6ai4GdmV4+QGE3RwcMZzhKorf+zTdm+6n7IDfQNh8S1oN5WWdT09u2divM 21bJiFIrjOihYRZauG7MF/owQEnb0ZY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-Hqax35nLM1Gr87Qb4gkJPA-1; Thu, 23 Mar 2023 12:13:47 -0400 X-MC-Unique: Hqax35nLM1Gr87Qb4gkJPA-1 Received: by mail-qk1-f200.google.com with SMTP id d72-20020ae9ef4b000000b007467a30076fso6739525qkg.18 for ; Thu, 23 Mar 2023 09:13:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679588027; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KbMR0xrX13/vpqXtbfb3ZQ/trhkNWEMduVf+oaF3Fe8=; b=p252mfEhdmRSxuWQ15FXOdPnYT9wY5LDsHMGbOS2ZjV3zY3a9BlaMWxepavfwb1Qty tkiJgcrnTbrUAfpcygUFOKEIy6S0b08NM+SHtlyid+YOsLYAzI+LKjdZvnsoTpbABqKZ B52slU3unZqmcuwsogwQdbuMDAeNV3Z5Mn7QcskaBBhZosEZ6J//U5isUD1ASz0L7Lq1 nJj/t9B8w2LHdxlKcARkoldu/xbfmqcmiOrPedZhu0WVrSg0TuqRpx5CddIfAI1/kMpc 81TMTxSahdEA83mHW7+y5DVsZIlHunVsGy4Yh7nYmD/bbO6LS2LPl7l1YnnhM1irEBY9 085g== X-Gm-Message-State: AO0yUKX53HQU9zTmdt2KL9Dz6bu0+Lc0Qo3aL7KYcVWpwyOjRxSzA3Cd UvGR2pt37eTUQRzka15reWmwwqFnCFSvX3P5XDZbLWXuRcupsemEft2qbDoTYfyKYBgHj/gIUGA fCO9NtzFOMA2cfh9Ugywj0TBN X-Received: by 2002:ac8:7fc6:0:b0:3e3:8ed5:a46b with SMTP id b6-20020ac87fc6000000b003e38ed5a46bmr7580400qtk.34.1679588027009; Thu, 23 Mar 2023 09:13:47 -0700 (PDT) X-Received: by 2002:ac8:7fc6:0:b0:3e3:8ed5:a46b with SMTP id b6-20020ac87fc6000000b003e38ed5a46bmr7580361qtk.34.1679588026709; Thu, 23 Mar 2023 09:13:46 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id c20-20020ac86614000000b003e1080e0f8csm7631543qtp.16.2023.03.23.09.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 09:13:46 -0700 (PDT) From: Tom Rix To: isdn@linux-pingi.de, nathan@kernel.org, ndesaulniers@google.com, yangyingliang@huawei.com, alexanderduyck@fb.com, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix , Simon Horman Subject: [PATCH] mISDN: remove unused vpm_read_address and cpld_read_reg functions Date: Thu, 23 Mar 2023 12:13:43 -0400 Message-Id: <20230323161343.2633836-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761178605947445877?= X-GMAIL-MSGID: =?utf-8?q?1761178605947445877?= clang with W=1 reports drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function 'vpm_read_address' [-Werror,-Wunused-function] vpm_read_address(struct hfc_multi *c) ^ drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function 'cpld_read_reg' [-Werror,-Wunused-function] cpld_read_reg(struct hfc_multi *hc, unsigned char reg) ^ These functions are not used, so remove them. Reported-by: Simon Horman Signed-off-by: Tom Rix Reviewed-by: Simon Horman --- drivers/isdn/hardware/mISDN/hfcmulti.c | 31 -------------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c index e840609c50eb..2e5cb9dde3ec 100644 --- a/drivers/isdn/hardware/mISDN/hfcmulti.c +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c @@ -639,23 +639,6 @@ cpld_write_reg(struct hfc_multi *hc, unsigned char reg, unsigned char val) return; } -static inline unsigned char -cpld_read_reg(struct hfc_multi *hc, unsigned char reg) -{ - unsigned char bytein; - - cpld_set_reg(hc, reg); - - /* Do data pin read low byte */ - HFC_outb(hc, R_GPIO_OUT1, reg); - - enablepcibridge(hc); - bytein = readpcibridge(hc, 1); - disablepcibridge(hc); - - return bytein; -} - static inline void vpm_write_address(struct hfc_multi *hc, unsigned short addr) { @@ -663,20 +646,6 @@ vpm_write_address(struct hfc_multi *hc, unsigned short addr) cpld_write_reg(hc, 1, 0x01 & (addr >> 8)); } -static inline unsigned short -vpm_read_address(struct hfc_multi *c) -{ - unsigned short addr; - unsigned short highbit; - - addr = cpld_read_reg(c, 0); - highbit = cpld_read_reg(c, 1); - - addr = addr | (highbit << 8); - - return addr & 0x1ff; -} - static inline unsigned char vpm_in(struct hfc_multi *c, int which, unsigned short addr) {