From patchwork Thu Mar 23 17:30:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 74134 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp3043694wrt; Thu, 23 Mar 2023 10:33:27 -0700 (PDT) X-Google-Smtp-Source: AK7set+wb+Rqvi6OEK/0O6w+4JFNmrbsP+lH1GhPK6vVl3Wde5EOs5ZVBE1/s4mUSziNjXlnRNeD X-Received: by 2002:a17:90a:305:b0:234:13a3:6e67 with SMTP id 5-20020a17090a030500b0023413a36e67mr9129175pje.12.1679592807538; Thu, 23 Mar 2023 10:33:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679592807; cv=none; d=google.com; s=arc-20160816; b=iTt9qii9wyCxrdw72R40ZY2G2sPn+/0WVuGN31jEqlhHnJB8ix9ZUNWjWJOTNjIGQG qpI3OnB8a1eVung18lt51rSknRHntTcLX5tBj7a3zCZK8JmGaFIarDpPE4aM8GArRA6/ U+dXmVyFuUZ3YVOp8Egq3L0Yroai1GprP2zfe3Hhua3fZnnlouRl7+EFo6qJC2/kH8zu +9ZzUwurm0ZP/vpcznhlA8QOz0IfYCC14GNU7QxthvatI6ImWkWf4I/Zzy4Dtp6mfCz3 pHCiUR6uFZPcwe03YKwAMgVDsukUo5f6atyiUdpZcZvTlM+ohk+dY07OjIkPxiKvtDul R9cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e0GSudvBlA2ChvW+1tK19vXmBXB0gm+MldtIhXHWk80=; b=AOxi9Aum1oGwGbC4kcyIPtVswjWysZzTld5d4Gabk4Dy+uNArGzEmkL356vssyRRwZ S6nNxH9AeCAeiQs2weVpsTVEwQ3YdJO27ek2pC/8JTZe2bht6QiwP1chqaqXD1OCAJex y/KhXiAojXhUvfP1fAYT0k2f6RFBUgEGhzqwBNbUpj9UuQtRt9ZDOthMuj7AXQkB0ZMV Cr/+EmTeMDMfUNa0vKAV5b2fXshC3oZsgUWEvuO8v4nvtI0Rc6WKFpxoJ5QHAkjgbx42 RyA0wtYXJmIy1Tbh4LdayLHUYvhHGHQ9waKwmylDqFb9pnpzbaUQYikduwVB3/SzoxUL vQqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=f8MEMPhD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q4-20020a17090a9f4400b002340e454213si2164673pjv.190.2023.03.23.10.33.10; Thu, 23 Mar 2023 10:33:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=f8MEMPhD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbjCWRcT (ORCPT + 99 others); Thu, 23 Mar 2023 13:32:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232514AbjCWRbu (ORCPT ); Thu, 23 Mar 2023 13:31:50 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B02BA37554 for ; Thu, 23 Mar 2023 10:31:34 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id d13so22158926pjh.0 for ; Thu, 23 Mar 2023 10:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1679592693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e0GSudvBlA2ChvW+1tK19vXmBXB0gm+MldtIhXHWk80=; b=f8MEMPhDfzoFegAhp/wfBqbHVIsGQ736bOmKQD+YQO8hYiVarK1C43+BZhyvyHDqb2 qygRDuX5MFaxcnB+jTX/PyrCbyk3gwQ0pCf4mCgXPd54jUhyzslyhuPnUX3NjxMNenuD Vf4bdDfS4YeAdxNX5bBueM8Yuj7TfCR5AR4zM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679592693; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e0GSudvBlA2ChvW+1tK19vXmBXB0gm+MldtIhXHWk80=; b=6Htk9QLiNiXShbg89ThpHi7Ew1ZJiJpoH9BKVsZ4jyc01TaRuzO7+9x5re8VcAWf5s Qb4Eh8fVrBOhN7cQ6Ylr+V7somiMjX0nkfGR9bHkLE6s4oIwnAMhzDkVInL3aLz1zrhv uKeFfrLGPo+M3B5r3bzOn6dGZBD57TADD+eniuQW1VMeItAUx5PvKhZZQQoI8dUKaf9O GYcfZxCnTVSBwJDARLCzIaOY7c6huHpkQeH1l4VhUNsX89ksFow5LebFqJgx3g4A1PWV +lCv+Ba/IpgFWKZ/jVTNy6BmMbNhxtZUc33freHZJFkJBgz/IbwPP+1+h9DPd+gx/yOc u0Cg== X-Gm-Message-State: AO0yUKXDX6aEGjndsW/FJclIsmsZNeQkeBcEf68kiRK20XH6IKSB8zTW 6ZxzfyNgmR0zPioFF81EdJQWoQ== X-Received: by 2002:a05:6a20:718a:b0:d9:a792:8e3d with SMTP id s10-20020a056a20718a00b000d9a7928e3dmr349987pzb.30.1679592693514; Thu, 23 Mar 2023 10:31:33 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:9d:2:16d3:ef20:206a:6521]) by smtp.gmail.com with ESMTPSA id x13-20020a62fb0d000000b0061a6f4c1b2bsm12613546pfm.171.2023.03.23.10.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 10:31:32 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Mark Brown , Linus Walleij Cc: Matthias Kaehlcke , Konrad Dybcio , linux-gpio@vger.kernel.org, Stephen Boyd , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, Douglas Anderson , Andy Gross , linux-kernel@vger.kernel.org Subject: [PATCH 11/14] arm64: dts: qcom: sdm845: Remove superfluous "input-enable"s from cheza Date: Thu, 23 Mar 2023 10:30:15 -0700 Message-Id: <20230323102605.11.Ia439c29517b1c0625325a54387b047f099d16425@changeid> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230323173019.3706069-1-dianders@chromium.org> References: <20230323173019.3706069-1-dianders@chromium.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761180707753936005?= X-GMAIL-MSGID: =?utf-8?q?1761180707753936005?= As talked about in the patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not input-enable"), using "input-enable" in pinctrl states for Qualcomm TLMM pinctrl devices was either superfluous or there to disable a pin's output. Looking at cheza * ec_ap_int_l, h1_ap_int_odl: Superfluous. The pins will be configured as inputs automatically by the Linux GPIO subsystem (presumably the reference for other OSes using these device trees). * bios_flash_wp_l: Superfluous. This pin is exposed to userspace through the kernel's GPIO API and will be configured automatically. That means that in none of the cases for cheza did we need to change "input-enable" to "output-disable" and we can just remove these superfluous properties. Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi index f2b48241d15c..588165ee74b3 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi @@ -1155,14 +1155,12 @@ ap_edp_bklten: ap-edp-bklten-state { bios_flash_wp_r_l: bios-flash-wp-r-l-state { pins = "gpio128"; function = "gpio"; - input-enable; bias-disable; }; ec_ap_int_l: ec-ap-int-l-state { pins = "gpio122"; function = "gpio"; - input-enable; bias-pull-up; }; @@ -1190,7 +1188,6 @@ en_pp3300_dx_edp: en-pp3300-dx-edp-state { h1_ap_int_odl: h1-ap-int-odl-state { pins = "gpio129"; function = "gpio"; - input-enable; bias-pull-up; };