diff mbox series

[-next] PCI: imx6: Use devm_platform_get_and_ioremap_resource()

Message ID 20230323074553.90372-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] PCI: imx6: Use devm_platform_get_and_ioremap_resource() |

Commit Message

Yang Li March 23, 2023, 7:45 a.m. UTC 
  According to commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()"), convert
platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/pci/controller/dwc/pci-imx6.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Richard Zhu March 23, 2023, 8:24 a.m. UTC | #1 
> -----Original Message-----
> From: Yang Li <yang.lee@linux.alibaba.com>
> Sent: 2023年3月23日 15:46
> To: Hongxing Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; shawnguo@kernel.org; s.hauer@pengutronix.de;
> lpieralisi@kernel.org; kw@linux.com; robh@kernel.org; bhelgaas@google.com;
> linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; Yang Li <yang.lee@linux.alibaba.com>
> Subject: [PATCH -next] PCI: imx6: Use
> devm_platform_get_and_ioremap_resource()
> 
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert platform_get_resource(),
> devm_ioremap_resource() to a single call to
> devm_platform_get_and_ioremap_resource(), as this is exactly what this function
> does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thanks.
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>

Best Regards
Richard Zhu

> ---
>  drivers/pci/controller/dwc/pci-imx6.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> b/drivers/pci/controller/dwc/pci-imx6.c
> index 55a0405b921d..c61c85e09c4b 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1259,8 +1259,7 @@ static int imx6_pcie_probe(struct platform_device
> *pdev)
>  			return PTR_ERR(imx6_pcie->phy_base);
>  	}
> 
> -	dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	pci->dbi_base = devm_ioremap_resource(dev, dbi_base);
> +	pci->dbi_base = devm_platform_get_and_ioremap_resource(pdev, 0,
> +&dbi_base);
>  	if (IS_ERR(pci->dbi_base))
>  		return PTR_ERR(pci->dbi_base);
> 
> --
> 2.20.1.7.g153144c
diff mbox series

Patch

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 55a0405b921d..c61c85e09c4b 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1259,8 +1259,7 @@  static int imx6_pcie_probe(struct platform_device *pdev)
 			return PTR_ERR(imx6_pcie->phy_base);
 	}
 
-	dbi_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	pci->dbi_base = devm_ioremap_resource(dev, dbi_base);
+	pci->dbi_base = devm_platform_get_and_ioremap_resource(pdev, 0, &dbi_base);
 	if (IS_ERR(pci->dbi_base))
 		return PTR_ERR(pci->dbi_base);