From patchwork Wed Mar 22 14:39:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 73481 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2386022wrt; Wed, 22 Mar 2023 07:58:38 -0700 (PDT) X-Google-Smtp-Source: AKy350Zm8ce2/hojS8yJclVq3QfZgMSgV3hGPh5XNAuimvOzftcNHr7R33YsNgMyzJ20u2/2tXZy X-Received: by 2002:a17:902:d2d1:b0:1a1:cae6:cfd with SMTP id n17-20020a170902d2d100b001a1cae60cfdmr2339225plc.34.1679497117837; Wed, 22 Mar 2023 07:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497117; cv=none; d=google.com; s=arc-20160816; b=fpu8o9zGaaxY5Qby1lxeMpBYiDdzVQLv3ErEeixf2QvhVdU/Gvdoe9u7oFqdDT0PDc P/URMEHJcPiVdo9j/Mk7HweDD1flsLB91z/4VEcOK0xteIVz+EUW1IvcT974hyQjuknQ OMf35UwQ7yGJ5KHCcnEQ0J2brdLiJ6w88v8an7MEYEJyk6yw7cQOFfHEzdJvrZcjS+dy KLgjMW215acSLNQCSpHa7Zk6GsxBTA75oD0PRfN+n7LE/cdxkOT6DmLboAClzn9C5wqf 1qiYI3Bo/7hXOPzxSwO3wcUSVoCarz3xdDNSbibdtgbxIYFpAdOIkezR45k6+zQtmkju FTGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iobMeeEFx9YRZfTmDLaOpjvsGiCBygOu3aATqRCEW8A=; b=s/6BLuz8XzxUwQ53oW1BqaXO8elqnjEwHb+4RHM3V6rhB6dOWJL4HKXB6n0F5MeZiT XVx3cWneZsf16SUxRYTQVap9LZI6eacMa52UYInf4U676HEU3U0AxVWOmAl9bkFuhYV5 IiDUnnor6mrvPCmUgP0vpkE625V57viU7AaNHkUth6cVM2LkbYxY94Wyz03wsXQ56ib4 iBo42Oxw+L20FO7OrfCdkrOhHHba1Kh860pKg9fY5OkNtD8nWCOt8++e3oW7PPs3IP4c lss0vqGp9JDvzf5bkA1Edb+JoogTshbEotzZ3V+RryiLrRD8ZY3D0PFvtQyV9+7CB4iq eFfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=loTAv2A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jx5-20020a170903138500b001a1a6eb72aesi14763499plb.517.2023.03.22.07.58.24; Wed, 22 Mar 2023 07:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=loTAv2A+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjCVOj0 (ORCPT + 99 others); Wed, 22 Mar 2023 10:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231308AbjCVOjX (ORCPT ); Wed, 22 Mar 2023 10:39:23 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7797431E19 for ; Wed, 22 Mar 2023 07:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679495962; x=1711031962; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kBAOit4snqoHUt4I0yuPk3ujQh2EhLlWYoA5K0fcvog=; b=loTAv2A+xpYkS1pHZbun5wqpCJoYTfmnu9OPP82zwvIXUWubuSp+rMx5 vG//0t9l4MPKVwV1XeRBmAdGZ0VGVGF0HMJAll/R7UbW9Bz4FWa6roSF5 6d743EkyTgcRtZSNj9XIETuP3757cv7dgulYTUYIKqdfWy3ugx4c16CM1 xvwvevpWN0jEZrXRV89eY+NuP71+XDlFo2w64y6CvqWyFoiUh7CWJj3Bj jpHvdC4GzpCTu71JvHt12DDgCczuznTfc5lgFK+pG1w4yy+T/upqcXdKI 7hatze5cP5+ZEY7fgn8/7ma5qlJakfB6KIKNHMb4HuNlkAZXWMpVtKJkG g==; X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="319622115" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="319622115" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2023 07:39:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10657"; a="856116414" X-IronPort-AV: E=Sophos;i="5.98,282,1673942400"; d="scan'208";a="856116414" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2023 07:39:20 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B24C650B; Wed, 22 Mar 2023 16:40:06 +0200 (EET) From: Andy Shevchenko To: Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: [PATCH v1 04/14] extcon: use sysfs_emit() to instead of sprintf() Date: Wed, 22 Mar 2023 16:39:55 +0200 Message-Id: <20230322144005.40368-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080370148966381?= X-GMAIL-MSGID: =?utf-8?q?1761080370148966381?= Follow the advice of the Documentation/filesystems/sysfs.rst that show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 70e9755ba2bc..ac84f4aafc69 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -370,12 +370,12 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, struct extcon_dev *edev = dev_get_drvdata(dev); if (edev->max_supported == 0) - return sprintf(buf, "%u\n", edev->state); + return sysfs_emit(buf, "%u\n", edev->state); for (i = 0; i < edev->max_supported; i++) { - count += sprintf(buf + count, "%s=%d\n", - extcon_info[edev->supported_cable[i]].name, - !!(edev->state & BIT(i))); + count += sysfs_emit_at(buf, count, "%s=%d\n", + extcon_info[edev->supported_cable[i]].name, + !!(edev->state & BIT(i))); } return count; @@ -387,7 +387,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr, { struct extcon_dev *edev = dev_get_drvdata(dev); - return sprintf(buf, "%s\n", edev->name); + return sysfs_emit(buf, "%s\n", edev->name); } static DEVICE_ATTR_RO(name); @@ -398,8 +398,8 @@ static ssize_t cable_name_show(struct device *dev, attr_name); int i = cable->cable_index; - return sprintf(buf, "%s\n", - extcon_info[cable->edev->supported_cable[i]].name); + return sysfs_emit(buf, "%s\n", + extcon_info[cable->edev->supported_cable[i]].name); } static ssize_t cable_state_show(struct device *dev, @@ -410,8 +410,8 @@ static ssize_t cable_state_show(struct device *dev, int i = cable->cable_index; - return sprintf(buf, "%d\n", - extcon_get_state(cable->edev, cable->edev->supported_cable[i])); + return sysfs_emit(buf, "%d\n", + extcon_get_state(cable->edev, cable->edev->supported_cable[i])); } /**