diff mbox series

[v1,09/14] extcon: Use device_match_of_node() helper

Message ID	20230322144005.40368-10-andriy.shevchenko@linux.intel.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Bumwoo Lee <bw365.lee@samsung.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-kernel@vger.kernel.org Cc: MyungJoo Ham <myungjoo.ham@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com> Subject: [PATCH v1 09/14] extcon: Use device_match_of_node() helper Date: Wed, 22 Mar 2023 16:40:00 +0200 Message-Id: <20230322144005.40368-10-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> References: <20230322144005.40368-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	extcon: Core cleanups and documentation fixes \| [v1,00/14] extcon: Core cleanups and documentation fixes [v1,01/14] extcon: Fix kernel doc of property fields to avoid warnings [v1,02/14] extcon: Fix kernel doc of property capability fields to avoid warnings [v1,03/14] extcon: Use DECLARE_BITMAP() to declare bit arrays [v1,04/14] extcon: use sysfs_emit() to instead of sprintf() [v1,05/14] extcon: Amend kernel documentation of struct extcon_dev [v1,06/14] extcon: Allow name to be assigned outside of the framework [v1,07/14] extcon: Use unique number for the extcon device ID [v1,08/14] extcon: Switch to use kasprintf_strarray() [v1,09/14] extcon: Use device_match_of_node() helper [v1,10/14] extcon: use dev_of_node(dev) instead of dev->of_node [v1,11/14] extcon: Remove dup device name in the message and unneeded error check [v1,12/14] extcon: Use sizeof(*pointer) instead of sizeof(type) [v1,13/14] extcon: Drop unneeded assignments [v1,14/14] extcon: Use positive conditional in ternary operator

Commit Message

Andy Shevchenko March 22, 2023, 2:40 p.m. UTC

  Instead of open coding, use device_match_of_node() helper.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/extcon/extcon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chanwoo Choi April 3, 2023, 2:14 p.m. UTC | #1

On 23. 3. 22. 23:40, Andy Shevchenko wrote:
> Instead of open coding, use device_match_of_node() helper.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/extcon/extcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index a63e7eef02fd..5cadbfc151e6 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1411,7 +1411,7 @@ struct extcon_dev *extcon_find_edev_by_node(struct device_node *node)
>  
>  	mutex_lock(&extcon_dev_list_lock);
>  	list_for_each_entry(edev, &extcon_dev_list, entry)
> -		if (edev->dev.parent && edev->dev.parent->of_node == node)
> +		if (edev->dev.parent && device_match_of_node(edev->dev.parent, node))
>  			goto out;
>  	edev = ERR_PTR(-EPROBE_DEFER);
>  out:

Applied it.

diff mbox series

Patch

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index a63e7eef02fd..5cadbfc151e6 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1411,7 +1411,7 @@  struct extcon_dev *extcon_find_edev_by_node(struct device_node *node)
 
 	mutex_lock(&extcon_dev_list_lock);
 	list_for_each_entry(edev, &extcon_dev_list, entry)
-		if (edev->dev.parent && edev->dev.parent->of_node == node)
+		if (edev->dev.parent && device_match_of_node(edev->dev.parent, node))
 			goto out;
 	edev = ERR_PTR(-EPROBE_DEFER);
 out: