Message ID | 20230322143130.1432106-4-o.rempel@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2389504wrt; Wed, 22 Mar 2023 08:04:04 -0700 (PDT) X-Google-Smtp-Source: AK7set+lkssPnnZLnmM/WyinA3Yv9yQKXmqePIVZzaMA0Mq5qvv5f38nt9yUzYAesZ2ReFD8FDL0 X-Received: by 2002:a17:902:e394:b0:1a1:dd2a:fe6c with SMTP id g20-20020a170902e39400b001a1dd2afe6cmr2309426ple.53.1679497444522; Wed, 22 Mar 2023 08:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679497444; cv=none; d=google.com; s=arc-20160816; b=D7bCPkEl0MxdCyHanwJxKRVcKc3t/P5Qi74/ZmgKjTke9ILlN0o/hip1k4U5M6+Z69 gyOk4iic7/wJmCLXwt2ZU4jOd22wN84DXSIQ59qFz9hwRI71l0rmMD+2fRowytROQUIe N08OQffALbJZuOXZBAF/5uFv+FJVctS46rMlyuZ4xDLmY7wEb+YlZbR0jZ6cgXNCix4m xpp0K//fvjfJv+cuJbc7AzLSGWT0ifU7Cm+O8eC+CUqNGfSxozZJEozBNul76vqECpdH pdw0Igv1vHD07FA8ex2R6v1BIdBXm/fAmBfDImjAwGtLho+pWtrq2aJ7yxHWs+5U8o4R sugA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WPXfawoAPZIhrLeJjVGUO/6X1PFuKGP46KbvihpELhM=; b=Os1XnJRNYeqa+YbflNZzGRG5voca72LzheFxgZI5aIsl4+3J1v6jBkPURaxmixsskO aqxPlps8AZFswCqYjqeRIwUHBuCSTiucfHFxNqa0Z8e+RYRQa2Fi/kwlTbNv8+NXlEg7 YWwyuTH9YfHOX/EX1HQ5vYGMxcHfoP5rxF2W+3IkQwCEqgUdCEc7ynxMwJkWobSTCGGZ scbuOw9ZbYYEnm6mnKBt7IFm4eFwTNRiCXWp7Hm3ZOSAFsAp8f2RI7y/pOP8Euh54HVw m4KzH1ZVdhtWfCNN1VY16jKPTseUTZUh73kTb4hZHStVF5GKw2S5Z9zpumQ/Kv4OSWGj ObvQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bk13-20020a056a02028d00b00512fab8c401si1042732pgb.427.2023.03.22.08.03.51; Wed, 22 Mar 2023 08:04:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231579AbjCVOcG (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Wed, 22 Mar 2023 10:32:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231509AbjCVObr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 22 Mar 2023 10:31:47 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1203262B5B for <linux-kernel@vger.kernel.org>; Wed, 22 Mar 2023 07:31:47 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ore@pengutronix.de>) id 1pezV1-0003PF-As; Wed, 22 Mar 2023 15:31:35 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1pezUy-005wWO-VX; Wed, 22 Mar 2023 15:31:32 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1pezUx-0060Zu-3W; Wed, 22 Mar 2023 15:31:31 +0100 From: Oleksij Rempel <o.rempel@pengutronix.de> To: "David S. Miller" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>, Florian Fainelli <f.fainelli@gmail.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Vladimir Oltean <olteanv@gmail.com>, Woojung Huh <woojung.huh@microchip.com> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: [PATCH net v1 3/6] net: dsa: microchip: ksz8: fix offset for the timestamp filed Date: Wed, 22 Mar 2023 15:31:27 +0100 Message-Id: <20230322143130.1432106-4-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230322143130.1432106-1-o.rempel@pengutronix.de> References: <20230322143130.1432106-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761080712608437743?= X-GMAIL-MSGID: =?utf-8?q?1761080712608437743?= |
Series |
net: dsa: microchip: ksz8: fixes for stable
|
|
Commit Message
Oleksij Rempel
March 22, 2023, 2:31 p.m. UTC
We are using wrong offset, so we will get not a timestamp.
Fixes: d23a5e18606c ("net: dsa: microchip: move ksz8->masks to ksz_common")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/dsa/microchip/ksz_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Oleksij, On Wed, 2023-03-22 at 15:31 +0100, Oleksij Rempel wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you > know the content is safe > > We are using wrong offset, so we will get not a timestamp. > > Fixes: d23a5e18606c ("net: dsa: microchip: move ksz8->masks to > ksz_common") > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > drivers/net/dsa/microchip/ksz_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/microchip/ksz_common.c > b/drivers/net/dsa/microchip/ksz_common.c > index 3a1afc9f4621..c914449645ca 100644 > --- a/drivers/net/dsa/microchip/ksz_common.c > +++ b/drivers/net/dsa/microchip/ksz_common.c > @@ -423,7 +423,7 @@ static u8 ksz8863_shifts[] = { > [DYNAMIC_MAC_ENTRIES_H] = 8, > [DYNAMIC_MAC_ENTRIES] = 24, > [DYNAMIC_MAC_FID] = 16, > - [DYNAMIC_MAC_TIMESTAMP] = 24, > + [DYNAMIC_MAC_TIMESTAMP] = 22, Cross verified the bit mask with datasheet. Patch looks good to me. Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com> > [DYNAMIC_MAC_SRC_PORT] = 20, > }; > > -- > 2.30.2 >
diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 3a1afc9f4621..c914449645ca 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -423,7 +423,7 @@ static u8 ksz8863_shifts[] = { [DYNAMIC_MAC_ENTRIES_H] = 8, [DYNAMIC_MAC_ENTRIES] = 24, [DYNAMIC_MAC_FID] = 16, - [DYNAMIC_MAC_TIMESTAMP] = 24, + [DYNAMIC_MAC_TIMESTAMP] = 22, [DYNAMIC_MAC_SRC_PORT] = 20, };