From patchwork Wed Mar 22 13:50:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pankaj Raghav X-Patchwork-Id: 73431 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2353177wrt; Wed, 22 Mar 2023 06:54:26 -0700 (PDT) X-Google-Smtp-Source: AK7set/BMG55b84qm97uX2yfv6/i0aVaoJgNgdbnGSet0bVHhNc85r53wEcr/Gd+Cf4kI2e7g9Jo X-Received: by 2002:a17:902:f14d:b0:19e:25b4:7740 with SMTP id d13-20020a170902f14d00b0019e25b47740mr2152960plb.28.1679493266219; Wed, 22 Mar 2023 06:54:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679493266; cv=none; d=google.com; s=arc-20160816; b=o1HH7hlIRlDlRwfBB9Ubu4pqIP0wxdoH4oFtZEE0NTYCQVSKeG3jhqxQhVZ9Z2uHwd 0BR6owjNi8BubG0soYva2BFNY0wAyUxnU5xsfFl8qQys3VmM2/cfdWjm3uiP0T7aQ0iw GqAOsr+O8opdacNXxi3Hp4RaYJTc53Osh3TuF6ZPHCLYOBmk9HQ9X9XrbC7AkU7C/KXY VWuoFQutBfs8hk0XQLjf5WRthCpSZGOlP3VORwoeV+oypAVEAy6zvC2hJRCJdXwkmKFa 2UiybthkE4JMeowKTjHwwszkwELb4ol/YMO2/r3kASTj9jMJVAdiaNvif7V7IG6TwwCW TU9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:cms-type:content-transfer-encoding :mime-version:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=B7mV7FXyoTd1l8VtYDL/Y6/ww7FK/3anjYTB9ana5Ew=; b=vvfVcrgtJkra6fqxuiOtCviFBSxOND2nskKUcCpmULR1K07Ok74vyPWj8TI7dEbV/G vXKxpDViUVM+JnsxXHNh7+nu7uboI/d0FD+Za7bfqPOxuEIKh5E9bdpoOr7nOf8/GqJj cZJpEd/g5dcrOmJB4qSOWCSNe9231E5TWVxqUbx2jZ9lIWgML/71rYU6A3x9vuHrGUWK d3XnXRX9Y7nyuo7bkkPrfW17S9s4sGVpaXKT8damYhyFsd8UBAb/5i8ZJXdhxf+6oaTa aknzI+wD1PS43UgvYpQAWy83g9B4vg/GX1TBl34yn7cdGtOAv9kHPqb5cCwcDZXhcNPv LMqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=B3kZYXG7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020a170902d48300b0019e2bd0fea8si14106247plg.143.2023.03.22.06.54.14; Wed, 22 Mar 2023 06:54:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=B3kZYXG7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229732AbjCVNvB (ORCPT + 99 others); Wed, 22 Mar 2023 09:51:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230451AbjCVNuq (ORCPT ); Wed, 22 Mar 2023 09:50:46 -0400 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80ED7637DE for ; Wed, 22 Mar 2023 06:50:22 -0700 (PDT) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20230322135018euoutp018c905787c2e76844afacfebbe67c2508~OwgCPoYlg2152621526euoutp01J for ; Wed, 22 Mar 2023 13:50:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20230322135018euoutp018c905787c2e76844afacfebbe67c2508~OwgCPoYlg2152621526euoutp01J DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1679493018; bh=B7mV7FXyoTd1l8VtYDL/Y6/ww7FK/3anjYTB9ana5Ew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B3kZYXG7gxRoA/syaoUAWSE3836oL/3vMQg6n4Pog4cc/CWBbpD883LaemojNNVtc HmB4uByLwCiVHTVmDNnRliYXqdTAhhy9SSZqwHHar9pHcz+/9/8GsXkR9fZImR9tr2 tOXl7dYx20ooyXimmvn5pEuCWtK4gC8pPRWcawkc= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20230322135016eucas1p249e0287ce2648121944ff9859e7ca930~OwgAmbtE_0614806148eucas1p2s; Wed, 22 Mar 2023 13:50:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id CF.84.09503.8970B146; Wed, 22 Mar 2023 13:50:16 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20230322135016eucas1p2ee1b64175f621ee425f7f48cb908dc20~OwgAQ7_-H2731127311eucas1p2h; Wed, 22 Mar 2023 13:50:16 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230322135016eusmtrp2b58b16b46a6e5ebd71064b4e97c60834~OwgAQS0ON0726007260eusmtrp2H; Wed, 22 Mar 2023 13:50:16 +0000 (GMT) X-AuditID: cbfec7f2-e8fff7000000251f-e2-641b07981cc7 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 0D.52.08862.8970B146; Wed, 22 Mar 2023 13:50:16 +0000 (GMT) Received: from localhost (unknown [106.210.248.108]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230322135016eusmtip2fb1d581c86b27c823127c62671bcf838~OwgACUjVU2536025360eusmtip2t; Wed, 22 Mar 2023 13:50:16 +0000 (GMT) From: Pankaj Raghav To: senozhatsky@chromium.org, viro@zeniv.linux.org.uk, axboe@kernel.dk, willy@infradead.org, brauner@kernel.org, akpm@linux-foundation.org, minchan@kernel.org, hubcap@omnibond.com, martin@omnibond.com Cc: mcgrof@kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, gost.dev@samsung.com, Pankaj Raghav Subject: [RFC v2 2/5] orangefs: use folios in orangefs_readahead Date: Wed, 22 Mar 2023 14:50:10 +0100 Message-Id: <20230322135013.197076-3-p.raghav@samsung.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230322135013.197076-1-p.raghav@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA01SfUwTZxjfe3e9HnUlxynpgyXqGl0iIgy3jINNxzKml21uc9k/28iwsTc+ bIG01M8sqQVhMlddA44B4uKAIX40FEHrIAjM1aZFsoEWKehGyjJ1xNljG59l3K5m/ve8v+f3 9SQvhTMB2Uoqr6CYNxZo9RpSQXT8OHNjY7VcrXvOLrzI1jnOkezZsWMk+6AvhNjutkqMvX3V hbHlYzaM7RrZwHZ2eQh28Eodyd45tyhjPY5FnB0+PoHYpr8eylmhsVTOft96mmQHFtwydm66 jsyI4WotPxFcW3MCN9hv5pwtR0jOGbLLuevVcwRnqRohudnAqIyzXWxBnOBcxTmDk9i7yz5U vKzj9Xl7eGPylp2K3HmLV14UpvZN+KZxCzojr0BRFNAvgO2SF6tACoqhmxEErNeR9JhC0C4c JkQWQwsIbn+7/bHizC1BJuHfIShvXyMJ7iE4WnV1yYqiSDoBDh2Ri/gK2oeg0lqNRAFO30Xg 7frPdDmdAYsNdpnIJ+h1MHIqXoSVdDr0+JsIKWs1dPf04+IcRb8E46dPkBInBjxfBwnJcjWU tNfiYhbQZ6PAHj6PJHEmBM57IkbL4b77YuTkeFh0ncKk+SBMDM9FxKUIjrkcpFgIltJsPr04 4vR6cFxJluivwu/NLiQxomF4MkaqEA32jq9wCVbCZ2WMxNaAayYYCQUYtNZFynAQulxCHEfP 1DxxTM0Tx9T8n/sNwluQijebDDm8KaWA35tk0hpM5oKcpF2FBida+n/esDt0GZ28/yipF2EU 6kVA4ZoVyq046BilTrv/AG8szDaa9bypF6kpQqNSbtjs2cXQOdpifjfPF/HGx1uMilppwaoa aqvfvEHqR/kdo8NvpK8dchzsN2b5SpPTb1E2vKfSuz+/uOVa56Z7W7dc+CGjXqGv/3hqWcev mYfmJ7Ev6ROdif4d3UmzZZ8M5Lw/L5+qT3vv2VUXFi69o6oFf9M24Wb5DPNWSYojRP8z0Kha wxuZOHdrOFr4/M/+hdTJdeON3n0fZMVuU28e6BP+ZtxlwY7nY+yqweRZX/603/bwpiE2YU/e AVncUP6n17jo1Fd+znXEPira/XTsU368QdNz2PpRUyuuft276UHe9jEt9cdvbeq0obTwHLFz /dHCePPditTOhvE42dsGa/adoGdvdt/GRE27MTHrl9RiXVngi9fsmRrClKtNScCNJu2//oZi vu4DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t/xe7oz2KVTDL5vk7OYs34Nm8Xqu/1s Fq8Pf2K02L95CpPFzQM7mSza7/YxWey9pW2xZ+9JFovLu+awWdxb85/V4uT6/8wWNyY8ZbRY 9vU9u8XnpS3sFrs3LmKzOP/3OKvF7x9z2BwEPWY3XGTx2LxCy+Py2VKPTas62Tw2fZrE7nFi xm8Wj4apt9g8ft2+w+rRt2UVo8fnTXIem568ZQrgjtKzKcovLUlVyMgvLrFVija0MNIztLTQ MzKx1DM0No+1MjJV0rezSUnNySxLLdK3S9DL+NNwmr3gH0fF0zM/mBsYV7J3MXJySAiYSKy8 9pm1i5GLQ0hgKaNE29d7bBAJCYnbC5sYIWxhiT/Xutggip4zSuw/sxSom4ODTUBLorETbJCI wA1GifZVeiA1zCA1l5/OZgZJCAs4SPxfMokVpJ5FQFXi1nwZkDCvgJXEwevLWCDmy0vsP3gW rJxTwFri0aJpYDcIAdVc3g/SClIvKHFy5hOwemag+uats5knMArMQpKahSS1gJFpFaNIamlx bnpusaFecWJucWleul5yfu4mRmC0bjv2c/MOxnmvPuodYmTiYDzEKMHBrCTC68YskSLEm5JY WZValB9fVJqTWnyI0RTo7InMUqLJ+cB0kVcSb2hmYGpoYmZpYGppZqwkzutZ0JEoJJCeWJKa nZpakFoE08fEwSnVwKQYde9M9jO1DWsZWzs/Ws3uWfpi1/0DW0LWaG5ruswxtWSi3GTXw3lP jIwFmpd8Lm9Z3CSzf8Et5Yp3fpuWdsaUtL/g07z/fe/yMHnhWq2/4ofK1eu+bv6dwx9f3Xri s/zN5slG7ZeW3/vOyqPzoudbS4LrZY9efb4Yt8i/64ykZ/p32EXJd5c+tfl/Y8oB/y6ulqWn n9fnWUZ+Krios3bDxW8lVUvdHWr3ns6+GBf9ufaA7cMZZRrWW+b+qGV8/me+5S6lb2J9xhqR f46Eny0488F+ZuP6ILmyzHnrdKwKrc3drCPW8yzp2ZAuobnfTvKxa1rOY68zFsvWvF+1kuvv on8f5+98uGRvs6bYZ1YlluKMREMt5qLiRAAQHpt+XwMAAA== X-CMS-MailID: 20230322135016eucas1p2ee1b64175f621ee425f7f48cb908dc20 X-Msg-Generator: CA X-RootMTR: 20230322135016eucas1p2ee1b64175f621ee425f7f48cb908dc20 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20230322135016eucas1p2ee1b64175f621ee425f7f48cb908dc20 References: <20230322135013.197076-1-p.raghav@samsung.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761076331143120631?= X-GMAIL-MSGID: =?utf-8?q?1761076331143120631?= Convert orangefs_readahead() from using struct page to struct folio. This conversion removes the call to page_endio() which is soon to be removed, and simplifies the final page handling. Signed-off-by: Pankaj Raghav --- fs/orangefs/inode.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c index aefdf1d3be7c..9014bbcc8031 100644 --- a/fs/orangefs/inode.c +++ b/fs/orangefs/inode.c @@ -244,7 +244,7 @@ static void orangefs_readahead(struct readahead_control *rac) struct iov_iter iter; struct inode *inode = rac->mapping->host; struct xarray *i_pages; - struct page *page; + struct folio *folio; loff_t new_start = readahead_pos(rac); int ret; size_t new_len = 0; @@ -275,9 +275,10 @@ static void orangefs_readahead(struct readahead_control *rac) ret = 0; /* clean up. */ - while ((page = readahead_page(rac))) { - page_endio(page, false, ret); - put_page(page); + while ((folio = readahead_folio(rac))) { + if (!ret) + folio_mark_uptodate(folio); + folio_unlock(folio); } }