| Message ID | 20230322085106.16629-1-mirsad.todorovac@alu.unizg.hr |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp2236798wrt;
Wed, 22 Mar 2023 02:08:42 -0700 (PDT)
X-Google-Smtp-Source:
AK7set9tMZ4/XfbWoc9taSPAufF+uBf+sy/crEdRHVmbrDLOeVh2g3iKyMxkKYY3PXLPRQVWSCmT
X-Received: by 2002:a17:902:f98b:b0:1a0:50bd:31bf with SMTP id
ky11-20020a170902f98b00b001a050bd31bfmr1793830plb.32.1679476121751;
Wed, 22 Mar 2023 02:08:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679476121; cv=none;
d=google.com; s=arc-20160816;
b=um+ZtyVNimGdY6NHBBcK6uuKn53MMkfTDlV0V+1S2voQ5CLIJzekpaKNC1nJ0+zo7X
E65n84ByFu1H+hoH0c9UYVRTWmvUAgiBCYHxD8NiuAC5Kg6vA3fdlqM78BmcOEAAUH64
cHWsFP7s+OvVDJ0xWFPgBOG7TJZpzAc7GKPfF9HocqtLqx+8tS4iGomGaZ9AYw0N1Hdu
K2WLm+D8L2AfTMd0CyKdCHJuZaVrMnDE8TV4aHVHvEk7gNI35bJHKMVFf+QtApnjLh4O
t758D6qiSebiYQIWJ6lG1TqPhELkBUIH3NZ5vma3jc+ht0f7K0bI3HfRxyJeVkTlsK2R
JE8Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature:dkim-signature;
bh=XcpxkJrPRurK/XPjYvuLIGeFa5qnQVL0ZPt9/D8D6M8=;
b=m3LrrIlNBdVPPr5jW0izuKmkzuzLiLn32+r8VM8uxPYDlivKdICk/dWTeLrDKBM0mI
5qq8hHvQn8M2nnNEgkYTHuB7VisidAzxUvgEwkMDMTn+lPRJsgqV28B8QsIRGLjpDKYb
j2qPWH33hMkQv/vSOmhpnPrdqIut399MYIMJP/4nPJhMQVEVUWKllixyBeXNIgcIApTM
nYBQ+TGDWBAPqgAvsmfHb6nEWieHBwa+TBuzAw2HFJFkEcHgI6HwCqfCEytC+u2DxVUG
tBZc/f8qeHVvQz0/ntAbVJiBQLk7vx3etM8DVelGaAiohaUa8+5dk2fyrGpFxHz4ixVb
ISxQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b="wkMOGi/0";
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b=tKOS93bN;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alu.unizg.hr
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
k10-20020a63ff0a000000b0050be5c0b5e9si15384619pgi.514.2023.03.22.02.08.29;
Wed, 22 Mar 2023 02:08:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b="wkMOGi/0";
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b=tKOS93bN;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alu.unizg.hr
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230259AbjCVIyW (ORCPT <rfc822;ezelljr.billy@gmail.com>
+ 99 others); Wed, 22 Mar 2023 04:54:22 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35298 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229897AbjCVIyV (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 22 Mar 2023 04:54:21 -0400
Received: from domac.alu.hr (domac.alu.unizg.hr [161.53.235.3])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C2A61E1E0;
Wed, 22 Mar 2023 01:54:16 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
by domac.alu.hr (Postfix) with ESMTP id 5B831604EF;
Wed, 22 Mar 2023 09:54:14 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail;
t=1679475254; bh=VfhdcFBWULfAZ/qwiEOseRLcXnbwsFd18Pjz+M3TCc8=;
h=From:To:Cc:Subject:Date:From;
b=wkMOGi/00s79rq50fdK+Z6Qih1FbK2y0Vxe502O3thuSZtl1DbULKIgrBLKJPFUUv
noFnI6xTAEw6YjgiLAE22/E+6uiXBs6Q0+PF4B9wXdkJPViDVwgsILDGaa4E0x3MjJ
D7jggWx4LYrid8jUWnG+LZS5opEm2W2+91aYtUC1TNWPb3pPZCunLGh476wJ6VCBZm
VGhpv5WEuQPBipK9Bkfc/ORCycwJB05WFdRpukajhsCDIKMMducqrVThgdx6b6m/uF
xU2LyPCVaaiw+TAggoTHqeIZLejl58bwA+kqiPEAnt6dsY1xmIohv8v2qct0dkrxAG
Vq7PjHMIZ5U1Q==
X-Virus-Scanned: Debian amavisd-new at domac.alu.hr
Received: from domac.alu.hr ([127.0.0.1])
by localhost (domac.alu.hr [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id K7iL_P7vZHDk; Wed, 22 Mar 2023 09:54:12 +0100 (CET)
Received: by domac.alu.hr (Postfix, from userid 1014)
id 57243604F0; Wed, 22 Mar 2023 09:54:12 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail;
t=1679475252; bh=VfhdcFBWULfAZ/qwiEOseRLcXnbwsFd18Pjz+M3TCc8=;
h=From:To:Cc:Subject:Date:From;
b=tKOS93bNP5HI87T8Wl/lzJgcI2FKmdYw+dtcakVNUscnLkmtt6Lfe1Sy5itZNFoWE
xHnUoXY3fK2rvCYi8Yn5zrraEpuIvLpdMnKmbPhcVYmH8ormjoYsYb7OrqxEe0QrXG
JAi5WbVdeSqKTDB/e+GOUusyXqMynpo/y9VZaFA+kUqeIZKY68h1DUk5MXQl0CueGu
0PSoafhdzSiu792QjIrVi0AKGnyHEH71Xads3xCXDAdCYibDmxAUs+r+xUvjwStjHj
y0ZL3+YVFbtRN+Eld4OvYUxCNlC7HJDJ41yDS23dvb8minAqSQSX/rzP1wq0eHwLoB
+P5ERdSJZI/yg==
From: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
To: Mark Brown <broonie@kernel.org>, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: [PATCH v1 1/1] scripts: merge_config: Fix typo in variable name.
Date: Wed, 22 Mar 2023 09:51:07 +0100
Message-Id: <20230322085106.16629-1-mirsad.todorovac@alu.unizg.hr>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE,SPF_PASS,
URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1761058354172841048?=
X-GMAIL-MSGID: =?utf-8?q?1761058354172841048?=
|
| Series |
[v1,1/1] scripts: merge_config: Fix typo in variable name.
|
|
Commit Message
Mirsad Todorovac
March 22, 2023, 8:51 a.m. UTC
${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell
syntax error in certain paths of the script execution.
Cc: Mark Brown <broonie@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
---
scripts/kconfig/merge_config.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Mar 22, 2023 at 09:51:07AM +0100, Mirsad Goran Todorovac wrote: > ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell > syntax error in certain paths of the script execution. Reviewed-by: Mark Brown <broonie@kernel.org> Sorry about that.
On 3/22/2023 14:18, Mark Brown wrote: > On Wed, Mar 22, 2023 at 09:51:07AM +0100, Mirsad Goran Todorovac wrote: >> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell >> syntax error in certain paths of the script execution. > > Reviewed-by: Mark Brown <broonie@kernel.org> > > Sorry about that. You shouldn't be. Errare humanum est. I had worse blunders in the last couple of months, i.e. setting chattr +a on log files until /var/log filled up (old logs couldn't have been rotated). Best regards, Mirsad
On 3/22/23 01:51, Mirsad Goran Todorovac wrote: > ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell > syntax error in certain paths of the script execution. > Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides") Acked-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > Cc: Mark Brown <broonie@kernel.org> > Cc: Masahiro Yamada <masahiroy@kernel.org> > Cc: linux-kbuild@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> > --- > scripts/kconfig/merge_config.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh > index 32620de473ad..902eb429b9db 100755 > --- a/scripts/kconfig/merge_config.sh > +++ b/scripts/kconfig/merge_config.sh > @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do > NEW_VAL=$(grep -w $CFG $MERGE_FILE) > BUILTIN_FLAG=false > if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then > - ${WARNOVVERIDE} Previous value: $PREV_VAL > + ${WARNOVERRIDE} Previous value: $PREV_VAL > ${WARNOVERRIDE} New value: $NEW_VAL > ${WARNOVERRIDE} -y passed, will not demote y to m > ${WARNOVERRIDE}
On 22. 03. 2023. 16:20, Randy Dunlap wrote: > > > On 3/22/23 01:51, Mirsad Goran Todorovac wrote: >> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell >> syntax error in certain paths of the script execution. >> > > Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides") > > Acked-by: Randy Dunlap <rdunlap@infradead.org> > > Thanks. Hi, Randy, I think this time thanks go to the Heavens, for preserving my physical integrity. Though I don't know of a bike with ABS. >> Cc: Mark Brown <broonie@kernel.org> >> Cc: Masahiro Yamada <masahiroy@kernel.org> >> Cc: linux-kbuild@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> >> --- >> scripts/kconfig/merge_config.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh >> index 32620de473ad..902eb429b9db 100755 >> --- a/scripts/kconfig/merge_config.sh >> +++ b/scripts/kconfig/merge_config.sh >> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do >> NEW_VAL=$(grep -w $CFG $MERGE_FILE) >> BUILTIN_FLAG=false >> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then >> - ${WARNOVVERIDE} Previous value: $PREV_VAL >> + ${WARNOVERRIDE} Previous value: $PREV_VAL >> ${WARNOVERRIDE} New value: $NEW_VAL >> ${WARNOVERRIDE} -y passed, will not demote y to m >> ${WARNOVERRIDE} Best regards, Mirsad
On Thu, Mar 23, 2023 at 3:15 AM Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> wrote: > > On 22. 03. 2023. 16:20, Randy Dunlap wrote: > > > > > > On 3/22/23 01:51, Mirsad Goran Todorovac wrote: > >> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell > >> syntax error in certain paths of the script execution. > >> > > > > Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides") > > > > Acked-by: Randy Dunlap <rdunlap@infradead.org> > > > > Thanks. > > Hi, Randy, > > I think this time thanks go to the Heavens, for preserving my physical integrity. > > Though I don't know of a bike with ABS. Applied to linux-kbuild/fixes, fixing another typo "Signed-of-by". You do not need to spell it out by yourself. "git commit -s" will insert the Signed-off-by tag. > >> Cc: Mark Brown <broonie@kernel.org> > >> Cc: Masahiro Yamada <masahiroy@kernel.org> > >> Cc: linux-kbuild@vger.kernel.org > >> Cc: linux-kernel@vger.kernel.org > >> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> > >> --- > >> scripts/kconfig/merge_config.sh | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh > >> index 32620de473ad..902eb429b9db 100755 > >> --- a/scripts/kconfig/merge_config.sh > >> +++ b/scripts/kconfig/merge_config.sh > >> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do > >> NEW_VAL=$(grep -w $CFG $MERGE_FILE) > >> BUILTIN_FLAG=false > >> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then > >> - ${WARNOVVERIDE} Previous value: $PREV_VAL > >> + ${WARNOVERRIDE} Previous value: $PREV_VAL > >> ${WARNOVERRIDE} New value: $NEW_VAL > >> ${WARNOVERRIDE} -y passed, will not demote y to m > >> ${WARNOVERRIDE} > > Best regards, > Mirsad > > -- > Mirsad Goran Todorovac > Sistem inženjer > Grafički fakultet | Akademija likovnih umjetnosti > Sveučilište u Zagrebu > > System engineer > Faculty of Graphic Arts | Academy of Fine Arts > University of Zagreb, Republic of Croatia > The European Union >
On 23.3.2023. 7:24, Masahiro Yamada wrote: > On Thu, Mar 23, 2023 at 3:15 AM Mirsad Goran Todorovac > <mirsad.todorovac@alu.unizg.hr> wrote: >> >> On 22. 03. 2023. 16:20, Randy Dunlap wrote: >>> >>> On 3/22/23 01:51, Mirsad Goran Todorovac wrote: >>>> ${WARNOVERRIDE} was misspelled as ${WARNOVVERIDE}, which caused a shell >>>> syntax error in certain paths of the script execution. >>>> >>> >>> Fixes: 46dff8d7e381e ("scripts: merge_config: Add option to suppress warning on overrides") >>> >>> Acked-by: Randy Dunlap <rdunlap@infradead.org> >>> >>> Thanks. >> >> Hi, Randy, >> >> I think this time thanks go to the Heavens, for preserving my physical integrity. >> >> Though I don't know of a bike with ABS. > Applied to linux-kbuild/fixes, > fixing another typo "Signed-of-by". > > You do not need to spell it out by yourself. > > "git commit -s" will insert the Signed-off-by tag. Sorry to have wasted your time and effort. A typo fixing typo. It is visually hard to detect once it's done. :( I'm grateful for your quality control. Best regards, Mirsad >>>> Cc: Mark Brown <broonie@kernel.org> >>>> Cc: Masahiro Yamada <masahiroy@kernel.org> >>>> Cc: linux-kbuild@vger.kernel.org >>>> Cc: linux-kernel@vger.kernel.org >>>> Signed-of-by: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> >>>> --- >>>> scripts/kconfig/merge_config.sh | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh >>>> index 32620de473ad..902eb429b9db 100755 >>>> --- a/scripts/kconfig/merge_config.sh >>>> +++ b/scripts/kconfig/merge_config.sh >>>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do >>>> NEW_VAL=$(grep -w $CFG $MERGE_FILE) >>>> BUILTIN_FLAG=false >>>> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then >>>> - ${WARNOVVERIDE} Previous value: $PREV_VAL >>>> + ${WARNOVERRIDE} Previous value: $PREV_VAL >>>> ${WARNOVERRIDE} New value: $NEW_VAL >>>> ${WARNOVERRIDE} -y passed, will not demote y to m >>>> ${WARNOVERRIDE}
diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh index 32620de473ad..902eb429b9db 100755 --- a/scripts/kconfig/merge_config.sh +++ b/scripts/kconfig/merge_config.sh @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do NEW_VAL=$(grep -w $CFG $MERGE_FILE) BUILTIN_FLAG=false if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then - ${WARNOVVERIDE} Previous value: $PREV_VAL + ${WARNOVERRIDE} Previous value: $PREV_VAL ${WARNOVERRIDE} New value: $NEW_VAL ${WARNOVERRIDE} -y passed, will not demote y to m ${WARNOVERRIDE}