spi: f_ospi: Add missing spi_mem_default_supports_op() helper

Message ID 20230322023101.24490-1-hayashi.kunihiko@socionext.com
State New
Headers
Series spi: f_ospi: Add missing spi_mem_default_supports_op() helper |

Commit Message

Kunihiko Hayashi March 22, 2023, 2:31 a.m. UTC
  The .supports_op() callback function returns true by default after
performing driver-specific checks. Therefore the driver cannot apply
the buswidth in devicetree.

Call spi_mem_default_supports_op() helper to handle the buswidth
in devicetree.

Fixes: 1b74dd64c861 ("spi: Add Socionext F_OSPI SPI flash controller driver")
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/spi/spi-sn-f-ospi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Mark Brown March 22, 2023, 6:47 p.m. UTC | #1
On Wed, 22 Mar 2023 11:31:01 +0900, Kunihiko Hayashi wrote:
> The .supports_op() callback function returns true by default after
> performing driver-specific checks. Therefore the driver cannot apply
> the buswidth in devicetree.
> 
> Call spi_mem_default_supports_op() helper to handle the buswidth
> in devicetree.
> 
> [...]

Applied to

   broonie/spi.git for-next

Thanks!

[1/1] spi: f_ospi: Add missing spi_mem_default_supports_op() helper
      commit: bc43c5ec1a97772269785d19f62d32c91ac5fc36

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
  

Patch

diff --git a/drivers/spi/spi-sn-f-ospi.c b/drivers/spi/spi-sn-f-ospi.c
index 348c6e1edd38..87302d51be42 100644
--- a/drivers/spi/spi-sn-f-ospi.c
+++ b/drivers/spi/spi-sn-f-ospi.c
@@ -561,7 +561,7 @@  static bool f_ospi_supports_op(struct spi_mem *mem,
 	if (!f_ospi_supports_op_width(mem, op))
 		return false;
 
-	return true;
+	return spi_mem_default_supports_op(mem, op);
 }
 
 static int f_ospi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)