diff mbox series

USB: serial: quatech2: remove unused qt2_setdevice function

Message ID 20230321181255.1825963-1-trix@redhat.com
State New
Headers
Series USB: serial: quatech2: remove unused qt2_setdevice function |

Commit Message

Tom Rix March 21, 2023, 6:12 p.m. UTC 
  clang with W=1 reports
drivers/usb/serial/quatech2.c:179:19: error: unused function
  'qt2_setdevice' [-Werror,-Wunused-function]
static inline int qt2_setdevice(struct usb_device *dev, u8 *data)
                  ^
This function is not used, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/usb/serial/quatech2.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Johan Hovold April 5, 2023, 11:39 a.m. UTC | #1 
On Tue, Mar 21, 2023 at 02:12:55PM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/serial/quatech2.c:179:19: error: unused function
>   'qt2_setdevice' [-Werror,-Wunused-function]
> static inline int qt2_setdevice(struct usb_device *dev, u8 *data)
>                   ^
> This function is not used, so remove it.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Now applied, thanks.

Johan
diff mbox series

Patch

diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 6fca40ace83a..fee581409bf6 100644
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -176,14 +176,6 @@  static inline int qt2_control_msg(struct usb_device *dev,
 			       NULL, 0, QT2_USB_TIMEOUT);
 }
 
-static inline int qt2_setdevice(struct usb_device *dev, u8 *data)
-{
-	u16 x = ((u16) (data[1] << 8) | (u16) (data[0]));
-
-	return qt2_control_msg(dev, QT_SET_GET_DEVICE, x, 0);
-}
-
-
 static inline int qt2_getregister(struct usb_device *dev,
 				  u8 uart,
 				  u8 reg,