From patchwork Tue Mar 21 13:53:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 72884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1799029wrt; Tue, 21 Mar 2023 07:09:19 -0700 (PDT) X-Google-Smtp-Source: AK7set+YJN1/O026f7xEvedsrI2nTlvn5Igdo2Q/KqpljXOm3+sCHqxRjvYSF1AR0oc/lOlf7oLr X-Received: by 2002:a05:6a20:4999:b0:d6:847d:c7af with SMTP id fs25-20020a056a20499900b000d6847dc7afmr3132097pzb.16.1679407759659; Tue, 21 Mar 2023 07:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679407759; cv=none; d=google.com; s=arc-20160816; b=YJi50YXSnONP/9BSofVcvggCfNPFfipZLTun/ROWiVcqe3Wxc1mnvTps815Eof32g1 tOPH5gajShNMIbp1B2Ubedwn2cDtJhd+IE5K66VYJwpOk3XzA6ddS4RFJe6VfvbdPNk7 84g2nACft2NexUtnm9pviedw24l8amnjRcyXvk+joTo5JHqkxCFTJ2BpVMpjz7Y7JwuU RQe/0iFWeMlEux5FggvBH/DIMIhisCijeYjG/k9RdjFYf8fQcIOVoMgIUQGYunirxMXt 9zrkOTkgTEEzTM3DTXl73aU1KziZUsXISxA9n0jcZq9o19SARshL2HQEeVA1RiFIZLis Qo9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Li5qhMz8Mil49ZfeRuBtfijPOufFL6DmWOX/9WiGGjU=; b=tC14xAn000IOhQM4GmQz3hrRMUx59mX0eYM6xvMpxZ34mfQ1FsBiyfGkofW5O618Bs 3RozqrOR+hDKJP1UeYvRvmccpyl36zmzSRvYgZG6ixCu7ASKNiMCSOlBMC/GQ3SmTDcN +D68qBRy3CwMvwsi5zKOibymdRrN6NvipnChlcfnUEjJX9mbACewYEBMeWWO2erXkDxM MsrYM8B3QTXvax8rw+7DDhEixwPeQa7bJH/a3mbwjtRa6nD1T8mDKVTvI8IFroWCJvh5 BBhF1uPcCSJJtPquVbqecLNDCTJvwWeivx598tAldi8N1wp0xAnB6AVTe5ytJjHMLuqp 5m8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bdqGiFBR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v28-20020a63151c000000b0050be68e217esi14092251pgl.477.2023.03.21.07.09.04; Tue, 21 Mar 2023 07:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bdqGiFBR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231236AbjCUNwm (ORCPT + 99 others); Tue, 21 Mar 2023 09:52:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjCUNwk (ORCPT ); Tue, 21 Mar 2023 09:52:40 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB19937577; Tue, 21 Mar 2023 06:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679406758; x=1710942758; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ElaDzwECHs1yLLGCRJtXRT6LWmPM8YLMLk+UX7vVh/4=; b=bdqGiFBROYfXWK2+gIobHlkVq0P89SwNLz/Jp7zlE3/kDwrle6rNeeb9 VtiX+7vv7mo6nPQ36oTOtjfqmI8AZV+FCJCy3/xFbN42j89Ye7CuIZ/5Y kjFMyeSAu5tuWswFNQ9aOF5riU7HvOyYmvMROZ50zu5EPWklNb4YemGIC QiH+/UjU0jHavJ3FNntmC2LnIcnK+Ck7lzq7a/I/cZY/u3TukeXZDgerG XinEoQ+pZ8FULvUkG3mpffUbw00krFuGoa2ev/TVoMxskhIbOwsS8N7Aw t2IcmTCI5RHbHuagf/qCdRzIiYr/J2uhHAzIXWIaXgnwyinnD8sygbn8t g==; X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="322782074" X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; d="scan'208";a="322782074" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2023 06:52:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10656"; a="745855523" X-IronPort-AV: E=Sophos;i="5.98,279,1673942400"; d="scan'208";a="745855523" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 21 Mar 2023 06:52:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 91FB93DD; Tue, 21 Mar 2023 15:53:22 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 1/1] gpiolib: Split property name from the warning message Date: Tue, 21 Mar 2023 15:53:10 +0200 Message-Id: <20230321135310.73153-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760986670748025829?= X-GMAIL-MSGID: =?utf-8?q?1760986670748025829?= Split property name from the warning message to make object file shorter. The linker will use the single copy of it. It's fine to pass a pointer to the printing function since it's a slow path anyway. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 51a19cbe39a4..112d99a5eec4 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -403,8 +403,8 @@ static int gpiochip_set_names(struct gpio_chip *chip) * gpiochips. */ if (count <= chip->offset) { - dev_warn(dev, "gpio-line-names too short (length %d), cannot map names for the gpiochip at offset %u\n", - count, chip->offset); + dev_warn(dev, "%s too short (length %d), cannot map names for the gpiochip at offset %u\n", + "gpio-line-names", count, chip->offset); return 0; }