From patchwork Tue Mar 21 06:14:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerry Snitselaar X-Patchwork-Id: 72705 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1614847wrt; Mon, 20 Mar 2023 23:27:43 -0700 (PDT) X-Google-Smtp-Source: AK7set81nAX6VuLMtVV+Wl9Vw9lWLK35L4WqV4EDVOfJrZNM1Udw1Mh5ILRY1GV6WOe/OCLm27lj X-Received: by 2002:a05:6a20:c420:b0:da:3830:9a1d with SMTP id en32-20020a056a20c42000b000da38309a1dmr2481636pzb.0.1679380062738; Mon, 20 Mar 2023 23:27:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679380062; cv=none; d=google.com; s=arc-20160816; b=WZ3kovoc+FyMQhuIOmwp7rwMvOUEMKUgu1fBeOZ63MazgNxKyWCTcj8NFcC5GaC14x SMyJUhgI0kxVM3Ymfe2px5qXW6FF/Asene1KZjVIx6q5vHKPKm9VgIbu0Kes89mZTr2g qvIB8Mpd00/YGkcqUzCHfxUfSj83aENF0ECUv1ZWoNy9GOfp83G6aZE/Zz0IKKogtcoC gOyEz3eO13sZC/17Jqi0cwBWMcNVKUi+a0qWrO/ixtRZIE4clcWrLqe18yMbELZK4g3F EjuRbY9amplYeaHfJ07PPrJRiOZH2zh/D2leKoaK/kLdfGEJmtfOA2xbpz49gqRiF5j6 Ct8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=M8OnIdfA0wmBLFZVipgL/bCDozNrLAZZSjIdqzAfvHs=; b=IZIZGP+aBfdm/X8rPR4q+D4YF4LbHZpVHAQ4yvLZFlqWi3nQQwLFOgsz2xARCSEj3l CDtvc3rZQNcwBOIerhkbDSyLrXlCFEhpOgsDRO4WnaU8CXzb9xPeAJ3tyDDTzw4IN0dG v+l+zeSft7C03gNfHjAO/soJ+hRn0Jm+f3myJ1Os3EArylbhK6Apk9Cd80bcGuzt9k5H UzWFv7mvZ0QMRAt4vCHGlDXU/kpIZS+TCsr8LuXiZesIQ3br8Ax2ZbhUlZ6nstiIB8Bd T1nOrc7g/HjGdLTtTdjd7r6pfkp5Qx3WyeJmJS/U8tPWae4E82bFkU21+7Matkwtovlt tWHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BAvI8LeO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020a056a00174600b005e1cabb612fsi13230801pfc.67.2023.03.20.23.27.29; Mon, 20 Mar 2023 23:27:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BAvI8LeO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbjCUGPS (ORCPT + 99 others); Tue, 21 Mar 2023 02:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230119AbjCUGPQ (ORCPT ); Tue, 21 Mar 2023 02:15:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D905B185 for ; Mon, 20 Mar 2023 23:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679379270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=M8OnIdfA0wmBLFZVipgL/bCDozNrLAZZSjIdqzAfvHs=; b=BAvI8LeO+gPJdtAUuaXzVvvm46cxuQZHsJwicQNYUQUXziuUzJpfcXiWuqCWsmepvHeu1e tXjZ1ndjnu35uUWxW91PL83eTqzXHhtYOuQRA50i61aOA3LU0Y69lOdqNE9i6yyliMK7DU lkrMEp31d1iYNojesVQJiY1aRhd4rTE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-BCV4DupjPoS9AAPeY9fa1g-1; Tue, 21 Mar 2023 02:14:22 -0400 X-MC-Unique: BCV4DupjPoS9AAPeY9fa1g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 278B129AA2F0; Tue, 21 Mar 2023 06:14:22 +0000 (UTC) Received: from cantor.redhat.com (unknown [10.2.16.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53799C15BA0; Tue, 21 Mar 2023 06:14:21 +0000 (UTC) From: Jerry Snitselaar To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Cc: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, "Martin K. Petersen" Subject: [PATCH] scsi: mpt3sas: Don't print sense pool info twice Date: Mon, 20 Mar 2023 23:14:19 -0700 Message-Id: <20230321061419.3139051-1-jsnitsel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760957629010114900?= X-GMAIL-MSGID: =?utf-8?q?1760957629010114900?= _base_allocate_sense_dma_pool() already prints out the sense pool information, so don't print it a second time after calling it in _base_allocate_memory_pools(). In addition the version in _base_allocate_memory_pools() was using the wrong size value, sz, which was last assigned when doing some nvme calculations instead of sense_sz to determine the pool size in kilobytes. Cc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: MPT-FusionLinux.pdl@broadcom.com Cc: "Martin K. Petersen" Signed-off-by: Jerry Snitselaar --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 2ee9ea57554d..14ae0a9c5d3d 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -6616,11 +6616,6 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc) else if (rc == -EAGAIN) goto try_32bit_dma; total_sz += sense_sz; - ioc_info(ioc, - "sense pool(0x%p)- dma(0x%llx): depth(%d)," - "element_size(%d), pool_size(%d kB)\n", - ioc->sense, (unsigned long long)ioc->sense_dma, ioc->scsiio_depth, - SCSI_SENSE_BUFFERSIZE, sz / 1024); /* reply pool, 4 byte align */ sz = ioc->reply_free_queue_depth * ioc->reply_sz; rc = _base_allocate_reply_pool(ioc, sz);