diff mbox series

net: atheros: atl1c: remove unused atl1c_irq_reset function

Message ID 20230320232317.1729464-1-trix@redhat.com
State New
Headers
Series net: atheros: atl1c: remove unused atl1c_irq_reset function |

Commit Message

Tom Rix March 20, 2023, 11:23 p.m. UTC 
  clang with W=1 reports
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
  unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
                   ^
This function is not used, so remove it.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Pavan Chebbi March 21, 2023, 4:50 a.m. UTC | #1 
On Tue, Mar 21, 2023 at 4:54 AM Tom Rix <trix@redhat.com> wrote:
>
> clang with W=1 reports
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
>   unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
> static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
>                    ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 ----------
>  1 file changed, 10 deletions(-)

Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>

>
> diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> index 40c781695d58..4a288799633f 100644
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -207,16 +207,6 @@ static inline void atl1c_irq_disable(struct atl1c_adapter *adapter)
>         synchronize_irq(adapter->pdev->irq);
>  }
>
> -/**
> - * atl1c_irq_reset - reset interrupt confiure on the NIC
> - * @adapter: board private structure
> - */
> -static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
> -{
> -       atomic_set(&adapter->irq_sem, 1);
> -       atl1c_irq_enable(adapter);
> -}
> -
>  /*
>   * atl1c_wait_until_idle - wait up to AT_HW_MAX_IDLE_DELAY reads
>   * of the idle status register until the device is actually idle
> --
> 2.27.0
>
patchwork-bot+netdevbpf@kernel.org March 22, 2023, 5:40 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 20 Mar 2023 19:23:17 -0400 you wrote:
> clang with W=1 reports
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:214:20: error:
>   unused function 'atl1c_irq_reset' [-Werror,-Wunused-function]
> static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
>                    ^
> This function is not used, so remove it.
> 
> [...]

Here is the summary with links:
  - net: atheros: atl1c: remove unused atl1c_irq_reset function
    https://git.kernel.org/netdev/net-next/c/f6f4e739b164

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 40c781695d58..4a288799633f 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -207,16 +207,6 @@  static inline void atl1c_irq_disable(struct atl1c_adapter *adapter)
 	synchronize_irq(adapter->pdev->irq);
 }
 
-/**
- * atl1c_irq_reset - reset interrupt confiure on the NIC
- * @adapter: board private structure
- */
-static inline void atl1c_irq_reset(struct atl1c_adapter *adapter)
-{
-	atomic_set(&adapter->irq_sem, 1);
-	atl1c_irq_enable(adapter);
-}
-
 /*
  * atl1c_wait_until_idle - wait up to AT_HW_MAX_IDLE_DELAY reads
  * of the idle status register until the device is actually idle