| Message ID | 20230320135710.1989-3-johan+linaro@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1240782wrt;
Mon, 20 Mar 2023 07:14:26 -0700 (PDT)
X-Google-Smtp-Source:
AK7set8Uv0obG4phcsiC7QRsChAxNLbqsrlB7cK/jwNT6RT/wAUfNzU2OPgi3N7rLkRAe8AKchcQ
X-Received: by 2002:a05:6a21:328b:b0:d9:ad20:c97d with SMTP id
yt11-20020a056a21328b00b000d9ad20c97dmr3587726pzb.20.1679321666545;
Mon, 20 Mar 2023 07:14:26 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679321666; cv=none;
d=google.com; s=arc-20160816;
b=oE4MR6hS0Aa2tehyqQOFjDPXdaIid7bfbbVbA3I2BQnLaoN31rO1FzYPm1zFvdS4Eu
YsVxzthV35ti42AQZz1HtNRhk7uAYZd2IoPovhrzhu6TW5bVVRYK+VeX5deopLfXU2jT
vO9NO2wk5OlTc+Tzswk8fJNj7GQkBnCeRs2NDXvqKmX3OCuTS6usU0PhRVJkrBTl5UW2
FeXupYj1Gvq4b6DQzaF1nyi0UwcA7vh+nYBRtlXjhUTkKQlrPCw/nFoSP0ynkjEszc/k
pwIyP/iMyOXKDw7TsTYnPeamNs0WXuNs8CvE3aRxlfqbh5ZgszkldWxZ/4Anrrjtb62l
UR4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=uqJIsCLdcxsDvu9/76I4LWpadiXNjC12sw0ppkuugG4=;
b=r7Q3AsqzknQ+ttsY/sD1ucKtuXF0F+OvBSy8C1C5gUlwH2wqX3ncSHIecUbkjUqrMv
N9eLunGpHn5r6cRuBBmfJXMZXQBA/oGHNUA0gRE/wVRwW+e1grcjMN0dTgv9nwuRaHDg
CAMIOPnGzUif0xbwB1zFhJTWwCim3JyxFlRi31YwEUzRHqNfBcHUpyxHxpPPpOdMCz9L
SPCwZczYbYXEAk7/6tdMnPBq8W0OdBPLrBCmcqFAu2zTgQTqoiroIF2PD05qWG12bMh8
qIN+fXm2l/GrVK4O4azGAzexJdoS6xgIkpoLwV9rFBsr5RMwox1M+o11RsIssc6sbGSE
Xjmg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kp1rXR92;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
j70-20020a638b49000000b004fbc70b72cesi10816822pge.771.2023.03.20.07.14.03;
Mon, 20 Mar 2023 07:14:26 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kp1rXR92;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231537AbjCTN4q (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others);
Mon, 20 Mar 2023 09:56:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44028 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231680AbjCTN4Z (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 20 Mar 2023 09:56:25 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73CA613501;
Mon, 20 Mar 2023 06:55:57 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by dfw.source.kernel.org (Postfix) with ESMTPS id 1824E6151C;
Mon, 20 Mar 2023 13:55:57 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD45C433EF;
Mon, 20 Mar 2023 13:55:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
s=k20201202; t=1679320556;
bh=wc3FoLvFgLDkOgN7gxHKEwm4JJ7/VP0SV4GEWDLU+TU=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=Kp1rXR92DwaNGamGVlJ5BA0l4VTVEUJo5h8XtXWuNyt1UjKof2mnkfEFScjfMRHl5
nd9UbqNHsGuJGIBalp3Yr6AGzsdKUnF8VGRjSYA4JDOVdQMuI6sx/6cme6EEbHQf7t
qWEK51be3jcK5BMorqyaYtG856SOhkXNz4AZnWHvr8S0dwnQfu6TOp1RL1DM0neXOF
RFSDlrjVAzSzYPbXiTykloQkH3auezR6iGrDQ0WRpGe+L+GQMfJ0+NBmsWwWWZAu9l
BQHvqnmq5zfW+22mrsG3vHx1Q3ukNqoiRoWeh4Lcqd5GeKf99wT0muiIzvREbcCRMM
GdBZyRmlbUfyQ==
Received: from johan by xi.lan with local (Exim 4.94.2)
(envelope-from <johan+linaro@kernel.org>)
id 1peG0j-0000WT-R5; Mon, 20 Mar 2023 14:57:17 +0100
From: Johan Hovold <johan+linaro@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>, Lee Jones <lee@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 2/3] arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property
Date: Mon, 20 Mar 2023 14:57:09 +0100
Message-Id: <20230320135710.1989-3-johan+linaro@kernel.org>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230320135710.1989-1-johan+linaro@kernel.org>
References: <20230320135710.1989-1-johan+linaro@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760896175719932750?=
X-GMAIL-MSGID: =?utf-8?q?1760896395375007308?=
|
| Series |
arm64: dts: qcom: sc8280xp-pmics: fix sdam 'reg' property
|
|
Commit Message
Johan Hovold
March 20, 2023, 1:57 p.m. UTC
The SPMI PMIC register region width is fixed and should not be encoded
in the devicetree.
Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 20/03/2023 14:57, Johan Hovold wrote: > The SPMI PMIC register region width is fixed and should not be encoded > in the devicetree. It also violates size-cells=0. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Mar 20, 2023 at 02:57:09PM +0100, Johan Hovold wrote: > The SPMI PMIC register region width is fixed and should not be encoded > in the devicetree. > > Fixes: 42f45cc655d0 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") Bah, that should have been: Fixes: d6dbbda37ab5 ("arm64: dts: qcom: sc8280xp-pmics: add pmk8280 sdam nvram") Can you fix that up when applying, Bjorn? Johan
On Mon, Mar 20, 2023 at 03:11:39PM +0100, Krzysztof Kozlowski wrote: > On 20/03/2023 14:57, Johan Hovold wrote: > > The SPMI PMIC register region width is fixed and should not be encoded > > in the devicetree. > > It also violates size-cells=0. That's the same thing. Johan
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi index 1411edd42b25..c35e7f6bd657 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi @@ -107,7 +107,7 @@ pmk8280_rtc: rtc@6100 { pmk8280_sdam_6: nvram@8500 { compatible = "qcom,spmi-sdam"; - reg = <0x8500 0x100>; + reg = <0x8500>; #address-cells = <1>; #size-cells = <1>; ranges = <0 0x8500 0x100>;