From patchwork Mon Mar 20 00:32:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Pearson X-Patchwork-Id: 71923 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp944394wrt; Sun, 19 Mar 2023 17:54:15 -0700 (PDT) X-Google-Smtp-Source: AK7set+hgaTfVcJ7IHM11CW8FSrCmw9ntIic1HqEqCZe0cMB+v1ZcDaN5Nkspu3LhZS19ZmlV0Ww X-Received: by 2002:a05:6a20:3d85:b0:d7:2624:596e with SMTP id s5-20020a056a203d8500b000d72624596emr17198195pzi.3.1679273655243; Sun, 19 Mar 2023 17:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679273655; cv=none; d=google.com; s=arc-20160816; b=Us5hmH0ak/1x0AcxpMDJcmboqSuXpv39IUwgjeT7yT7YdtM3nxuaAFG5i5IYOItLm1 bm9HyLXLYdN0L8jbO06HfFl6xLLS1wryjBWerZD2hhI8OgUMvU/kTwshzzwqRhDEu1FY fKdZHAlOO0SXtdD0VgXAK0BAGMqu/3SCrWdTjzvAX8xuB1dg3uJVuaeOY/sT9EXUX1ul o39wHv+lKKX5kNVpo71OIgAluCSW6yI+uVLuHiZyKymcuIwtmAO8+PYQEq+JjhdPT9mK 1Zf1Hh3UMtSMMTaJu/YQ5Pl66vrtLvppfRlx0LUw+9L5ZCGJMAcehoPjw8LHg5J4AES2 hD2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=/6Xha14LNcuPBWYFX7xY2TJKKvWGWGj521bnvzcA2FQ=; b=fVD8JJ50n6MFbVge4KdiaMld5nCYZ+xOR2EfIatTuZeSwuHRE202fFTNhqQ0ffoxAE jy/lc2DVVcvgNRz9rb2Scqmq3sxBsHTDCVg18FQqq6vOi1ZfUxVsyZ7sKOhWRauEiVlw +BoiGlIHMyo1jj1gZK2MpVhxua9D7fHT5iD0vvTvcCOUEnX2mo5IiZgFKLWJDGUUn4Qb OdhdCExZNMzX5etygfKCMlPkGZNCuGjdIdBU7VAH3X/5cGs/gbZx2XeMplFcidLtKun1 RdUmxvgROnToGEFZe9nWwoO9QOKilLQYLdCBcQeCM1ueK/hOFgKsZDyfyGxRYVR/CKld hxkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@squebb.ca header.s=fm3 header.b=Udwlt9zE; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=WPp3wqyH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 191-20020a6304c8000000b004fb171df693si9388999pge.352.2023.03.19.17.54.02; Sun, 19 Mar 2023 17:54:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@squebb.ca header.s=fm3 header.b=Udwlt9zE; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=WPp3wqyH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbjCTAcm (ORCPT + 99 others); Sun, 19 Mar 2023 20:32:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjCTAci (ORCPT ); Sun, 19 Mar 2023 20:32:38 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8595F168B4 for ; Sun, 19 Mar 2023 17:32:36 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 776355C0084; Sun, 19 Mar 2023 20:32:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 19 Mar 2023 20:32:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1679272352; x= 1679358752; bh=/6Xha14LNcuPBWYFX7xY2TJKKvWGWGj521bnvzcA2FQ=; b=U dwlt9zEC4kxHPCywNbYy40UNnQmjcC9Nea46MeygdUOpGiJLSQ0b1oxBPO17LF+b +yaDSIKipKXb1ny4vVrlAFzPr1emVHVYwugHJJUlmv33TtR6Jz2EE60sjfzADKdH NbVcIev0+4yMpoKaitrtSwN44+HBJhBxyDyIVyyXEiXwzn3ecSS7fWQuvH7iofaA 5hwcGfPQFclO4Lr3eNXJCrLcZU3J4geGeLXei8RaFwkAbvxN6aYhfFsHJHyYy3Ny u7zwBVB0dKhf5/fymeq0RutyTmCFUwud65dQ+h73znM5jovMIQNQCFNH/oI/LeUA qKK3FRaBMnAA8CPJxLDWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679272352; x= 1679358752; bh=/6Xha14LNcuPBWYFX7xY2TJKKvWGWGj521bnvzcA2FQ=; b=W Pp3wqyHRhakjP+kFEaZXLuxdFiNIuYpLfe7hTHjBqRh+QSMlmM4kmv0PY577wHgr l1Ul/Y8Zkx1m0Y9bMSVkHC5a1PmYHzXNFc9hpgwiriZN+z6vlQJoaD4lh4M7DK33 mtcbWYqJW+U+Wjhn6iAUP/FqghQKvBnClwD/G6NBOMiZ7tnA5WfaHE10mCV3bzE/ LOcZDlZ/BfTsLPVaqSLO/ZrPNxOBlYD/Ul7GM7js85Z1Z9pSBXt5XE7lkZ0wHWY8 M3s4eBAfUNxijiKgjZLVtp7meHvqCKiOdnLG95Zdz8vp7JwDteThnTPiNyHaeUwd vOpA1ugxC9KxLZ4QxVcxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefjedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucgoteeftdduqddtudculdduhedmnecujfgurhephf fvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrrhhkucfrvggrrhhs ohhnuceomhhpvggrrhhsohhnqdhlvghnohhvohesshhquhgvsggsrdgtrgeqnecuggftrf grthhtvghrnhepvedtlefggefgjeettddvgfekhfeugfeutdekfeefudeuuddvieeutdel jedvhfdvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmphgvrghrshhonhdqlhgvnhhovhho sehsqhhuvggssgdrtggr X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Mar 2023 20:32:31 -0400 (EDT) From: Mark Pearson To: mpearson-lenovo@squebb.ca Cc: hdegoede@redhat.com, markgross@kernel.org, markpearson@lenovo.com, thomas@t-8ch.de, pobrn@protonmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/4] platform/x86: think-lmi: add missing type attribute Date: Sun, 19 Mar 2023 20:32:18 -0400 Message-Id: <20230320003221.561750-1-mpearson-lenovo@squebb.ca> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760846052220690541?= X-GMAIL-MSGID: =?utf-8?q?1760846052220690541?= This driver was missing the mandatory type attribute...oops. Add it in along with logic to determine whether the attribute is an enumeration type or a string by parsing the possible_values attribute. Upstream bug https://bugzilla.kernel.org/show_bug.cgi?id=216460 Signed-off-by: Mark Pearson --- Changes in v4: - Unchanged. Sending to linux-kernel mailing list as recommended Changes in v3: - Rebased on latest pdx86, review_hans branch Changes in v2: - Simplify the code and move type determination into show function - Don't use Fixes with URL in commit info drivers/platform/x86/think-lmi.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c index cc66f7cbccf2..a765bf8c27d8 100644 --- a/drivers/platform/x86/think-lmi.c +++ b/drivers/platform/x86/think-lmi.c @@ -947,6 +947,20 @@ static ssize_t possible_values_show(struct kobject *kobj, struct kobj_attribute return sysfs_emit(buf, "%s\n", setting->possible_values); } +static ssize_t type_show(struct kobject *kobj, struct kobj_attribute *attr, + char *buf) +{ + struct tlmi_attr_setting *setting = to_tlmi_attr_setting(kobj); + + if (setting->possible_values) { + /* Figure out what setting type is as BIOS does not return this */ + if (strchr(setting->possible_values, ',')) + return sysfs_emit(buf, "enumeration\n"); + } + /* Anything else is going to be a string */ + return sysfs_emit(buf, "string\n"); +} + static ssize_t current_value_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) @@ -1036,10 +1050,13 @@ static struct kobj_attribute attr_possible_values = __ATTR_RO(possible_values); static struct kobj_attribute attr_current_val = __ATTR_RW_MODE(current_value, 0600); +static struct kobj_attribute attr_type = __ATTR_RO(type); + static struct attribute *tlmi_attrs[] = { &attr_displ_name.attr, &attr_current_val.attr, &attr_possible_values.attr, + &attr_type.attr, NULL };