diff mbox series

[v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer

Message ID 20230319173006.30455-1-robh@kernel.org
State New
Headers
Series [v2] dt-bindings: mmc: fujitsu: Add Socionext Synquacer |

Commit Message

Rob Herring March 19, 2023, 5:30 p.m. UTC 
  Add support for Socionext Synquacer SDHCI. This binding has been in use for
some time.

The interrupts were not documented. The driver only uses the first
interrupt, but the DT and example have 2 interrupts. The 2nd one is
unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Signed-off-by: Rob Herring <robh@kernel.org>
---
v2:
 - Rebase on conversion done by Kunihiko
---
 .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml       | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

Comments

Krzysztof Kozlowski March 20, 2023, 3:28 p.m. UTC | #1 
On 19/03/2023 18:30, Rob Herring wrote:
> Add support for Socionext Synquacer SDHCI. This binding has been in use for
> some time.
> 
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Kunihiko Hayashi March 22, 2023, 2:27 a.m. UTC | #2 
Hi Rob,

On 2023/03/20 2:30, Rob Herring wrote:
> Add support for Socionext Synquacer SDHCI. This binding has been in use
> for
> some time.
> 
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.

Surely "interrupts" is needed. The 2nd interrupt seems to come from
the card, though, the driver isn't supported it.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Thank you,

> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> v2:
>   - Rebase on conversion done by Kunihiko
> ---
>   .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml       | 15 ++++++++++++---
>   1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> index 73d747e917f3..430b62899397 100644
> --- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> @@ -14,9 +14,13 @@ allOf:
>   
>   properties:
>     compatible:
> -    enum:
> -      - fujitsu,mb86s70-sdhci-3.0
> -      - socionext,f-sdh30-e51-mmc
> +    oneOf:
> +      - items:
> +          - const: socionext,synquacer-sdhci
> +          - const: fujitsu,mb86s70-sdhci-3.0
> +      - enum:
> +          - fujitsu,mb86s70-sdhci-3.0
> +          - socionext,f-sdh30-e51-mmc
>   
>     reg:
>       maxItems: 1
> @@ -29,6 +33,11 @@ properties:
>         - const: iface
>         - const: core
>   
> +  dma-coherent: true
> +
> +  interrupts:
> +    maxItems: 2
> +
>     resets:
>       maxItems: 1
>   


---
Best Regards
Kunihiko Hayashi
Ulf Hansson March 23, 2023, 12:13 p.m. UTC | #3 
On Sun, 19 Mar 2023 at 18:30, Rob Herring <robh@kernel.org> wrote:
>
> Add support for Socionext Synquacer SDHCI. This binding has been in use for
> some time.
>
> The interrupts were not documented. The driver only uses the first
> interrupt, but the DT and example have 2 interrupts. The 2nd one is
> unknown. "dma-coherent" was also not documented, but is used on Synquacer.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
> v2:
>  - Rebase on conversion done by Kunihiko
> ---
>  .../bindings/mmc/fujitsu,sdhci-fujitsu.yaml       | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> index 73d747e917f3..430b62899397 100644
> --- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
> @@ -14,9 +14,13 @@ allOf:
>
>  properties:
>    compatible:
> -    enum:
> -      - fujitsu,mb86s70-sdhci-3.0
> -      - socionext,f-sdh30-e51-mmc
> +    oneOf:
> +      - items:
> +          - const: socionext,synquacer-sdhci
> +          - const: fujitsu,mb86s70-sdhci-3.0
> +      - enum:
> +          - fujitsu,mb86s70-sdhci-3.0
> +          - socionext,f-sdh30-e51-mmc
>
>    reg:
>      maxItems: 1
> @@ -29,6 +33,11 @@ properties:
>        - const: iface
>        - const: core
>
> +  dma-coherent: true
> +
> +  interrupts:
> +    maxItems: 2
> +
>    resets:
>      maxItems: 1
>
> --
> 2.39.2
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
index 73d747e917f3..430b62899397 100644
--- a/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
+++ b/Documentation/devicetree/bindings/mmc/fujitsu,sdhci-fujitsu.yaml
@@ -14,9 +14,13 @@  allOf:
 
 properties:
   compatible:
-    enum:
-      - fujitsu,mb86s70-sdhci-3.0
-      - socionext,f-sdh30-e51-mmc
+    oneOf:
+      - items:
+          - const: socionext,synquacer-sdhci
+          - const: fujitsu,mb86s70-sdhci-3.0
+      - enum:
+          - fujitsu,mb86s70-sdhci-3.0
+          - socionext,f-sdh30-e51-mmc
 
   reg:
     maxItems: 1
@@ -29,6 +33,11 @@  properties:
       - const: iface
       - const: core
 
+  dma-coherent: true
+
+  interrupts:
+    maxItems: 2
+
   resets:
     maxItems: 1