From patchwork Sun Mar 19 16:46:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 71825 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp792978wrt; Sun, 19 Mar 2023 09:52:25 -0700 (PDT) X-Google-Smtp-Source: AK7set8y3RAqFk0SRr4K7996hJcZkhOAWgMGE83DpPuDEr3ZgxgdKcvLAOz41+mOtTxewF0Vqt1o X-Received: by 2002:a17:90a:1c4:b0:23d:3549:82b7 with SMTP id 4-20020a17090a01c400b0023d354982b7mr16094097pjd.46.1679244745250; Sun, 19 Mar 2023 09:52:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679244745; cv=none; d=google.com; s=arc-20160816; b=A8xqewyt1PUDnNJdGAz/p4+7pZGhvfC5onvZtPq3KwBrYoePK6RmcLSx+NgfFok5Mq 79loOb53mAnohHJSSrsVVUYIMZBz8kxU8N/O6YYgilhkMhXx4uRjoMX6rjiRNoBrjOVp gxkHhng5hwygGzRfbJB7XJqwB2mRaIPrazObzADV13luyJWeyDtgmh0d9V8ZgQA7aFl7 4FU1/baWh7CtWWdQnVltimv3zDutQlU7sRFGfJi25lozydpjrRjdYdOE+WemvtCTamDQ /19S2LkIgdjnW1bk4m0/xvfwz4fOClQiWsrHqevz6WHlDBN0Q+EyQkR2FddDhORKB5sF 8oGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=eqxm57PIoIdwEytUSUXLOR8MFVVNxjLvIVSPs7s/Ofk=; b=WMPsG8DUaNM92QyEtKKToCpSc4hY2zvWl7lztPQeCvXjAKVaO6W4qNBr2PDuRDnI42 cH9lE99FULs2e7w/MlChd5Up9iVyHZ8NM23FXJfGuzkacEV232e/Lf3nPhEQ8pkFcTC8 pk0WYI1iUnVcYFc5K0M+We9h8ovwOKuF9cb0DhPaxO/UkQusc4+1AIGL0PfI2BIw3UsO XkcBfBOg91lrrQrAQx54fx7BsIq8EPT/sjduHjtOWwYMJ1wZf+M7WSWh6bYGbY7UYZpA kexIhjEXFLjni5YD4y36De+J7wa6TLS3VxWneApb0ngMwvgFWbJ6s5ntd/LDX+6hr9PX IcXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3-20020a17090a9bc300b00234ac7c8061si13472976pjw.175.2023.03.19.09.52.09; Sun, 19 Mar 2023 09:52:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbjCSQsJ (ORCPT + 99 others); Sun, 19 Mar 2023 12:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjCSQrw (ORCPT ); Sun, 19 Mar 2023 12:47:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E0C1E9FC for ; Sun, 19 Mar 2023 09:47:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 579F261137 for ; Sun, 19 Mar 2023 16:47:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34220C433B3; Sun, 19 Mar 2023 16:47:50 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pdwCD-000Ja5-0z; Sun, 19 Mar 2023 12:47:49 -0400 Message-ID: <20230319164749.115087761@goodmis.org> User-Agent: quilt/0.66 Date: Sun, 19 Mar 2023 12:46:50 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Ingo Molnar , Mike Rapoport , Vlastimil Babka , Mukesh Ojha Subject: [for-linus][PATCH 7/8] ring-buffer: remove obsolete comment for free_buffer_page() References: <20230319164643.513018619@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760815738231162322?= X-GMAIL-MSGID: =?utf-8?q?1760815738231162322?= From: Vlastimil Babka The comment refers to mm/slob.c which is being removed. It comes from commit ed56829cb319 ("ring_buffer: reset buffer page when freeing") and according to Steven the borrowed code was a page mapcount and mapping reset, which was later removed by commit e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer"). Thus the comment is not accurate anyway, remove it. Link: https://lore.kernel.org/linux-trace-kernel/20230315142446.27040-1-vbabka@suse.cz Cc: Masami Hiramatsu Cc: Ingo Molnar Reported-by: Mike Rapoport Suggested-by: Steven Rostedt (Google) Fixes: e4c2ce82ca27 ("ring_buffer: allocate buffer page pointer") Signed-off-by: Vlastimil Babka Reviewed-by: Mukesh Ojha Signed-off-by: Steven Rostedt (Google) --- kernel/trace/ring_buffer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 071184324d18..3c7cd135333f 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage) local_set(&bpage->commit, 0); } -/* - * Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing - * this issue out. - */ static void free_buffer_page(struct buffer_page *bpage) { free_page((unsigned long)bpage->page);