From patchwork Sun Mar 19 16:46:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 71828 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp794380wrt; Sun, 19 Mar 2023 09:57:12 -0700 (PDT) X-Google-Smtp-Source: AK7set9dfxvzSTC9NJj6gVVKJ6tccN6MMGbphsnPStzmFMFnGnrmiW+/qg7uTRtkEexCm68wdYZX X-Received: by 2002:a05:6a20:6909:b0:cb:8885:5650 with SMTP id q9-20020a056a20690900b000cb88855650mr20054461pzj.55.1679245031985; Sun, 19 Mar 2023 09:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679245031; cv=none; d=google.com; s=arc-20160816; b=dHddWe/8GIoxV5GojxjfIr9pas+qhflwW+dJNEh2Tm4+aQ+CVFvlb+DzhjRvZXgkQF f2CZB8Oa4XyVnmtjIo1LL5nvyIG2oOVaC0LMyNi4Hhoppbc8LHxXMQnfZdkQEiehDScy aPKiVhALjRemS4nXCZ8mk4sTBREnGSO7pcP6d5ieAyoGGtdyhxQZs3J/Mctz+oLumBrk o+AWt+2bkvQHqae5DHtQaeubQQwXySVc+NzE1kgRGZ8YFSiq7sSm67jYxLVVANkAo+Da IMUgAL8s/bMEsihPdtrE1N32L7I1MZVWKp9EI7c34ziVrWYmaNWfuMHiKHM6jSMbIGXU fePw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=w2YFkQZA2p0X79m9SzXZEY3PHBvXzE1CkwsOdZWOong=; b=RwfMw4Xh91hIys1tBi5k2s1yQp4xGbmilPqJOArsCagZUqqiPY7RVOIwzBfa4MgI2j F1Y3Hs5fS/qZPBBJ1q4XDC4rRzEtujzn97M7SPxr/KdC4UzHoABvkKnuVoICeiaV9rxR 3q38uHVYyw4dCgsxb6wfN79390gbOQshPg1LxGavnT4zHVlpwrijcz5uM91P7N10H+wi nR5EHPzFSAijqdFcU2hn9JW1AbcNPSvqlQril7xqTx4zP4Ev++qFpxyFH1eb3q3/zypa /JZW2Mmi0y51o2K1/TSsQOpQNUBheyjKbhDIIjoYvYF1Joyjsn1r+idPOJBAnmXO85ON S6lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w22-20020a056a0014d600b005a919052520si8172738pfu.317.2023.03.19.09.56.58; Sun, 19 Mar 2023 09:57:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbjCSQsR (ORCPT + 99 others); Sun, 19 Mar 2023 12:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231128AbjCSQrx (ORCPT ); Sun, 19 Mar 2023 12:47:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D8351E9F2 for ; Sun, 19 Mar 2023 09:47:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3FC6EB80C8C for ; Sun, 19 Mar 2023 16:47:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F3A2C433B0; Sun, 19 Mar 2023 16:47:50 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pdwCD-000JZV-0I; Sun, 19 Mar 2023 12:47:49 -0400 Message-ID: <20230319164748.909374812@goodmis.org> User-Agent: quilt/0.66 Date: Sun, 19 Mar 2023 12:46:49 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Sung-hun Kim Subject: [for-linus][PATCH 6/8] tracing: Make splice_read available again References: <20230319164643.513018619@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760816038631485872?= X-GMAIL-MSGID: =?utf-8?q?1760816038631485872?= From: Sung-hun Kim Since the commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops") is applied to the kernel, splice() and sendfile() calls on the trace file (/sys/kernel/debug/tracing /trace) return EINVAL. This patch restores these system calls by initializing splice_read in file_operations of the trace file. This patch only enables such functionalities for the read case. Link: https://lore.kernel.org/linux-trace-kernel/20230314013707.28814-1-sfoon.kim@samsung.com Signed-off-by: Sung-hun Kim Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index fbb602a8b64b..4e9a7a952025 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5164,6 +5164,8 @@ loff_t tracing_lseek(struct file *file, loff_t offset, int whence) static const struct file_operations tracing_fops = { .open = tracing_open, .read = seq_read, + .read_iter = seq_read_iter, + .splice_read = generic_file_splice_read, .write = tracing_write_stub, .llseek = tracing_lseek, .release = tracing_release,