From patchwork Sun Mar 19 16:46:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 71832 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp798652wrt; Sun, 19 Mar 2023 10:08:00 -0700 (PDT) X-Google-Smtp-Source: AK7set/e5IiSChjoNN2frseicaErPIRdVqMJWeSCe7NBA1cnANs7KjMcBIYLlfRaBLUIE1rxLREm X-Received: by 2002:aa7:98d0:0:b0:627:f837:2f5b with SMTP id e16-20020aa798d0000000b00627f8372f5bmr1123492pfm.11.1679245679853; Sun, 19 Mar 2023 10:07:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679245679; cv=none; d=google.com; s=arc-20160816; b=v4jJqY4HDZW8eR6ked/g/ITL8EMmWpOEFYfPdrtq7BRoSRhnuRgdoPHheCzxaVIClU ZufO9dDMmUykbtPn7jYxFCO4vxuiwpKKIrAbBSpWbRliffjfxW7YPMHcuP0TljO3W7az WdHPssm08h3+LpaW3kh2jAh0VCWfUiV8XGeWy1OBmHtA3c+qiD4OponfvQzTbxFeHcGj iHlcIPcbqTm4VYGzrYbfMehIKWGWEFn0oL2uq6AAE5wufR1+7DOt6SJZ3lB6CNzuam3U /EceMOxleWuWLewGe0EUMq+gDbhZ3X2TgdMi7noCkIWLGE9Ryq5SXHZ3/Xz4OoJVsWiE 1O0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=v6zrc9RdQzjZGlLUxq7Ly9HJhqZj6pd+Mn2s7PzNNKw=; b=yjfUQya/yVZo6jR3u5Vlvcg/LEk89SmfnTnGwptC3ixKXS8Ek9dEUd1nK8fL6F1sy0 SSBBYd3gbVuf9AOSZ2fw0y9Ul1hhHNTWTyLNZFt7gzb3pmmaKjIxtVwsZqIhG2EXivtD XlovzBWnEg3WIoHwON5EvaxZYGCRnXDPsciL5SAcXCJwEZajl6okcg63xXq07Fa+szjw 0pu5EvRYgAMVot0nD5C+HvxSSJFDNIcfucqxxXQm4tgDk1YFG8l3cX3UP6dTY+CsQs01 eL4RpuZE4eWZQVYkjlLTTCQgPBxnmkqtmYl/O6Qdfd40pA13K4ao64fHbssE2Kzq4hO7 BXbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a63d207000000b004fb8fe66ef7si7916291pgg.221.2023.03.19.10.07.45; Sun, 19 Mar 2023 10:07:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231175AbjCSQsX (ORCPT + 99 others); Sun, 19 Mar 2023 12:48:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231129AbjCSQry (ORCPT ); Sun, 19 Mar 2023 12:47:54 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ACD71E9E2 for ; Sun, 19 Mar 2023 09:47:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8DBDACE0F6E for ; Sun, 19 Mar 2023 16:47:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD19BC433AC; Sun, 19 Mar 2023 16:47:49 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pdwCC-000JYx-2r; Sun, 19 Mar 2023 12:47:48 -0400 Message-ID: <20230319164748.701864960@goodmis.org> User-Agent: quilt/0.66 Date: Sun, 19 Mar 2023 12:46:48 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Tom Rix Subject: [for-linus][PATCH 5/8] ftrace: Set direct_ops storage-class-specifier to static References: <20230319164643.513018619@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760816718087603582?= X-GMAIL-MSGID: =?utf-8?q?1760816718087603582?= From: Tom Rix smatch reports this warning kernel/trace/ftrace.c:2594:19: warning: symbol 'direct_ops' was not declared. Should it be static? The variable direct_ops is only used in ftrace.c, so it should be static Link: https://lore.kernel.org/linux-trace-kernel/20230311135113.711824-1-trix@redhat.com Signed-off-by: Tom Rix Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index a47f7d93e32d..ec2897a76004 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -2503,7 +2503,7 @@ static void call_direct_funcs(unsigned long ip, unsigned long pip, arch_ftrace_set_direct_caller(fregs, addr); } -struct ftrace_ops direct_ops = { +static struct ftrace_ops direct_ops = { .func = call_direct_funcs, .flags = FTRACE_OPS_FL_DIRECT | FTRACE_OPS_FL_SAVE_REGS | FTRACE_OPS_FL_PERMANENT,