From patchwork Sun Mar 19 16:46:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 71826 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp793107wrt; Sun, 19 Mar 2023 09:52:51 -0700 (PDT) X-Google-Smtp-Source: AK7set+kVH/5L6jh+yJDabXS2jso/FenHohqBkTz7UEcDQDPkIVygAiNIJNoeiU65nbxbZUEGBct X-Received: by 2002:a05:6a20:8413:b0:d5:c14c:1263 with SMTP id c19-20020a056a20841300b000d5c14c1263mr18037703pzd.53.1679244771576; Sun, 19 Mar 2023 09:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679244771; cv=none; d=google.com; s=arc-20160816; b=aACuckbQfLfxtWdBf4fWwr5qjEgeKBMFVFf2v6ZhYYqebT7jPZ9yzWCaqLD7488aKY fnSOSEprvWjkzuT7BoIqyhuYUiuaYrDtFmNFFlgWcAUiDY3b8z5lpA5PyUkia6/Qatir omDmIJzUz6mWX39ZtheNMej3DTvuRbS+X0g3pogLuJwxY9mkQs0cmyhJoRqWXmc2fdM6 fZGG6nRFlzPDmnt7JFfgJbTenNEJZtQZrWBjHbYBTcGpAdQ6HFARhCbj7FDB6fsy2HmL KsFmDinZdNSw3e/LnGwj/MB95tl/Wcw4Y84XCIlAW5vvoyB6iRzM64k1l4gWuDwF1v4W RIJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=VroE6XB4hMNWSGrhngoYNseEdmnkIhH5q4ds3/cC+Nw=; b=FNJLf/ty706HEVWDJPKmGqRVVjK3fj9Tdy8SePHCynjJRiLMpPz3kWyCDC9H0cxcNM AdQKvLpJnTBzHHCIKLiVTf99zRpA4wqJfeEUP4sTWylxATqvLBwgXkmKS0Jf+ZaRR0KA pWX8eUj03EgAaqEcd24nWGSaZeCt796y2xPPBdaMQ8nsfvpbtofLq+2ziuz3RyX3QLwL SKIvrwpJOxAlXyCtYvUTad8wHx50fM8WSiu2mvki9oT2sl1DE7q15bFEJ91xViy20mAe PIEMNKhSY/CFa4ht5kjBAdD1V3OqaF2PX8oX+1uLh4uQmYNhJxDSkVPAzfOAnNWIfGLP 92dg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ei19-20020a056a0080d300b00627ed0fa77csi2785533pfb.188.2023.03.19.09.52.12; Sun, 19 Mar 2023 09:52:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbjCSQsE (ORCPT + 99 others); Sun, 19 Mar 2023 12:48:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230461AbjCSQrv (ORCPT ); Sun, 19 Mar 2023 12:47:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1AC81E9F8; Sun, 19 Mar 2023 09:47:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 24C5061136; Sun, 19 Mar 2023 16:47:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 902E3C433A8; Sun, 19 Mar 2023 16:47:49 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pdwCC-000JYP-2C; Sun, 19 Mar 2023 12:47:48 -0400 Message-ID: <20230319164748.496556562@goodmis.org> User-Agent: quilt/0.66 Date: Sun, 19 Mar 2023 12:46:47 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , stable@vger.kernel.org, Tero Kristo , Daniel Bristot de Oliveira Subject: [for-linus][PATCH 4/8] trace/hwlat: Do not start per-cpu thread if it is already running References: <20230319164643.513018619@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760815765730269854?= X-GMAIL-MSGID: =?utf-8?q?1760815765730269854?= From: Tero Kristo The hwlatd tracer will end up starting multiple per-cpu threads with the following script: #!/bin/sh cd /sys/kernel/debug/tracing echo 0 > tracing_on echo hwlat > current_tracer echo per-cpu > hwlat_detector/mode echo 100000 > hwlat_detector/width echo 200000 > hwlat_detector/window echo 1 > tracing_on To fix the issue, check if the hwlatd thread for the cpu is already running, before starting a new one. Along with the previous patch, this avoids running multiple instances of the same CPU thread on the system. Link: https://lore.kernel.org/all/20230302113654.2984709-1-tero.kristo@linux.intel.com/ Link: https://lkml.kernel.org/r/20230310100451.3948583-3-tero.kristo@linux.intel.com Cc: stable@vger.kernel.org Fixes: f46b16520a087 ("trace/hwlat: Implement the per-cpu mode") Signed-off-by: Tero Kristo Acked-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_hwlat.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c index edc26dc22c3f..c4945f8adc11 100644 --- a/kernel/trace/trace_hwlat.c +++ b/kernel/trace/trace_hwlat.c @@ -492,6 +492,10 @@ static int start_cpu_kthread(unsigned int cpu) { struct task_struct *kthread; + /* Do not start a new hwlatd thread if it is already running */ + if (per_cpu(hwlat_per_cpu_data, cpu).kthread) + return 0; + kthread = kthread_run_on_cpu(kthread_fn, NULL, cpu, "hwlatd/%u"); if (IS_ERR(kthread)) { pr_err(BANNER "could not start sampling thread\n");