From patchwork Sun Mar 19 16:46:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 71829 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp795442wrt; Sun, 19 Mar 2023 10:00:25 -0700 (PDT) X-Google-Smtp-Source: AK7set/7UTw0TfiJq0whUGPKX54j/7wcvd6XMFJsB7Veqy0JtEbRZhR9A78D6xXhodGIFw8eTYjl X-Received: by 2002:a17:903:1251:b0:19a:aaac:f4d1 with SMTP id u17-20020a170903125100b0019aaaacf4d1mr9756604plh.13.1679245224932; Sun, 19 Mar 2023 10:00:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679245224; cv=none; d=google.com; s=arc-20160816; b=PZMEoqgzgRqQ3GdvKagpGGvjg/nuAKrXl9H11SUC8/IRwp33zEG7Rxzr6Krqt9vn1r Rdex5OmhPYuDfWn4RZRh/LPteORtJNXTrRexIyeO/OqvxiOuiNykculf2iZtvSdTNpj6 UB1nV9Ahed3sZ3tRu/2ALNZ5G7ftW7RUkXt8r1AUsrsoJXHaxXfWK+xnIK1/vV+Sfm2F m/9Kxs2b2ihkYtnn0radHmnWZi+2yWlpsDqm9GOIbx1dUdDjIV8gh3oQhMV1GYg8ed4W DGjahCgdW2hPFQYfTjr/UBhLbJW5/ccqNC0mcYksPuU9U6mohwgLcPBorf//LxCbXHUe NItg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=fzhAPrj+jcGCzkEJjAFoPrTjUR+qDu4X6PxsUFj+BBs=; b=ivijnZe7u7YV1LfUA3LraIvi9UXwQQhprTuehkL8CyQNIFVyg1s7R9I9LvFVzggDOo /zGiyPqeltH/ny/DZFVvNzgJDMbWFcbwn5uVZe7zJxqcTYTmCcu2fRNWeLhfYtMOGj0e G658pQxRXxTubbvZ5tuBlbSQe7v6jGVwFSyKMF+TD2eUDoM7pmEB9/k0PVbVLK98g2gJ kWg0o+n4TypJ6LfukTE/LBCrl/VgaCbVOHtiZfU0FlkrWwX5oE3CgTDT+GTu851YOF8K YumDEj/MmIn9G1EXhIwMxtD0JjEcGZF/nXuneKtlmqyjJ0Kx3TR57HusQe2K4KqG/sXF JWjw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q20-20020a170902b11400b001990648edbbsi7701340plr.520.2023.03.19.10.00.11; Sun, 19 Mar 2023 10:00:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbjCSQrx (ORCPT + 99 others); Sun, 19 Mar 2023 12:47:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230266AbjCSQrv (ORCPT ); Sun, 19 Mar 2023 12:47:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BF3C1E9E8 for ; Sun, 19 Mar 2023 09:47:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC58861134 for ; Sun, 19 Mar 2023 16:47:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AA8AC4339E; Sun, 19 Mar 2023 16:47:49 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1pdwCC-000JXJ-0r; Sun, 19 Mar 2023 12:47:48 -0400 Message-ID: <20230319164748.089580957@goodmis.org> User-Agent: quilt/0.66 Date: Sun, 19 Mar 2023 12:46:45 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Tom Rix , Daniel Bristot de Oliveira Subject: [for-linus][PATCH 2/8] tracing/osnoise: set several trace_osnoise.c variables storage-class-specifier to static References: <20230319164643.513018619@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760816241004575667?= X-GMAIL-MSGID: =?utf-8?q?1760816241004575667?= From: Tom Rix smatch reports several similar warnings kernel/trace/trace_osnoise.c:220:1: warning: symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static? kernel/trace/trace_osnoise.c:243:1: warning: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static? kernel/trace/trace_osnoise.c:335:14: warning: symbol 'interface_lock' was not declared. Should it be static? kernel/trace/trace_osnoise.c:2242:5: warning: symbol 'timerlat_min_period' was not declared. Should it be static? kernel/trace/trace_osnoise.c:2243:5: warning: symbol 'timerlat_max_period' was not declared. Should it be static? These variables are only used in trace_osnoise.c, so it should be static Link: https://lore.kernel.org/linux-trace-kernel/20230309150414.4036764-1-trix@redhat.com Signed-off-by: Tom Rix Acked-by: Masami Hiramatsu (Google) Acked-by: Daniel Bristot de Oliveira Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_osnoise.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 04f0fdae19a1..9176bb7a9bb4 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -217,7 +217,7 @@ struct osnoise_variables { /* * Per-cpu runtime information. */ -DEFINE_PER_CPU(struct osnoise_variables, per_cpu_osnoise_var); +static DEFINE_PER_CPU(struct osnoise_variables, per_cpu_osnoise_var); /* * this_cpu_osn_var - Return the per-cpu osnoise_variables on its relative CPU @@ -240,7 +240,7 @@ struct timerlat_variables { u64 count; }; -DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var); +static DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var); /* * this_cpu_tmr_var - Return the per-cpu timerlat_variables on its relative CPU @@ -332,7 +332,7 @@ struct timerlat_sample { /* * Protect the interface. */ -struct mutex interface_lock; +static struct mutex interface_lock; /* * Tracer data. @@ -2239,8 +2239,8 @@ static struct trace_min_max_param osnoise_print_stack = { /* * osnoise/timerlat_period: min 100 us, max 1 s */ -u64 timerlat_min_period = 100; -u64 timerlat_max_period = 1000000; +static u64 timerlat_min_period = 100; +static u64 timerlat_max_period = 1000000; static struct trace_min_max_param timerlat_period = { .lock = &interface_lock, .val = &osnoise_data.timerlat_period,