| Message ID | 20230319155910.1706294-1-trix@redhat.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp782110wrt;
Sun, 19 Mar 2023 09:16:16 -0700 (PDT)
X-Google-Smtp-Source:
AK7set8mIClX5WMDDVwsUEc5C1+FKaxyQjRiYUDrr4i22hRq8q+WuC5M27lM+nxKg/nZgob3g27f
X-Received: by 2002:a17:903:2845:b0:1a1:c2cb:f459 with SMTP id
kq5-20020a170903284500b001a1c2cbf459mr2807987plb.29.1679242576316;
Sun, 19 Mar 2023 09:16:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679242576; cv=none;
d=google.com; s=arc-20160816;
b=Q/UzqKhlLyTHd0UN3easrmWdrKqiwyhR9Ipt6N8hyIqtGeMRDCndp3ksnnqupnzs8r
AXktYXBHf7sN58NV0t4VBRXHCvM/1iDt8NN6qbdIhRLXRnMzB59FVmpRsFDHN4lvjdcw
hFxwfZfHMfV1/PgRq+JmMKf+LMcn4GURzuoUb4RNNy6BtGFszDAzFhSdLnMlNwYCRz2t
Z01riEgL3dNLjgXfsE2rx75BcBLQ6gaZ6rniFoAMeTKMpI2RFeHv6oM5EYh6xEfUmBzu
G95iVUIzNzb/bB8XqxS7LrBfv3h1plSYTIfZMG4qtpbF+hoO6/Lmjei5H2irh2FYGKiU
XzQA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=kCgICu0KJAkXhiDRi5y/cM8U5p1k5bVMfl4yuYsdSQw=;
b=ZoPIPj954WKR/UvQjtjwb30+Wxbh7N6hdyaiji1S0Q2pf/KESfh0cDEdUngflTZNbQ
8k92784aG3BfjHh+DFc97mKYcNOOJsQIOWsHBLB1lFJ3tLjST0FlSR8mJ4r+K1+TtJdE
XQFGXN/8LU/hD50S/I0/mWBbyzJl/3JV+1+SkEkAfg13wZW45FnpNC9xg/ozUp4pM/OW
x6FL3i1FNmV5xCa1wvIVFiBMxJTyskqjX8qKvUI3koTKX52XYFHKrACI90Sk5+nMq9S8
3APYLn2TjA0M6+A67kr+If+LuA+lnAWUlF04q6HFobyl05qc6lKKX4W4jWoViUyG0QT1
9fLQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=dWQOYXga;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
e10-20020a170902744a00b0019c33978781si7917113plt.283.2023.03.19.09.16.03;
Sun, 19 Mar 2023 09:16:16 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=dWQOYXga;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230289AbjCSQAF (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others);
Sun, 19 Mar 2023 12:00:05 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37608 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229759AbjCSQAC (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 19 Mar 2023 12:00:02 -0400
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 442E1166F8
for <linux-kernel@vger.kernel.org>;
Sun, 19 Mar 2023 08:59:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1679241555;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=kCgICu0KJAkXhiDRi5y/cM8U5p1k5bVMfl4yuYsdSQw=;
b=dWQOYXgaLhFs6Dlbldi67ursN/z1B0yYGUpb5hRGzfYxyGTkrMzcJEnAMfjnV0pe708MJ9
WEwQBXohlFTrHLqnuAMu1z9S1frnhjR5fATnSoCs2og++G0Fj5Mbq4rZrj03x7vbJJckNs
teLgdq+s/7WrESXB8YLyPy0TAwaNUvY=
Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com
[209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-353-vIL5qWYJNvi07Vo12XUynA-1; Sun, 19 Mar 2023 11:59:13 -0400
X-MC-Unique: vIL5qWYJNvi07Vo12XUynA-1
Received: by mail-qt1-f198.google.com with SMTP id
j5-20020ac85c45000000b003d81e3fe559so5359950qtj.16
for <linux-kernel@vger.kernel.org>;
Sun, 19 Mar 2023 08:59:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1679241553;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=kCgICu0KJAkXhiDRi5y/cM8U5p1k5bVMfl4yuYsdSQw=;
b=F0nQs9YMN670dO2Dnz8/05GAiURxFsbtDAGrh90W8c9CGWHgjOJ8bLdObRrK7P0Jkz
8ETCZHxo2ovkQxeBv7whn2tHHd97IR0Xue01e5SmgZVJhsxeOu3CxueJ+ulIzU30TdI5
/eyM/uOBFvcLUxqPHHMhviAJrgw8ewdFOq+KNmW6L46SxeMpzauYPaZjZSHlvNpE/YjU
VbTw7TxzD3c6vI1gJfZhpXqEGk/hsSAh3j5TEjKnqRYpVndUf1XwsVDbBXJh7g4tn6Q7
3mlvQ3YuF7/iAiYwaHfbLVz8PGNR6BW6FlBed/CzsVI83UqrwcIIqgdhz1NaoxziNCb5
jKGQ==
X-Gm-Message-State: AO0yUKWhdzy9Gxm1ZW6Ib693DOGICMz/ZU2k/96WIs6XvPLc226O+NeG
cLj1v806hqZ2Ahz+xBVZ5yAh9TMe2UX8tA4ihZfXOS0esxK0KjwyV2cxgYXWg0/c9nHH1C321lI
QA71HOSe0XgAXEWGyiwF43Xf1
X-Received: by 2002:a05:622a:188c:b0:3bf:e2ff:4c2f with SMTP id
v12-20020a05622a188c00b003bfe2ff4c2fmr21989746qtc.51.1679241553401;
Sun, 19 Mar 2023 08:59:13 -0700 (PDT)
X-Received: by 2002:a05:622a:188c:b0:3bf:e2ff:4c2f with SMTP id
v12-20020a05622a188c00b003bfe2ff4c2fmr21989732qtc.51.1679241553187;
Sun, 19 Mar 2023 08:59:13 -0700 (PDT)
Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com
(nat-pool-bos-t.redhat.com. [66.187.233.206])
by smtp.gmail.com with ESMTPSA id
139-20020a370591000000b00745a78b0b3asm1710434qkf.130.2023.03.19.08.59.12
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 19 Mar 2023 08:59:12 -0700 (PDT)
From: Tom Rix <trix@redhat.com>
To: herve.codina@bootlin.com, gregkh@linuxfoundation.org,
nathan@kernel.org, ndesaulniers@google.com
Cc: linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Tom Rix <trix@redhat.com>
Subject: [PATCH] usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset
function
Date: Sun, 19 Mar 2023 11:59:10 -0400
Message-Id: <20230319155910.1706294-1-trix@redhat.com>
X-Mailer: git-send-email 2.27.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760813463270705417?=
X-GMAIL-MSGID: =?utf-8?q?1760813463270705417?=
|
| Series |
usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset function
|
|
Commit Message
Tom Rix
March 19, 2023, 3:59 p.m. UTC
clang with W=1 reports
drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function
'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function]
static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset,
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/usb/gadget/udc/renesas_usbf.c | 11 -----------
1 file changed, 11 deletions(-)
Comments
Hi Tom, On Sun, 19 Mar 2023 11:59:10 -0400 Tom Rix <trix@redhat.com> wrote: > clang with W=1 reports > drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function > 'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function] > static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, > ^ > This function is not used, so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/usb/gadget/udc/renesas_usbf.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c > index cb23e62e8a87..84ac9fe4ce7f 100644 > --- a/drivers/usb/gadget/udc/renesas_usbf.c > +++ b/drivers/usb/gadget/udc/renesas_usbf.c > @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usbf_ep *ep, uint offset, > usbf_ep_dma_reg_writel(ep, offset, tmp); > } > > -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, > - u32 clr, u32 set) > -{ > - u32 tmp; > - > - tmp = usbf_ep_dma_reg_readl(ep, offset); > - tmp &= ~clr; > - tmp |= set; > - usbf_ep_dma_reg_writel(ep, offset, tmp); > -} > - > static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1) > { > u32 set; Yes, indeed. Acked-by: Herve Codina <herve.codina@bootlin.com> Thanks for the patch. Regards, Hervé
diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c index cb23e62e8a87..84ac9fe4ce7f 100644 --- a/drivers/usb/gadget/udc/renesas_usbf.c +++ b/drivers/usb/gadget/udc/renesas_usbf.c @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usbf_ep *ep, uint offset, usbf_ep_dma_reg_writel(ep, offset, tmp); } -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, - u32 clr, u32 set) -{ - u32 tmp; - - tmp = usbf_ep_dma_reg_readl(ep, offset); - tmp &= ~clr; - tmp |= set; - usbf_ep_dma_reg_writel(ep, offset, tmp); -} - static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1) { u32 set;