Message ID | 20230318131342.1684103-1-trix@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp286095wrt; Sat, 18 Mar 2023 06:18:17 -0700 (PDT) X-Google-Smtp-Source: AK7set94/Z8jG0GOlG2fh2Su8GW7QyxuDuFn49xOWh4/pXI/gr6dVuiK/B1tqCHkxjHE9yRUdxFv X-Received: by 2002:a05:6a20:8b9f:b0:d6:7d3a:c72 with SMTP id m31-20020a056a208b9f00b000d67d3a0c72mr6098752pzh.20.1679145497102; Sat, 18 Mar 2023 06:18:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679145497; cv=none; d=google.com; s=arc-20160816; b=P4fSR1qIDn+VSNJBMara6ae08N/rhGtCIFNs3QWRt+uWPklqpK4Aj52PH26WHx9llD J/VahIB4mucctkk3n4w7C1sWA6Nuzf/Y6qt7xWy7W5hOQSV5+uJVVIuDRR30ZKZbiiYa 1zTF3S1i3C0dHdtQTh3ZN2ocW1Hwmeak1cROPN9K0nY6rY1HCtp8g2zpBKp4vIQ6HqZR G0w3SF5Mx3aGmQWV7ZSOtRWzOoQrNueY66s8wwuMO+Jchcqc7YG7dTavIIvoUr52vo9B 3+nQsxjh8buwio/fjcJBcg20YKYJ/icRJELX34XD2YBHpER+uGmk4ddQUq04BSEAz4/C j9Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jgoarmppOveCAhzhSS+yukRVNHlYy4ELLTt4seUigM0=; b=qp7OTViPxrT9P+7YRot2tPiB0fAJdBFh+rCPjIlTNMuNh0USKoGxZ7lZ/aj+KB1uss SUzyFoy/lcFz6xgeL7uxm3l6BjRwLDeAXSHhxoqTL8AWc61UvMXiq76D1VjpGG3UVOWq HYEicAfCp4PLky7dFF04AATwPwzmxzHJgQrpFamB5BHl2S9MRYDWT+k4b4ogBCPaNn8q c25+nNbW536q3LJbJD8py6aP0Cu2X1krGLRpumfKPtI9nh6sxnC1oDm4wZuiQ7or620g kWdIPn3q6t8MVPnBV5hKFL6tDccgkDb0S9OMV84BQcwZB3QtrcCzYJiQJQjA8PZaqSFE YsDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LC4DzcQz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4-20020a656104000000b004fbd53187ecsi5089158pgu.258.2023.03.18.06.18.01; Sat, 18 Mar 2023 06:18:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LC4DzcQz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229769AbjCRNOj (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Sat, 18 Mar 2023 09:14:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbjCRNOh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 18 Mar 2023 09:14:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B6D512596 for <linux-kernel@vger.kernel.org>; Sat, 18 Mar 2023 06:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679145229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jgoarmppOveCAhzhSS+yukRVNHlYy4ELLTt4seUigM0=; b=LC4DzcQzVQgYtw/VGoaGoMDiwspvJ8I/lK2djyBTwlEMUuw5lK8Rj9Q7KLQv2SGgIhajbv 2Xta6AMta4eYWf3MSR6RMYswh1Y8xDxbWjZn5qQSZbIXZ1qdqgb3QcVEcClEgr+Vq54qvd YVoqQtRIi0k8rKJY55w0PscwtpPvGvY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-9JK1hhEKMjubT1PNTA59kw-1; Sat, 18 Mar 2023 09:13:48 -0400 X-MC-Unique: 9JK1hhEKMjubT1PNTA59kw-1 Received: by mail-qt1-f199.google.com with SMTP id t22-20020ac86a16000000b003bd1c0f74cfso4024427qtr.20 for <linux-kernel@vger.kernel.org>; Sat, 18 Mar 2023 06:13:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679145227; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jgoarmppOveCAhzhSS+yukRVNHlYy4ELLTt4seUigM0=; b=u+5iqLbHgL/hRh0nZdPwXgiAriq8l7XOWRjyBmjzTVIkGYGws8hSUI/Z2NXaPkV8Sm NWWYc9M5cTfbc1hCR90pxpZFSOl8H0/hmFZC3Rmh6hGZkA7RB5FrPaJfF/IfFE63Ip1A oaXIvRNu0Cjle1dDtS/syn0CqjE5DrAvR8dbjdC9iH/fAoD8MZLp4n0sLREtBzuUcicQ sqTNxfBX1xkrV+jg1fqx6R+UcBVHw4spFnDR1DS24AOf9fnZ2frFS/+Unlxo4PLQOFPo x/f8h//cDJ80GzTl/9iqmPhrVBUkUBssC+Mu6yESiB8LClNqsk6TRDQZP+jG7xrPNwMj fjmw== X-Gm-Message-State: AO0yUKW4UH20myN6J+SW7MRjX3pT7/QzLD144oH71mk7oADpk6+ChOAC w0txwkiX6aSclNvyHJw9MvhqIlm5ctbWMYPBAfgu78XsxSkPz7lrZlXM9LNAkt9yHAntaEdyI/w Q+rp84IC29Lqk7BV/1kINdpLK X-Received: by 2002:a05:622a:1116:b0:3d3:6285:a63 with SMTP id e22-20020a05622a111600b003d362850a63mr10899539qty.10.1679145227299; Sat, 18 Mar 2023 06:13:47 -0700 (PDT) X-Received: by 2002:a05:622a:1116:b0:3d3:6285:a63 with SMTP id e22-20020a05622a111600b003d362850a63mr10899504qty.10.1679145226993; Sat, 18 Mar 2023 06:13:46 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id bl28-20020a05620a1a9c00b007339c5114a9sm3575523qkb.103.2023.03.18.06.13.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:13:46 -0700 (PDT) From: Tom Rix <trix@redhat.com> To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, nathan@kernel.org, ndesaulniers@google.com, stern@rowland.harvard.edu, studentxswpy@163.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Tom Rix <trix@redhat.com> Subject: [PATCH] usb: plusb: remove unused pl_clear_QuickLink_features function Date: Sat, 18 Mar 2023 09:13:42 -0400 Message-Id: <20230318131342.1684103-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760711668701254470?= X-GMAIL-MSGID: =?utf-8?q?1760711668701254470?= |
Series |
usb: plusb: remove unused pl_clear_QuickLink_features function
|
|
Commit Message
Tom Rix
March 18, 2023, 1:13 p.m. UTC
clang with W=1 reports
drivers/net/usb/plusb.c:65:1: error:
unused function 'pl_clear_QuickLink_features' [-Werror,-Wunused-function]
pl_clear_QuickLink_features(struct usbnet *dev, int val)
^
This static function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/net/usb/plusb.c | 6 ------
1 file changed, 6 deletions(-)
Comments
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Sat, 18 Mar 2023 09:13:42 -0400 you wrote: > clang with W=1 reports > drivers/net/usb/plusb.c:65:1: error: > unused function 'pl_clear_QuickLink_features' [-Werror,-Wunused-function] > pl_clear_QuickLink_features(struct usbnet *dev, int val) > ^ > This static function is not used, so remove it. > > [...] Here is the summary with links: - usb: plusb: remove unused pl_clear_QuickLink_features function https://git.kernel.org/netdev/net/c/7d722c9802d4 You are awesome, thank you!
diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c index 7a2b0094de51..2894114858a2 100644 --- a/drivers/net/usb/plusb.c +++ b/drivers/net/usb/plusb.c @@ -61,12 +61,6 @@ pl_vendor_req(struct usbnet *dev, u8 req, u8 val, u8 index) val, index, NULL, 0); } -static inline int -pl_clear_QuickLink_features(struct usbnet *dev, int val) -{ - return pl_vendor_req(dev, 1, (u8) val, 0); -} - static inline int pl_set_QuickLink_features(struct usbnet *dev, int val) {