From patchwork Fri Mar 17 22:57:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 71511 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp31939wrt; Fri, 17 Mar 2023 16:08:02 -0700 (PDT) X-Google-Smtp-Source: AK7set/CUAhv04yjGmEofimh4PmZEZ2Hfuv7B/rz50mbcWHbWyanqRJDKkhTo5HMR0VoRpOArBYG X-Received: by 2002:a05:6a20:7f8c:b0:c7:af88:3dd8 with SMTP id d12-20020a056a207f8c00b000c7af883dd8mr11600562pzj.6.1679094482038; Fri, 17 Mar 2023 16:08:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679094482; cv=none; d=google.com; s=arc-20160816; b=ICufil1nz0ymOeeE+NKhN6dG+oq3fvU46eCILw1tUKmMNNDPN1HLU2recDekhZS5Ta Ae3hkH/OTplOjGeUKl0qG1IXRcZVtPWLFStsbKuFZgDXxo2uCMyHvVYAM2OtaGWbrOWo PtEXm1pnBRXC/XKV5GWREtCo2KcATmP2/HSfNBqQH1TMXykFKeP+gsd920eeGY9Tgwi/ JEt56v1IbWlCP4G83T84D4EFnPhIKEOsqhh/FDTkXjcDe5ald8mCVA1pZYRlR4rKjhFz evBiz0XgXVZaHdvML2J6UM2FbtO6ZFceg5nUZwzYo3DB1AfZjMas8SR24cBfUi65dRdS +Q0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0ZbOILg57NKz1tG77t9oBwY1CRjw4syn3pXv5PxRRXU=; b=WwZDE9Ixsav+yCuAuUY710GOstH1mIz4P2gEcoEJDXoqxXXoas6Lu/w5qIOGX/l+jv mIXDR4t9I4v4O9bW1B7d46sx3LJs7Yku1jeU2WfJxhIlWW0O5WVTrYFecEfG+K8Tl3c/ ibhYtOfnQfPWErK27Fi2Bk5imyIoSM41CqyS/32ykV22kFHffadM99Zl6fI0K7EX4yW7 Y6mR33gcIBs1v5T4eZbgC+4NvJbU8qZaTcbsQ18Wr1r+FAklnVGxoguSFRDYrZmVCky2 VicdzpDlLwash0sQUq5wzz7dPYuAoaDXiwFETKARCrnNHbmdByigIZK3LZD+gi7aeOqi NN6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dq2IlKXE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 206-20020a6302d7000000b004fc27d88c6fsi3580775pgc.592.2023.03.17.16.07.48; Fri, 17 Mar 2023 16:08:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dq2IlKXE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231200AbjCQW5u (ORCPT + 99 others); Fri, 17 Mar 2023 18:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230002AbjCQW5Q (ORCPT ); Fri, 17 Mar 2023 18:57:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17B722BF1A; Fri, 17 Mar 2023 15:57:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A0E460C22; Fri, 17 Mar 2023 22:57:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 894A9C4331E; Fri, 17 Mar 2023 22:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679093833; bh=VIy8olwrlGICMSJRbSV49sc6H5GVSRN/zSVEjc1k0Ak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dq2IlKXEfLtYs6s6s8Tjsnlk5m8gt3V+HRfoC0L5pv3LX9lFIe9UPCO04V96Pz2Ph xQfwdp5mE9X6oZiG8aGMIuwVaxBgBpGeJwCCXqFSsbSt91rXOewezFl1qxibQVP3+i WIlxrE91+ftcV4Ce4q1xOW8+6Aa/DWYs1vGoyVIeqRjlQ7wkj/aN+rDQcnZkzaMgXQ uGv3BqSfwulVfx4JyIE98jY8hvdRFmaa9N7X2Pq+2Rxl9M9s8dBgLwhZBhDGOuaMla xJqrtAwSNsUanIx/7brnKSsknFblKeK7R3fa3bNi+TfMKGRKING0u7npkCDAL41NAN A5ZoL9R4lb9WA== Received: by mercury (Postfix, from userid 1000) id 9F6AC1062115; Fri, 17 Mar 2023 23:57:08 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Cc: Linus Walleij , Matti Vaittinen , Rob Herring , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCHv3 13/14] power: supply: generic-adc-battery: improve error message Date: Fri, 17 Mar 2023 23:57:06 +0100 Message-Id: <20230317225707.1552512-14-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317225707.1552512-1-sre@kernel.org> References: <20230317225707.1552512-1-sre@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760658175786016468?= X-GMAIL-MSGID: =?utf-8?q?1760658175786016468?= Add device context and error code to the error messages to make it useful. Signed-off-by: Sebastian Reichel Reviewed-by: Linus Walleij Reviewed-by: Matti Vaittinen --- drivers/power/supply/generic-adc-battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/generic-adc-battery.c b/drivers/power/supply/generic-adc-battery.c index df1c0a1c6b52..2fa946c93fb4 100644 --- a/drivers/power/supply/generic-adc-battery.c +++ b/drivers/power/supply/generic-adc-battery.c @@ -92,7 +92,7 @@ static int read_channel(struct gab *adc_bat, enum gab_chan_type channel, ret = iio_read_channel_processed(adc_bat->channel[channel], result); if (ret < 0) - pr_err("read channel error\n"); + dev_err(&adc_bat->psy->dev, "read channel error: %d\n", ret); else *result *= 1000;