diff mbox series

tty: serial: remove obsolete config SERIAL_SAMSUNG_UARTS_4

Message ID 20230317071538.29366-1-lukas.bulwahn@gmail.com
State New
Headers
Series tty: serial: remove obsolete config SERIAL_SAMSUNG_UARTS_4 |

Commit Message

Lukas Bulwahn March 17, 2023, 7:15 a.m. UTC 
  Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"), allows
simplifying the whole config logic for SERIAL_SAMSUNG_UARTS, and did this
config simplification. However, it misses that SERIAL_SAMSUNG_UARTS_4's
effect was just to control SERIAL_SAMSUNG_UARTS, and with the commit's
change, the config SERIAL_SAMSUNG_UARTS_4 has no remaining effect and can
be deleted.

Remove this obsolete config SERIAL_SAMSUNG_UARTS_4.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Arnd, please ack.

Greg, please pick this minor clean-up patch.

 drivers/tty/serial/Kconfig | 7 -------
 1 file changed, 7 deletions(-)

Comments

Arnd Bergmann March 17, 2023, 7:56 a.m. UTC | #1 
On Fri, Mar 17, 2023, at 08:15, Lukas Bulwahn wrote:
> Commit 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"), allows
> simplifying the whole config logic for SERIAL_SAMSUNG_UARTS, and did this
> config simplification. However, it misses that SERIAL_SAMSUNG_UARTS_4's
> effect was just to control SERIAL_SAMSUNG_UARTS, and with the commit's
> change, the config SERIAL_SAMSUNG_UARTS_4 has no remaining effect and can
> be deleted.
>
> Remove this obsolete config SERIAL_SAMSUNG_UARTS_4.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Nice find!

I tried to carefully check that all Kconfig options that were
no longer selectable got removed recursively, along with the code
that they control, but I missed this one as I did not search
the other way.

Acked-by: Arnd Bergmann <arnd@arndb.de>
diff mbox series

Patch

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 0072892ca7fc..39a0078f54f6 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -248,13 +248,6 @@  config SERIAL_SAMSUNG
 
 	  Choose Y/M here only if you build for such SoC.
 
-config SERIAL_SAMSUNG_UARTS_4
-	bool
-	depends on SERIAL_SAMSUNG
-	default y
-	help
-	  Internal node for the common case of 4 Samsung compatible UARTs
-
 config SERIAL_SAMSUNG_UARTS
 	int
 	depends on SERIAL_SAMSUNG