From patchwork Thu Mar 16 17:54:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 70940 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp630743wrt; Thu, 16 Mar 2023 11:17:42 -0700 (PDT) X-Google-Smtp-Source: AK7set8jf6FwxOt5jqjZ+HU2IhToyDuHdLzx2d0vnQk32sy5dt8jW2Nl4r47R5bOI9yY3pnujCM8 X-Received: by 2002:a17:902:e2d1:b0:19d:1a99:88 with SMTP id l17-20020a170902e2d100b0019d1a990088mr3537835plc.20.1678990662167; Thu, 16 Mar 2023 11:17:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678990662; cv=none; d=google.com; s=arc-20160816; b=eHl/pqWcfQcJRkimO0dpdVnZzqxNsP0TAul18sKllmWkhBKsZDaJmnDm4TmClXcqTW 526mkWdmxaBYXAKIX+ltIAwFfy6Vak0W6jUy85/tUO2H8XKs5FD25nuToyX9AOxkdXv6 EvyPf2+7/RLL+i0HvM9BWHEAHw4ti5iGTQEkhg9M95R4zyOy8WC2fPRSybaDR9AAXfLL 12J8ffKh8RZwyUoYHqvKwp46TJQVQI6lVtvXinrQAqIE9Zt13f2Bs/XSUqgt2znIhVmK m4NW6lBjsBN35ZJNSCcqVGHGD6rwkrPJqXowBlMNcCkZ+G6vVyIjSx/KWg+X+Bny3C7Q X1Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=F7z8ruqVwWGO2iKV3hhmptNBwExUSsE13fwewhDsOi0=; b=YO+klM6Wgf+u31gXdUqlPCX++39Xoray9BQjW0TLEClSmgEroZ1H/7JEzOYfddJQVa JjSQgpU/YSXfGu4uNiZV4qWlhQ27XzCbY4+OU3b29kf/WMEo0GnQrMUu+2ltCU/dVwPr sp3Fxu/CauBx+N9Z69c0UfHb3dxUrUw3Lq4OLEZvUxXXSx51ChnzkAQquy5cgwm8cBS1 y15vu0fD+tLTD13Z9nuAEfX/eUCC4bchJZjJnLAVTRgYtsk2ibsRO0HD3OuRXZD0Slp8 1p6J/FYolX93PFktWu3aGV8L134ewpbRaDXpHR4fS0jswPF9vIIw6Y+r74C024r1cQNd 5AeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Y8rMFwHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ay9-20020a1709028b8900b0019ca7ed8931si25174plb.279.2023.03.16.11.17.29; Thu, 16 Mar 2023 11:17:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=Y8rMFwHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230064AbjCPRzo (ORCPT + 99 others); Thu, 16 Mar 2023 13:55:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230286AbjCPRzc (ORCPT ); Thu, 16 Mar 2023 13:55:32 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3635A132D3; Thu, 16 Mar 2023 10:55:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=F7z8r uqVwWGO2iKV3hhmptNBwExUSsE13fwewhDsOi0=; b=Y8rMFwHvwAoKI2U6Wmm2s Sofn1IdhK1o+vH7JYbyAwfPaqJJf0bpG7/UFWjjMtaMuoc4NiOEexv0zyEGrTkLi dP+4Nh/MqJIXU+NhhGAZ6eiCZZ88FXGT4z6gxSY9egbGsjiT2v/17xwiWSEkS2JQ JH+KI0esBMpy3/5Ay56cTg= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g5-2 (Coremail) with SMTP id _____wCnT_zyVxNkdZsdAQ--.63001S2; Fri, 17 Mar 2023 01:54:58 +0800 (CST) From: Zheng Wang To: gregkh@linuxfoundation.org Cc: p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com, phil.edworthy@renesas.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, yoshihiro.shimoda.uh@renesas.com, Zheng Wang Subject: [PATCH v6] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition Date: Fri, 17 Mar 2023 01:54:57 +0800 Message-Id: <20230316175457.1595921-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wCnT_zyVxNkdZsdAQ--.63001S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Zr45Xr15Jr4rCF4UXr4DXFb_yoW8Cr4kpF WDKFW5Ar4rJFWqq3y7GFykZF1rCasrKry7ZFW7Kw4xuF1rW3y8JryIqF4jkFnrJFZ3AF4F qa1Du34jqa47u37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zic4S7UUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiQho0U1aEEsHXzAAAsl X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760549140354915770?= X-GMAIL-MSGID: =?utf-8?q?1760549312986012025?= In renesas_usb3_probe, role_work is bound with renesas_usb3_role_work. renesas_usb3_start will be called to start the work. If we remove the driver which will call usbhs_remove, there may be an unfinished work. The possible sequence is as follows: Fix it by canceling the work before cleanup in the renesas_usb3_remove. Note that removing a driver is a root-only operation, and should never happen. CPU0 CPU1 | renesas_usb3_role_work renesas_usb3_remove | usb_role_switch_unregister| device_unregister | kfree(sw) | free usb3->role_sw | | usb_role_switch_set_role | //use usb3->role_sw Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch") Signed-off-by: Zheng Wang Reviewed-by: Yoshihiro Shimoda --- v6: - beautify the format and add note suggested by Greg KH v5: - fix typo v4: - add Reviewed-by label and resubmit v4 suggested by Greg KH v3: - modify the commit message to make it clearer suggested by Yoshihiro Shimoda v2: - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index bee6bceafc4f..a301af66bd91 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev) debugfs_remove_recursive(usb3->dentry); device_remove_file(&pdev->dev, &dev_attr_role); + cancel_work_sync(&usb3->role_work); usb_role_switch_unregister(usb3->role_sw); usb_del_gadget_udc(&usb3->gadget);