From patchwork Thu Mar 16 17:48:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 70927 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp618369wrt; Thu, 16 Mar 2023 10:52:18 -0700 (PDT) X-Google-Smtp-Source: AK7set+/6EMBUzh4/En3TgYCRuElTjXQlKhPR5UHv3l4CTFqwflIB/mVrxQW9rnZtRIgF9wxngWA X-Received: by 2002:a17:903:1ca:b0:19e:bfec:7928 with SMTP id e10-20020a17090301ca00b0019ebfec7928mr5487968plh.24.1678989138392; Thu, 16 Mar 2023 10:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678989138; cv=none; d=google.com; s=arc-20160816; b=bJkb2uyRpDy3vL3UjqzbWfN9fNiQ2W3QHNiyoUkeNVAk2oLa3rTajhT54sGYSGznoV woVIaUAuTope22/hACQXoo5olqVWCszTfB/QV3V99Cpom31U45Gl3vBWRXaRXiMpha4H 9kd94W3arXDh9YkPCdJzASjCu140N5VBHn7vgSz1KzKiqLDh4eIF+f3wL0wCTOyWL15T LdnxZ0z4nf3gBsMJAtsYvfAwH0dDUbAjhFddoOp6c1BReYXp+WYoHbio+dSDbEOMlBX8 eOJjG/97RYuE5xzR2JtJ945FeAjbXRtg8gPo6cx1/PMTqyFj9P9Gtoh2hUryv1oAgaTW Y9Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nEAMnAlTlhmBc3GQSHDUq/SQ1R/Wav9t7BfHo/zL+ZI=; b=LB1MNk+YOmnTRuYuw9GsNn1ok1qEAbf90zemctNtxORV72Bqo0BFg0VPbKZdifAKEW G7Dyl0M8gWdTDPzI7lBuJto1kiPAaIhlG1T0sUUemQw1nE0lqtVX+pFd9u47XKJoaZjZ 8LoisGxo1YtFhtNQBoS8A42Z9kfesVbGqEITRfgszCmeFLR4N/2hQPsBxpgIQUuyVtTp FMRYLzs1uthxtkYdmJmlJpe9DlM82ZwkGb6HuJPU51oWsfylJ7BjrtEZQLN6SYU+nsd9 ba++/EGWQEOq40s6biSpyIDtt92NOg44NIjLBso6Wd4NwQMfhzZsWV3Yo5g6hD9HGd+X lAxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=kFQb4+KZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f5-20020a170902ce8500b0019e8c3cd415si9541938plg.260.2023.03.16.10.51.16; Thu, 16 Mar 2023 10:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=kFQb4+KZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjCPRsr (ORCPT + 99 others); Thu, 16 Mar 2023 13:48:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230107AbjCPRso (ORCPT ); Thu, 16 Mar 2023 13:48:44 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9068F6F4AC; Thu, 16 Mar 2023 10:48:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=nEAMn AlTlhmBc3GQSHDUq/SQ1R/Wav9t7BfHo/zL+ZI=; b=kFQb4+KZ4yjfok7VWHGT/ r2FnzTJMcN3+jiIMsKs5gej5yxzBiJi0JNk2J5ASyv1A7fXOGux9glugkK5O0X2v 6eF7G4pnfSLSSBG/bS8kqnR8Ahphe3fu7X5oZ5ySWxlvI5abOpATF/pYaqMBq29T 7BU1MouBKdYC/Jej5E6sDU= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-3 (Coremail) with SMTP id _____wDXJldjVhNkdFzYAA--.63147S2; Fri, 17 Mar 2023 01:48:19 +0800 (CST) From: Zheng Wang To: valentina.manea.m@gmail.com Cc: shuah@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH RESEND] usbip: vudc: Fix use after free bug in vudc_remove due to race condition Date: Fri, 17 Mar 2023 01:48:18 +0800 Message-Id: <20230316174818.1593588-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wDXJldjVhNkdFzYAA--.63147S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtF1UGFy5Jw45ZF18GrWkXrb_yoWkXwc_ua 4ruF4xGF4rCanxKF17XwnxZrWUKFyDXrn3XFs29F4fWa4xGr15Zw17Ars7uF47uF98GFyD Cws8t395Zw47ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKApntUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/xtbBzgo0U2I0XqssLwAAsD X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760547714473855025?= X-GMAIL-MSGID: =?utf-8?q?1760547714473855025?= In vudc_probe, it calls init_vudc_hw, which bound &udc->timer with v_timer. When it calls usbip_sockfd_store, it will call v_start_timer to start the timer work. When we call vudc_remove to remove the driver, theremay be a sequence as follows: Fix it by shutdown the timer work before cleanup in vudc_remove. Note that removing a driver is a root-only operation, and should never happen. CPU0 CPU1 |v_timer vudc_remove | kfree(udc); | //free shost | |udc->gadget |//use Fixes: b6a0ca111867 ("usbip: vudc: Add UDC specific ops") Signed-off-by: Zheng Wang --- drivers/usb/usbip/vudc_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c index 2bc428f2e261..33d0991755bb 100644 --- a/drivers/usb/usbip/vudc_dev.c +++ b/drivers/usb/usbip/vudc_dev.c @@ -633,6 +633,7 @@ int vudc_remove(struct platform_device *pdev) { struct vudc *udc = platform_get_drvdata(pdev); + timer_shutdown_sync(&udc->timer); usb_del_gadget_udc(&udc->gadget); cleanup_vudc_hw(udc); kfree(udc);