From patchwork Thu Mar 16 17:29:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Latypov X-Patchwork-Id: 70929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp618373wrt; Thu, 16 Mar 2023 10:52:18 -0700 (PDT) X-Google-Smtp-Source: AK7set9oeF13fcN1PUaW3AGabbseLE7ex4t7UBoKxQGhiHUq9uNkMY45GInvs2eWcMKmvNVkQ9GL X-Received: by 2002:a62:7bc7:0:b0:625:5769:aee2 with SMTP id w190-20020a627bc7000000b006255769aee2mr3426120pfc.5.1678989138393; Thu, 16 Mar 2023 10:52:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678989138; cv=none; d=google.com; s=arc-20160816; b=asUyligMO0LswoLINAmwqSYBQY1k4jarIJJfpP1yztofT71BX+m9xCYxrQww1vocxw p7TSLq5+24dQrAy7c0DAkIVBeujt6i4NVeeYDUOBKa0WPHhEoiqXRmh2Sa6q0uQuBMnn y5Cgs+RDbeBuDArjrDdQRdu0Mt3GEoaX3X4CDpkiX01yuDxGPWnNWqE913a9LxD0bhIH RMu7ZuQwdCt3Opond934LTJNEc3yt3QZRj9n+eRenekmt3KK+qIdFR3usUpJA+wYBBpL EL6URd0blRkT8FMzvzZcDdACcWVV5mg25YD5URNm/nvPfTwLPuh/D/38JW4mmtjEz5iC HloQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=87tojeD1hl3r+GUx070hYtMF9ILSs5cMERcPTVCxRuM=; b=hPL9X0SpJ/kEKxqaCBN844AfgYz7P0HDd2LeF/SD26KAEZ4LLfQOZ8wgV/jKew6DqO FpyBajbn+F+ejQ8r9i9LwAD4WMW6Ox4IFYPp5m6k3X3wt/Qz69eqt8fEH8APsWHHvsvS LU6BNm1MejK5SB8bOxUwubD/ySVRzfQWmG58RPd4CsDVyBX6LVT53O2Qc49EfH8vjEuD DjLiFuNRUXzi/5Kp7MMxAx2dOTYej5KJLYzDcvO4e3E4WuqIc1Ny09pWg+wkk9RpR1mV 1y+lUN+qOlsqbKB1FAeK7GDiY4vv0ll9s3a/BGB8Pt1OyYjRazrcEv9mjn5WoiXXuj9N UaFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=aHMVxJZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fd13-20020a056a002e8d00b005e268568420si41704pfb.23.2023.03.16.10.50.58; Thu, 16 Mar 2023 10:52:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=aHMVxJZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229667AbjCPRaJ (ORCPT + 99 others); Thu, 16 Mar 2023 13:30:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230030AbjCPR3d (ORCPT ); Thu, 16 Mar 2023 13:29:33 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 347E8B9504 for ; Thu, 16 Mar 2023 10:29:17 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-54352648c1eso22119757b3.9 for ; Thu, 16 Mar 2023 10:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678987756; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=87tojeD1hl3r+GUx070hYtMF9ILSs5cMERcPTVCxRuM=; b=aHMVxJZD2DW3iFMk6TmL8oBPJAFeqAikJ4nTGDGRFnxxnqtQ2GJIdXs09G+X/4WzVH EolIwi5v7QX2Y2F9FeJ972W7TwgchD6Xj4y3HGumhDSsCXdiTvLSAHiorOvEJjtiAa/U 7jPrnf1uCOQCsBELMESaTVnDcmQMKrql2XeIm2aj6w2vX/Ntg+SZu+STY9W67b9pdnP/ AqtBEKNtp+ind7FoI0zwmkeGyrme8GZVsWqjDfHM2ZNog29h01pP44BNCJuKjao5Ex5l JLiBy7IJw694s7thTru85RTcdkWn1Ms2+WaTBffoQXZPOfKM6HGfsdxVm9u3t8EfRrrh QH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678987756; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=87tojeD1hl3r+GUx070hYtMF9ILSs5cMERcPTVCxRuM=; b=g2pDJy5UQxHUnFvvsgAdUN9FcFLokOMEF93KjQMMjjzZ8LmEAnuyyca8VOPy5QUaDw cxhliiW4nU5TrLpKqXI/eGvjlyizmKWbmXtc78jgIDnRfpdC69ONItqekUrDrrSnVhgi KxmmlI6HJyGivRocu2IH92dSxaQnbhVmF/mm2C6uBk6de1BowtfPNhFYKcwxqdbm4vUY HVO7896UfduhIRU8QeTkUzBo9wiPA46GR/bGIehIlJLyptd8ixJ9WARbaQ4AUYwqtUB0 I73O7gGrH9XyjU/uNV5hY2DUI7XlM2xfcDyucRBBWJO9nKjIbJBQoTvQxh5Q3JL74lQe HVBw== X-Gm-Message-State: AO0yUKVlEyULhZfyiJ/Muo2Zd+wo2enGjzfkdo8xmW5+m/qvSiZW6KPE qbHOmxIJAUFopK2mcMVOPouamGfm4lMY6Q== X-Received: from dlatypov-spec.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3f35]) (user=dlatypov job=sendgmr) by 2002:a81:ae22:0:b0:541:69f4:f927 with SMTP id m34-20020a81ae22000000b0054169f4f927mr2725264ywh.8.1678987756364; Thu, 16 Mar 2023 10:29:16 -0700 (PDT) Date: Thu, 16 Mar 2023 10:29:00 -0700 In-Reply-To: <20230316172900.755430-1-dlatypov@google.com> Mime-Version: 1.0 References: <20230316172900.755430-1-dlatypov@google.com> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog Message-ID: <20230316172900.755430-2-dlatypov@google.com> Subject: [PATCH 2/2] kunit: tool: remove unused imports and variables From: Daniel Latypov To: brendanhiggins@google.com, davidgow@google.com Cc: rmoar@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org, Daniel Latypov X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760547714511860699?= X-GMAIL-MSGID: =?utf-8?q?1760547714511860699?= We don't run a linter regularly over kunit.py code (the default settings on most don't like kernel style, e.g. tabs) so some of these imports didn't get removed when they stopped being used. Signed-off-by: Daniel Latypov --- tools/testing/kunit/kunit.py | 2 +- tools/testing/kunit/kunit_config.py | 2 +- tools/testing/kunit/kunit_kernel.py | 1 - tools/testing/kunit/kunit_parser.py | 1 - tools/testing/kunit/kunit_tool_test.py | 2 +- 5 files changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py index 741f15420467..52853634ba23 100755 --- a/tools/testing/kunit/kunit.py +++ b/tools/testing/kunit/kunit.py @@ -123,7 +123,7 @@ def _suites_from_test_list(tests: List[str]) -> List[str]: parts = t.split('.', maxsplit=2) if len(parts) != 2: raise ValueError(f'internal KUnit error, test name should be of the form ".", got "{t}"') - suite, case = parts + suite, _ = parts if not suites or suites[-1] != suite: suites.append(suite) return suites diff --git a/tools/testing/kunit/kunit_config.py b/tools/testing/kunit/kunit_config.py index 48b5f34b2e5d..9f76d7b89617 100644 --- a/tools/testing/kunit/kunit_config.py +++ b/tools/testing/kunit/kunit_config.py @@ -8,7 +8,7 @@ from dataclasses import dataclass import re -from typing import Dict, Iterable, List, Set, Tuple +from typing import Dict, Iterable, List, Tuple CONFIG_IS_NOT_SET_PATTERN = r'^# CONFIG_(\w+) is not set$' CONFIG_PATTERN = r'^CONFIG_(\w+)=(\S+|".*")$' diff --git a/tools/testing/kunit/kunit_kernel.py b/tools/testing/kunit/kunit_kernel.py index e6fc8fcb071a..775842b912d8 100644 --- a/tools/testing/kunit/kunit_kernel.py +++ b/tools/testing/kunit/kunit_kernel.py @@ -18,7 +18,6 @@ import threading from typing import Iterator, List, Optional, Tuple import kunit_config -from kunit_printer import stdout import qemu_config KCONFIG_PATH = '.config' diff --git a/tools/testing/kunit/kunit_parser.py b/tools/testing/kunit/kunit_parser.py index a225799f6b1b..fbc094f0567e 100644 --- a/tools/testing/kunit/kunit_parser.py +++ b/tools/testing/kunit/kunit_parser.py @@ -12,7 +12,6 @@ from __future__ import annotations from dataclasses import dataclass import re -import sys import textwrap from enum import Enum, auto diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index 0c2190514103..be35999bb84f 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -328,7 +328,7 @@ class KUnitParserTest(unittest.TestCase): def test_parse_subtest_header(self): ktap_log = test_data_path('test_parse_subtest_header.log') with open(ktap_log) as file: - result = kunit_parser.parse_run_tests(file.readlines()) + kunit_parser.parse_run_tests(file.readlines()) self.print_mock.assert_any_call(StrContains('suite (1 subtest)')) def test_show_test_output_on_failure(self):