From patchwork Thu Mar 16 16:05:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 70895 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp580410wrt; Thu, 16 Mar 2023 09:31:49 -0700 (PDT) X-Google-Smtp-Source: AK7set+I7lqRmqBxJiNN27+grcekjmeoq87KbIZ42PyUoqUU9cpDAcw/Rf1jOng8JwRc6qpYhGdk X-Received: by 2002:a81:7bd4:0:b0:537:25:ffb7 with SMTP id w203-20020a817bd4000000b005370025ffb7mr3399642ywc.31.1678984308753; Thu, 16 Mar 2023 09:31:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678984308; cv=none; d=google.com; s=arc-20160816; b=IOdXWXIQtyghFW+UxVqeMhLAenAkem3Zj4hlpxHs25xdMjrix3kq0E74t1V4Gp27iA SBWVyzWFDZQVIJGkR/RZHJ2gNuZ16F9aQ4S0r/Nz7OmI63AU9/U5oB0ex/zFxThkTjPY TdxYhsAuYSi4Bp1MSFN2/YcAhWpw7/L46NuwfNlwLCBUBP8WSm6A7u0gM34XooyveV96 s2wPcppV63Y/ZjbJf+fiB4JUp0kgnO0KBiu2HQ3qnaaSt0yr7l05kHDMVSlD5xCHVAMz Dv6BS7WczWLoAO22/nfB4y9TkjLyO3cS1C+Ibudi/VkfsNh7CMMkrwygGKyRJYE7Zb29 RJBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kRZV+8Q/emx5bHidIKO6PtLhBxtpwJPSftAEhgOkuYk=; b=ufb1GJDgip8g+A4y1KsvRcSnPkJWByHi3pLBcM62fytzm9pARJAkZxYx/Kn+aRM58p Vc+uNyAuRpPGIEFmAyTCWBK5DuNnqbnrOaTm8PQJX+SKINNq+v1abJRpHd4VR6y+wc/d IuVw4Ar4uMZNCA9rjE+EpjQbNOd1trB9lAKgGBLs47P7xYsxFWxo2CZvUr7S1bcLjgZC k7pMZ9CYX9uTtPs1t5VtnpTKfLSI2PfL8QRVlEZdolxY2NCjN8lGvMeV3GexOb2lb3WX eW+3wlUrmvw3XcC0+nXY+YzM5F2akfL07UsiQG8exp3MMGt+g8yXQ1+lmS3OKuZTyZNG A0Sg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=NVzX9q+f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k6-20020a0dc806000000b00543ac519405si7122134ywd.257.2023.03.16.09.31.34; Thu, 16 Mar 2023 09:31:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=NVzX9q+f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbjCPQG7 (ORCPT + 99 others); Thu, 16 Mar 2023 12:06:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbjCPQG5 (ORCPT ); Thu, 16 Mar 2023 12:06:57 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 141D6B1A73 for ; Thu, 16 Mar 2023 09:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=kRZV+ 8Q/emx5bHidIKO6PtLhBxtpwJPSftAEhgOkuYk=; b=NVzX9q+f0YmZlVAGydm1J zBGA5qBvFyOomt8UAtUkhW2xqZ9+uc6Ir5bvl4z5Ie3VqKRS26ZhN+76A5lTSm9G d+kjo3iuPwcZXvyk7eXYuAMbVaWYBOcWbqrO42hZyhN9rdkOh1IgtD+uo6TbsSCF 4oxpMU6C4hFDu/qWOvDsc0= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-1 (Coremail) with SMTP id _____wDHi0FdPhNkuGIYAQ--.38781S2; Fri, 17 Mar 2023 00:05:49 +0800 (CST) From: Zheng Wang To: dri-devel@lists.freedesktop.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, jonas@kwiboo.se, airlied@gmail.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH v3] drm/bridge: adv7511: fix race condition bug in adv7511_remove due to unfinished work Date: Fri, 17 Mar 2023 00:05:48 +0800 Message-Id: <20230316160548.1566989-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wDHi0FdPhNkuGIYAQ--.38781S2 X-Coremail-Antispam: 1Uf129KBjvJXoWrtr18Xr4rGw4ktrW3Ww1UGFg_yoW8Jr4Upa 13uF98CrWUXFnrKayDAF1fta4rAwsrJF1F9a9ruwnavr1UXFyUArZ0yFyYyry7WFWxX3W3 tr1UtFykWrnxAaUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zicyCZUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/xtbBzgM0U2I0XqqgGAAAsw X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760541580755814490?= X-GMAIL-MSGID: =?utf-8?q?1760542650311072808?= In adv7511_probe, adv7511->hpd_work is bound with adv7511_hpd_work. If we call adv7511_remove with a unfinished work. There may be a race condition where bridge->hpd_mutex was destroyed by drm_bridge_remove and used in adv7511_hpd_work in drm_bridge_hpd_notify. Fix it by canceling the work before cleanup in adv7511_remove. Fixes: 518cb7057a59 ("drm/bridge: adv7511: Use work_struct to defer hotplug handing to out of irq context") Signed-off-by: Zheng Wang --- v3: - add patch modification information v2: - add Fix label --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ddceafa7b637..9bf72dd6c1d3 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1349,6 +1349,7 @@ static void adv7511_remove(struct i2c_client *i2c) { struct adv7511 *adv7511 = i2c_get_clientdata(i2c); + cancel_work_sync(&adv7511->hpd_work); adv7511_uninit_regulators(adv7511); drm_bridge_remove(&adv7511->bridge);