From patchwork Thu Mar 16 16:04:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 70889 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp571969wrt; Thu, 16 Mar 2023 09:14:48 -0700 (PDT) X-Google-Smtp-Source: AK7set9Tof4c2NoptdZeLSBXZlr6r34Ge2vXqyOauhwKusY5D9XVonMaZulk7LulV71Dfu4zrjwP X-Received: by 2002:a05:6870:898f:b0:177:8cf4:33 with SMTP id f15-20020a056870898f00b001778cf40033mr13287245oaq.52.1678983288354; Thu, 16 Mar 2023 09:14:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678983288; cv=none; d=google.com; s=arc-20160816; b=rayUH7id1jR3o0zZ9mqRs6VOvnnF3yAt6jcUzy7CaaLSiM2gc9YUfh0hSNviXqYYjl 19XNR3evUJj9hV20D5JcXCF67oMt89GoypGFwheeg9vpazrJpsqyAc09QrPB5ZhbFyIY i6C1ooj47cnZpseIqsRiTTXVJhESdFkxK2vDxdcuITCxysMr1xrb4y4/zzAghMQyN9aq R4flIIDuA9GubJ1HF5V/bpUX5RW6rd49fQpwIjc6EQhkWpcswaihhKuHCb2ME5nRScKC gHM3siSvF5pPmXytRxZR12nocIe7ALNxjry1EpTGrHiNmKzrzb9PSb6Ydo4WYHQk+3v2 o80w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BpTc3Eb2o/NHHOlitSSzCEg5Jn4GYMsWpzIaxLSPuA8=; b=e9gGE7TLsqdVAVQF2uWAx2+aVx7uSzj09fDQfnofLsioxVR6XjCaLEmnf5iIyXx+d3 hoaLvAJ8YwCNiPfK5jLau4tIbzr0PWLQjD+QtW3Jkxrb/3FKkIUZw3zVbIc0aftfEnN+ R4VnWNZb4bZKPFYV9tY66gtPMLi28gpCKrBIDNlBzqZQ2YhnvJpDO/k1E5zeM6m8sYqW rkR3vbRLiiaG3oulV1AP5MowZN0ax6v8aX5sfvw/BtYLL50uLL6hIcgd2QF3v6zYPHCP iBrRMNZ6Nd8EyvEMsP8F6LxzYOmqlDYi6SLxCQjIvQPyV2s7ellN7kB4ELLTC6bZU6Vl mdVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="WNSp/H78"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di11-20020a0568303a0b00b0068bc02503basi7233109otb.340.2023.03.16.09.14.35; Thu, 16 Mar 2023 09:14:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b="WNSp/H78"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbjCPQGv (ORCPT + 99 others); Thu, 16 Mar 2023 12:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjCPQGt (ORCPT ); Thu, 16 Mar 2023 12:06:49 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 08F27A7A9B for ; Thu, 16 Mar 2023 09:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=BpTc3 Eb2o/NHHOlitSSzCEg5Jn4GYMsWpzIaxLSPuA8=; b=WNSp/H78L+tWzguIm83oX mBX4Bxg10MzcV/0giyIZdPlwvlVRNYPG8Fm7vfAEdE3T/9vGAzRLjdB/QCZgf/OV 9ESXfJOvA/OTTl0e8QJE9JaHjHYNiKy74MX4wlkdvD6sWjFNB2nFSRT902t4DVCg pIaD1jYHI0/IHcWxSHxvlk= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g3-3 (Coremail) with SMTP id _____wBnKqD0PRNkKSvSAA--.48535S2; Fri, 17 Mar 2023 00:04:04 +0800 (CST) From: Zheng Wang To: dri-devel@lists.freedesktop.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, jonas@kwiboo.se, airlied@gmail.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH v2] drm/bridge: adv7511: fix race condition bug in adv7511_remove due to unfinished work Date: Fri, 17 Mar 2023 00:04:02 +0800 Message-Id: <20230316160402.1566483-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wBnKqD0PRNkKSvSAA--.48535S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr18Xr4rGw4ktrW3Ww1UGFg_yoWkCFXEkF yfZ34xWr15A3Wv9w17AFZFvrW7K3WUCrZa93WfKa9xJr43Zr1xW347XryDXF1ruF4YyFyD JrnrZw4rAa42kjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKYFCUUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiXRo0U1WBo8MtCQAAsw X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760541580755814490?= X-GMAIL-MSGID: =?utf-8?q?1760541580755814490?= In adv7511_probe, adv7511->hpd_work is bound with adv7511_hpd_work. If we call adv7511_remove with a unfinished work. There may be a race condition where bridge->hpd_mutex was destroyed by drm_bridge_remove and used in adv7511_hpd_work in drm_bridge_hpd_notify. Fix it by canceling the work before cleanup in adv7511_remove. Fixes: 518cb7057a59 ("drm/bridge: adv7511: Use work_struct to defer hotplug handing to out of irq context") Signed-off-by: Zheng Wang --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ddceafa7b637..9bf72dd6c1d3 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1349,6 +1349,7 @@ static void adv7511_remove(struct i2c_client *i2c) { struct adv7511 *adv7511 = i2c_get_clientdata(i2c); + cancel_work_sync(&adv7511->hpd_work); adv7511_uninit_regulators(adv7511); drm_bridge_remove(&adv7511->bridge);