From patchwork Thu Mar 16 15:55:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 70892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp578503wrt; Thu, 16 Mar 2023 09:27:59 -0700 (PDT) X-Google-Smtp-Source: AK7set97zikctOLvJQqT4IQgbwqey7Cp0VY3PZdCqaEtFCvGRQO1Q7+mVEyruaqmcnlRTSNv/fal X-Received: by 2002:a17:90a:1950:b0:234:d78:9b4c with SMTP id 16-20020a17090a195000b002340d789b4cmr4460869pjh.18.1678984079484; Thu, 16 Mar 2023 09:27:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678984079; cv=none; d=google.com; s=arc-20160816; b=Z0xw+UdCbKkPCNuAkOrVmJ774EW7HQKPL/3OimUpxQZ9dWUE56UquwNsLin3DIVF28 pgR9ZMkG4PzAjNj1eWK47JmSut90Olmkz4+ajijPhXOywzGD5KquMM4ZH8n2AqYpRAJ6 2t+f7vCukJ9uMmHZFImJs6HLfDlC75rq+lgmF30WoyJcVjpqU6JzURWst4i7FiEz01aD HnvyFlFEpNw0+tQ+6lV3prH+uwiEDThC0t1rxbMYKMxDlxz6y+OeGWYg6Gx8nNubzKpH pOU8K7CZ6sHVMO13Z31qW3l4Eq00fGz5vNRjzO/LoNkjUWF6cphzUIOL3ZWEB4Xa3wI9 5g7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XxqVPaMaesg3WKkTgax8wepxeqRRyKUw6FM6YPKmWUA=; b=bQeOhUbZ/ngYENUgz0ZY6myPwxT1kLybtTVM/lqohs3ioIg6XEwKNl4mx2T0kFIyiC iTfr5rv6pN2YyTYTR54IEal5JhRePWrjRcf/DmL5n5k7YYoJ70aP1uxpHuPJ1wMnZVbC i5OOaInjbK5ASlVtyv+1QuFeWuAl2DUFw2UpB+Ej91g0ciMAdKoz3qArLI1/cqze3tbN E4JHtjOziGcivhL8/JG4J4CaISzFGRpiDObAaEY997KO/KxEJtszt/zTjJ6JYGOy5F83 mJ6I7kryPtNiHhxMgPrxWTm4TRDYoJJf7OrtniOw0r6wy/ZlKDrC9oyflAcPM3ShG8uq Msrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=KfCO3cFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t4-20020a17090aba8400b0023f0955f301si4091421pjr.166.2023.03.16.09.27.44; Thu, 16 Mar 2023 09:27:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=KfCO3cFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231518AbjCPPzz (ORCPT + 99 others); Thu, 16 Mar 2023 11:55:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231163AbjCPPzy (ORCPT ); Thu, 16 Mar 2023 11:55:54 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.196]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1508C34C31; Thu, 16 Mar 2023 08:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=XxqVP aMaesg3WKkTgax8wepxeqRRyKUw6FM6YPKmWUA=; b=KfCO3cFVY0ne3STL3Tbqe cyuuuvhGRR9BbJnbgW8hjq57QYNBv6l7MJ46adrUHvRvePFpPF4tVsutl7DrTzO1 PeTGhIxUdxu0neArJD0zAdXXIYle5Pa7CWfHZu4QMJ9gS51wWrVlPTRpbK+cWXEe CpaFy8ttV8JucvNqTEpHCo= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g4-4 (Coremail) with SMTP id _____wC3vsbiOxNkJ7PVAA--.51531S2; Thu, 16 Mar 2023 23:55:15 +0800 (CST) From: Zheng Wang To: gregkh@linuxfoundation.org Cc: p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com, phil.edworthy@renesas.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, yoshihiro.shimoda.uh@renesas.com, Zheng Wang Subject: [PATCH v4] usb: gadget: udc: renesas_usb3: Fix use after free bug in renesas_usb3_remove due to race condition Date: Thu, 16 Mar 2023 23:55:13 +0800 Message-Id: <20230316155513.1564746-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wC3vsbiOxNkJ7PVAA--.51531S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tF1DGryfJr47ArWxZFyDAwb_yoW8AFy5pF WUGFW5Ar4rJFWqq3y7GFykZF1rCF9rKry7ZFW7tw4xuF1rG3y8tryIqa1jkF1xJFZYyF4F q3WDu340qa47u37anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zi-eOJUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiGgc0U1aEEmZOSwAAsZ X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760540907120953412?= X-GMAIL-MSGID: =?utf-8?q?1760542410316853911?= In renesas_usb3_probe, &usb3->role_work is bound with renesas_usb3_role_work. renesas_usb3_start will be called to start the work. If we remove the driver which will call usbhs_remove, there may be an unfinished work. The possible sequence is as follows: Fix it by canceling the work before cleanup in the renesas_usb3_remove CPU0 CPU1 |renesas_usb3_role_work renesas_usb3_remove | usb_role_switch_unregister | device_unregister | kfree(sw) | free usb3->role_sw | | usb_role_switch_set_role | //use usb3->role_sw Fixes: 39facfa01c9f ("usb: gadget: udc: renesas_usb3: Add register of usb role switch") Reviewed-by: Yoshihiro Shimoda Signed-off-by: Zheng Wang Reviewed-by: Yoshihiro Shimoda --- v4: - and Reviewed-by label and resubmit v4 suggested by Greg KH v3: - modify the commit message to make it clearer suggested by Yoshihiro Shimoda v2: - fix typo, use clearer commit message and only cancel the UAF-related work suggested by Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index bee6bceafc4f..a301af66bd91 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2661,6 +2661,7 @@ static int renesas_usb3_remove(struct platform_device *pdev) debugfs_remove_recursive(usb3->dentry); device_remove_file(&pdev->dev, &dev_attr_role); + cancel_work_sync(&usb3->role_work); usb_role_switch_unregister(usb3->role_sw); usb_del_gadget_udc(&usb3->gadget);