From patchwork Thu Mar 16 13:15:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Neukum X-Patchwork-Id: 70784 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp479747wrt; Thu, 16 Mar 2023 06:23:34 -0700 (PDT) X-Google-Smtp-Source: AK7set/1xPLoVhAeZgY+htRlhDt+E4i6DmAHdHbDVYlfc5NvxL33bqjvQh8E0f0NhLmITTJXtDai X-Received: by 2002:a05:6a20:8e0c:b0:d4:9fce:6c6a with SMTP id y12-20020a056a208e0c00b000d49fce6c6amr4498326pzj.49.1678973014323; Thu, 16 Mar 2023 06:23:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678973014; cv=none; d=google.com; s=arc-20160816; b=RBa7GvmS96EJuwBfLY7IiU1bmcq5p76bFrJc2bZxHuiTSY8CxCqBEibpXWooyN9wQ6 A9O8yXEeuQoNuVHLaEGcCMnSKmTVRHBWAFFF5yHilHwMuzaHYIXCCoZC7dV3OozV1uQu X8dIUQl+55xGLR7JtTgjNgFrslhlbebBn/wXcQtQX+7JeElWnA70MREHbTapyyh9qiUo tX4ogpyDpGrn5MDfp73yg74eCx6HJdDirnwVxCoddHOUPfq4yhlren0S2x29wWhGUk1R 57vPEeD5H3huw4gYN1PUkM7OABlh4THNLg7EbKVe/uoHLWhcldJmhOWkCg42g0JQ6rty MVaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kHLikiOj78KpDaSRuFeAp2LYuAcgKq6uGmUiwSMAIm8=; b=HWaCtGByx6/9ga5UdLCRotFAw8+jwYp3/VJf4SxF+WFCRq5ZWknSZ7sHKfA52wOIFC GnzFDBuI/3dhGQGQOVgoJMyxqXNOo450GaHWZsRpBq730e+ks1EUoYfIbOuc1X/SiI+C 9OKLiJS6z34vjN6ULzT1IMut//qEjbRMkhkRMIsh6cvi/ekZkIAJBwSu/pkYRJPko1Uj 1UDGmt0ox5U2PwCTDteZnm56G7RBiDD6qEi/dpSTiBVbFE2JaGoJulWgxpu7JcusHgMn R2n5qvOmLtVEw+moklqASwII03xrMN5RLX/dbnOX7DX+Rn9XCNafnI9SIQZLEJfAHxOh CrpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=BeXr7Qys; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a62520e000000b00623b50eb7d0si7380437pfb.214.2023.03.16.06.23.21; Thu, 16 Mar 2023 06:23:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=BeXr7Qys; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229459AbjCPNPU (ORCPT + 99 others); Thu, 16 Mar 2023 09:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229904AbjCPNPR (ORCPT ); Thu, 16 Mar 2023 09:15:17 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0A3B8570; Thu, 16 Mar 2023 06:15:12 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2F9D41FE03; Thu, 16 Mar 2023 13:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1678972511; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kHLikiOj78KpDaSRuFeAp2LYuAcgKq6uGmUiwSMAIm8=; b=BeXr7QysMw8BmjVaU4Kszk+vYNFQT3TVNmhgUenHWOsLh51L7x5VTSXKDzQ++KRPxY4Oj/ GTUQPUZfbn0D7RLoq+wLVeCt/HSwxh0tbZuxdd9CUNYMsX5r7Pi3rgv8EYdMieGVWCJVPN LRE/Al2HiYo7Bprt//F0sifXqU23X0E= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D85A913A2F; Thu, 16 Mar 2023 13:15:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EHvvMl4WE2QGQQAAMHmgww (envelope-from ); Thu, 16 Mar 2023 13:15:10 +0000 From: Oliver Neukum To: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Oliver Neukum Subject: [PATCH] usbtv: usbtv_set_regs: the pipe is output Date: Thu, 16 Mar 2023 14:15:07 +0100 Message-Id: <20230316131507.26748-1-oneukum@suse.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760530807288573588?= X-GMAIL-MSGID: =?utf-8?q?1760530807288573588?= We are setting a value. That is output and the pipe has to match that. Signed-off-by: Oliver Neukum --- drivers/media/usb/usbtv/usbtv-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/usbtv/usbtv-core.c b/drivers/media/usb/usbtv/usbtv-core.c index 2308c0b4f5e7..1f7620cd2996 100644 --- a/drivers/media/usb/usbtv/usbtv-core.c +++ b/drivers/media/usb/usbtv/usbtv-core.c @@ -47,7 +47,7 @@ int usbtv_set_regs(struct usbtv *usbtv, const u16 regs[][2], int size) { int ret; - int pipe = usb_rcvctrlpipe(usbtv->udev, 0); + int pipe = usb_sndctrlpipe(usbtv->udev, 0); int i; for (i = 0; i < size; i++) {