diff mbox series

kunit: Use gfp in kunit_alloc_resource() kernel-doc

Message ID 20230315233925.2416516-1-sboyd@kernel.org
State New
Headers
Series kunit: Use gfp in kunit_alloc_resource() kernel-doc |

Commit Message

Stephen Boyd March 15, 2023, 11:39 p.m. UTC 
  Copy/pasting the code from the kernel-doc here doesn't compile because
kunit_alloc_resource() takes a gfp flags argument. Pass the gfp
argument from the caller to complete the example.

Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 include/kunit/resource.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6

Comments

David Gow March 16, 2023, 3:36 a.m. UTC | #1 
On Thu, 16 Mar 2023 at 07:39, Stephen Boyd <sboyd@kernel.org> wrote:
>
> Copy/pasting the code from the kernel-doc here doesn't compile because
> kunit_alloc_resource() takes a gfp flags argument. Pass the gfp
> argument from the caller to complete the example.
>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---

Nice catch!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David

>  include/kunit/resource.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/resource.h b/include/kunit/resource.h
> index cf6fb8f2ac1b..c0d88b318e90 100644
> --- a/include/kunit/resource.h
> +++ b/include/kunit/resource.h
> @@ -72,7 +72,7 @@ typedef void (*kunit_resource_free_t)(struct kunit_resource *);
>   *             params.gfp = gfp;
>   *
>   *             return kunit_alloc_resource(test, kunit_kmalloc_init,
> - *                     kunit_kmalloc_free, &params);
> + *                     kunit_kmalloc_free, gfp, &params);
>   *     }
>   *
>   * Resources can also be named, with lookup/removal done on a name
>
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
>
diff mbox series

Patch

diff --git a/include/kunit/resource.h b/include/kunit/resource.h
index cf6fb8f2ac1b..c0d88b318e90 100644
--- a/include/kunit/resource.h
+++ b/include/kunit/resource.h
@@ -72,7 +72,7 @@  typedef void (*kunit_resource_free_t)(struct kunit_resource *);
  *		params.gfp = gfp;
  *
  *		return kunit_alloc_resource(test, kunit_kmalloc_init,
- *			kunit_kmalloc_free, &params);
+ *			kunit_kmalloc_free, gfp, &params);
  *	}
  *
  * Resources can also be named, with lookup/removal done on a name