From patchwork Wed Mar 15 19:11:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 70389 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp74548wrt; Wed, 15 Mar 2023 12:16:22 -0700 (PDT) X-Google-Smtp-Source: AK7set933fsTkil8SyTxd+GhKR1WJrPNbkY7eUA1mB91M1JE2zQ8CvDCrS8IlcNJfBB6tSQdQnq5 X-Received: by 2002:a62:4e14:0:b0:625:cc63:642b with SMTP id c20-20020a624e14000000b00625cc63642bmr579506pfb.14.1678907782445; Wed, 15 Mar 2023 12:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678907782; cv=none; d=google.com; s=arc-20160816; b=T4gK14cAd+mXA3Ur69snDzdU95tL30ntxdO7NB61sA6tynpIb/O8FekpqALzEDkiBR Ul7O+QNDBmDzW6xJ9y+9U8q0Amd1x9qHJnyhM9RignR4Ku8/V2TEv2u0FdPkV7TiBvcT Jgcg0sruNglofkO0Vk2ppIjDNnFieajejtAcuZcLrXXpRnqMYxelLZFmJIHwsTAScYsa 2H5MKgv7UwJ1HKDgWXkBjJvl5s+e4uZ7smAbzAZyP8+8Rg267DaZ83/FKZVE+W+9rI6U 7h8xeJx4Dw3EtN7mr/iIQfA87dIkZLmQSvCsBwn5+QfmXlI72OTeC9viCu1JXrle8T6/ Pyuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:reply-to:dkim-signature; bh=MPGBQpB/QOW3rOyiIDpJ1ssFrkSwrzaQZYPEXWdODjE=; b=rmkQk/ya3L3oPtqDJvgBM1D5psAr0jAk8MAdfu0MmAbuR4kNfBihPoqC6Cpi11sXTf xj0ipqpodHRDuWAk4Y9gZ0Z3r+HswFjJlUxwvLffNlbMzkmzYYN5UT0TFQbX1CKDOYdE 1ttZGdqtONJ0jZAh4m20jESgpGDvCyWe5PLnUuEmE31OyHYwAfxVvwnJTDE8pvgDXl/3 n6LxlnL+UUiCtNFtSsLk1Gq5AEFyp9LpKBXHp+FNmqP7KPKfgz+9Pl94XEdNgOVym6lB YQ33o69Uov2oeG2IgUHWT9SDe0iQH3bhPWezLleBeQdS7nqPKt5+AIYnEiAydCpj1If6 SbLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="DmIV0/go"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a20-20020aa794b4000000b0059b98e82de3si3242076pfl.314.2023.03.15.12.16.07; Wed, 15 Mar 2023 12:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="DmIV0/go"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232754AbjCOTLg (ORCPT + 99 others); Wed, 15 Mar 2023 15:11:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232524AbjCOTLd (ORCPT ); Wed, 15 Mar 2023 15:11:33 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC28C574FF for ; Wed, 15 Mar 2023 12:11:32 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id o3-20020a634e43000000b0050726979a86so4727347pgl.4 for ; Wed, 15 Mar 2023 12:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678907492; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=MPGBQpB/QOW3rOyiIDpJ1ssFrkSwrzaQZYPEXWdODjE=; b=DmIV0/goxFG7244B78LovLy06QrlSgu8/f40cOxIKKIBWcFXMdLj2/R/SlxpjVI4Xs FyUfyY6rHLpQIRLKr5KEahhvus39lwLLwwb1AQLRk8kAWyYQvyWEI54fGCL0uZ0DnT5p 1ohtmXtfIfH+AiU7mEHey888ZlDpXgbLWl0bfugYDjapKaQ2Rvv7ZdqM/hiYsJTp137H xD1vW+VMReaaLTBGQXU2bY9+JSK17d/EKiYyKK9udwboPopfApz3zvvdmC4KSdaOyM0T 47Dg2Eri745skE5XoFMII7S7y7R5XBt80sAHmZFd5xoRoRq/FwdnQcqQESDxIsSUmSut 3MhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678907492; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MPGBQpB/QOW3rOyiIDpJ1ssFrkSwrzaQZYPEXWdODjE=; b=NK+kbb6tSFwp5Fmes0/P2T2bxljb+Pt0R/TGQ1DryxC5tvuPrgHWKXSep6Ua4rmDRb aHYSW2/XE3njTAvDJK0RKNMsX9SsD8pWVat2PAJHRXLMZ+oLeEDc9/RZikS5sTl5pEjY eJadOY6ZHQaJQ6JjgZ1fs4vmbqREWIQGQkNBEhh50aW1vEGgrFfwoyttb3XbuC30bpty XlAhHmRnmfrDD0a9rXqQ4d69gU6jxeXwSzuA8WEZXVD+34JfiJM37zDtdHP9CPzgcMkA jrsU+d3J88ovP7bS/lUryQx/9mcmW2YjREy7L4hgq5SbbjlqjCPu35gcZLZdd34WbJYa 1IlA== X-Gm-Message-State: AO0yUKXxxctqkgWnaY5F/sHEyNxn7eBaUtdLgK74MKqMX+ONqr7uVOzD l0aIoB4VtKIRlhtzPCgp0EAUu3xQZ58= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:452:b0:19e:f660:81ee with SMTP id iw18-20020a170903045200b0019ef66081eemr303110plb.2.1678907492254; Wed, 15 Mar 2023 12:11:32 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 15 Mar 2023 12:11:27 -0700 In-Reply-To: <20230315191128.1407655-1-seanjc@google.com> Mime-Version: 1.0 References: <20230315191128.1407655-1-seanjc@google.com> X-Mailer: git-send-email 2.40.0.rc2.332.ga46443480c-goog Message-ID: <20230315191128.1407655-2-seanjc@google.com> Subject: [PATCH 1/2] KVM: VMX: Drop unprotected-by-braces variable declaration in case-statement From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Emanuele Giuseppe Esposito X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760462406894099769?= X-GMAIL-MSGID: =?utf-8?q?1760462406894099769?= Remove the intermediate "guest_flush_l1d" boolean to fix a build error on clang due to the variable being declared inside a case-statement without curly braces to create a proper code block. Fixes: c7ed946b95cb ("kvm: vmx: Add IA32_FLUSH_CMD guest support") Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303151912.oZ6SGd90-lkp@intel.com Cc: Emanuele Giuseppe Esposito Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index c63f6c786eb1..d7bf14abdba1 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2325,10 +2325,8 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) X86_FEATURE_IBPB); break; case MSR_IA32_FLUSH_CMD: - bool guest_flush_l1d = guest_cpuid_has(vcpu, - X86_FEATURE_FLUSH_L1D); ret = vmx_set_msr_ia32_cmd(vcpu, msr_info, - guest_flush_l1d, + guest_cpuid_has(vcpu, X86_FEATURE_FLUSH_L1D), L1D_FLUSH, X86_FEATURE_FLUSH_L1D); break;