From patchwork Wed Mar 15 18:18:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70347 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp49813wrt; Wed, 15 Mar 2023 11:22:46 -0700 (PDT) X-Google-Smtp-Source: AK7set+RwS+VH+6yS/jPZMnGdf5VMUCkObCMMzOHPja7jTEonKjSF1tYLn1RQsgN2n+Eco7tu83R X-Received: by 2002:a17:90a:1a01:b0:237:d44c:5861 with SMTP id 1-20020a17090a1a0100b00237d44c5861mr763518pjk.12.1678904566133; Wed, 15 Mar 2023 11:22:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904566; cv=none; d=google.com; s=arc-20160816; b=VfDr2BuyrOkwdF6eVJrwLZSPLft8D2xyXPv6fErV8x4wHy/F32m1bPPHUTvkCB+eaj c0o27CXnTawxv88EcxZHyeuCT6XoB3tUwo5e5TB6y9i/P9JPu7N1+4cgnYAqKvz3k1Ac yGI2Txvsg+dRyOHMSFfzGqVSiB8g2jbVDClMGNyHGs4qIy7O6wgvOTILjbX/wd2xoUuo v4RByl8J1EFN/nBDWXU7E0EqfYubKLETj9+dNQkXoUs4+ZdqTsDiW/XljAEedXKKS2RF 0Xf48Q+fHZpYdFnrG9Wmcwz1BC56VIz079QbnVECSdfdTSOS20Zv+0bQUbpPYnfdsmz6 EkLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8YdMRWrceqxooe4gtO91XUx2+IJg5yOZzB8eltDBQHc=; b=qjehivnhZ+naMN3L2M3IrXbH9mVYv9EJP6cygRmfaysFUPI+EnC930P+5tmQUe0BXI be23qk+lHLdz6ZNVVQRw22rdd9iYIfZbx8tLRssHAvS5eAJXLxziyaGdvlAmTIpJMeWh 0sRcchBgbDwbdUdjv1/f+JikHUMSHiS3vjVherq1bSet9UjUbMjZKehLaGdipkjfcrLS iMGU71ElKvR/DfnygRbL9W+17j+X4S7+Z5h02urSt9zoPmGhmMk21mkmsN1sgf/KXrt7 MTBd8EGbZvhcUdEydo/Gkf+tdcrkqSbjjsKuxa/L0UYPpsj6ns7ZotH/MZmbJ/k3Nvc/ KXtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=Y6dmHBBx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w12-20020a17090a4f4c00b00230c82c6284si2166784pjl.19.2023.03.15.11.22.33; Wed, 15 Mar 2023 11:22:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=Y6dmHBBx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232559AbjCOSTm (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231871AbjCOSTb (ORCPT ); Wed, 15 Mar 2023 14:19:31 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C7CE5D47A for ; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id x8so2127437qvr.9 for ; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8YdMRWrceqxooe4gtO91XUx2+IJg5yOZzB8eltDBQHc=; b=Y6dmHBBxuRL29N0TD32sk5Q46SZkvb+Cz7joxJNYQa7VcRhTrhsl+leDpu6VzvnEPD nP4GzafsDqwcbrFtRQrR0TIEqr/isk3MbcwjMbp7p2wI58NJmBzfsFfLMoIzrSJ0hxf1 ucc4ysYK0e6PziMi8ddBKUqNJVFM9vedX72fo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8YdMRWrceqxooe4gtO91XUx2+IJg5yOZzB8eltDBQHc=; b=hOxz/dMsJV2CSfCoKuHqS13FwL7iBr7NUv0Cb9de8rXLqlutiPkU3ywxWsMuGvFFRG 4mJs4q1FqekFJRAbdpR2hf+EcyESjGpkvrG/nmfHtL99PuS121WzR/SNgwd6GRw3gb+P TV8oIQSZly2jAOhHp3Go/Of7Ja4b/XFZHsgCHSd7Pu3Zy3pyl2JmCpdONWg2RgKeu5e3 jajFCqdtFpwH2+Ve/3yjT7iWWQS0ZfbWA8nHgfMW+5uyfI3TMVjQgH/MhxjnYO25tuCK qm2qAF1rPc/RzGa+NiRgySuqWbr26CYSQhl30+9EWYKEcrw8imnO+yuvs0WG35fyCSzW mBeA== X-Gm-Message-State: AO0yUKV0uP6iLiyGmJmRMvDzXorDYVxFpF2nkOSUXtuu1ryioGCgTBZU W0qKJ3+6kWylRQBltdzEHRE1n9i7FmN/nGd+PoU= X-Received: by 2002:a05:6214:1d01:b0:577:5ffe:e0d8 with SMTP id e1-20020a0562141d0100b005775ffee0d8mr34099870qvd.24.1678904369778; Wed, 15 Mar 2023 11:19:29 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:29 -0700 (PDT) From: "Joel Fernandes (Google)" To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/14] net/sysctl: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:52 +0000 Message-Id: <20230315181902.4177819-5-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459034458254762?= X-GMAIL-MSGID: =?utf-8?q?1760459034458254762?= From: "Uladzislau Rezki (Sony)" The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Eric Dumazet Cc: David S. Miller Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Jakub Kicinski --- net/core/sysctl_net_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index 74842b453407..782273bb93c2 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -177,7 +177,7 @@ static int rps_sock_flow_sysctl(struct ctl_table *table, int write, if (orig_sock_table) { static_branch_dec(&rps_needed); static_branch_dec(&rfs_needed); - kvfree_rcu(orig_sock_table); + kvfree_rcu_mightsleep(orig_sock_table); } } } @@ -215,7 +215,7 @@ static int flow_limit_cpu_sysctl(struct ctl_table *table, int write, lockdep_is_held(&flow_limit_update_mutex)); if (cur && !cpumask_test_cpu(i, mask)) { RCU_INIT_POINTER(sd->flow_limit, NULL); - kfree_rcu(cur); + kfree_rcu_mightsleep(cur); } else if (!cur && cpumask_test_cpu(i, mask)) { cur = kzalloc_node(len, GFP_KERNEL, cpu_to_node(i));