From patchwork Wed Mar 15 18:18:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 70351 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp50293wrt; Wed, 15 Mar 2023 11:23:45 -0700 (PDT) X-Google-Smtp-Source: AK7set8fjRW/CBhb2ApPlwkzJu99QrNAlU9Li7wKgw7+oqTf0y7fpSdGtUCLhova0LlkkBfIXlDq X-Received: by 2002:a05:6a20:2a03:b0:d4:e688:c6da with SMTP id e3-20020a056a202a0300b000d4e688c6damr629732pzh.36.1678904625396; Wed, 15 Mar 2023 11:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678904625; cv=none; d=google.com; s=arc-20160816; b=b+4E7l6X6AUda8BdeT1AovaRm14/8+uC3pB49HRHEbepxYsoFRkBHFhpEq2cbIInUW Lxg7lYVSadBwdvb/tQX4vtt9RQdjZKnxQHQk3W8/ezdtnTHwCt7+2W9nFwkCP36sOFqA nlSrjYaWH1H/fqa4lcZWdOFiX4HmtUrXNW9f/+zGQheNya5aVXfYL1J2zk6yroG5CJRA h4mNJuV3+Gvt8Y2rhK7oEUnUlgCvuwwsGVCbVQ9ARiKgQKg+wTviNSy85s+ygmOhVI4p jq2D6I+z4WBHvRDbjLVa51hzzt9LNGwInfbLIg+lBL7HWh2VX29yxoQ7Fl0ii2LzVfml 99Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8z1V24My5EukKvP2tBVF8l+SikUfpmtGJWjB50uVIOg=; b=AkboxBWs5I2+AqUQbRc9xR/mJND7Iuf/YWGVDZOooN1mC05mi4KAtPO7pqlcpjKJ1Z XV7Tbu5usaww3jisyiCQ9zjCWQ+KXawYzw+V7m0VZqnLccjBpdHRoGRs8ohIQ75Y0yzd 7ibxo5GOu7GAIKpT7815bFmvTQ2qBD6z8UnX3QpfWJXiCdeDyMY26lf5pV/5PMRxIPVi vOn09GIWLi8/usi8W3NYO8gXf2yVV2g5yHIg4bzWTZct7f7oObq6JMae1m9RMBxSL6D1 tcWvsinchHilm+gWSHuJdbXIgsEOsK1eXqdUi/9OcbowU0+Tv++3EtHUA9Hrtrcry/vi lpBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=gJL6xjY5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t71-20020a63814a000000b0050be692a718si1083628pgd.530.2023.03.15.11.23.32; Wed, 15 Mar 2023 11:23:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=gJL6xjY5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232503AbjCOSTf (ORCPT + 99 others); Wed, 15 Mar 2023 14:19:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232433AbjCOSTa (ORCPT ); Wed, 15 Mar 2023 14:19:30 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 884BA5D250 for ; Wed, 15 Mar 2023 11:19:28 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id x8so2127366qvr.9 for ; Wed, 15 Mar 2023 11:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8z1V24My5EukKvP2tBVF8l+SikUfpmtGJWjB50uVIOg=; b=gJL6xjY5J2VB+tgs7f4PKBmC6aJ6vF1TWCTHcKQSQeXddqkVkKHy4ky/vJZtWMfi1o uOBvR7syUfnwN1QoGa1eAGsFwODy02Qau5v8CRaDi+6RCsH9b1haKNaZ+fbdnRhLv0Rx VZK+iIEW4txFkIEOJqJ11RttHfWWpcIa5GTPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8z1V24My5EukKvP2tBVF8l+SikUfpmtGJWjB50uVIOg=; b=YdlGMU3buENL8fxHiVv68m3Em6JAZAZvcojfTDCrjsSG3mGh2FhrudQX0MJNlHwdAn x2rfKuya52IKeAoLcUn2n2mbGiN//bGMM0Oh4UDcStNLDO7L4mlOWco9PlTTdd8Np9B4 4noJoggIt2o4uXdmk3SUSLE9E377xmUXG6SfLFJdeqd3ghXS3ho3GH8FX2PzmKRumax4 jdYkBNaWtCTA4WgM/E9TPVNbbI3msqVrpfwmSsArjYoxS1G+n8J/nALHsfJGg0ouJA8U iehLAryAxYLYXt2A79FrKrQuOwCea2m8tLmtLqp6XCxIia8lFhF6mUEvcOXywJ5g0Da5 XoOw== X-Gm-Message-State: AO0yUKX3x25m98Mu3XU6pvYU+tfE7AImW4IygLWgK/BuWmL2BlhJH+JW 8l/Ee2qq/Kt1+3y0T2b11goudw== X-Received: by 2002:a05:6214:1cc8:b0:5ac:58cc:69d1 with SMTP id g8-20020a0562141cc800b005ac58cc69d1mr12603637qvd.31.1678904367609; Wed, 15 Mar 2023 11:19:27 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:27 -0700 (PDT) From: "Joel Fernandes (Google)" To: Steven Rostedt , Daniel Bristot de Oliveira , Masami Hiramatsu Cc: "Uladzislau Rezki (Sony)" , "Paul E . McKenney" , Joel Fernandes , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH v2 03/14] tracing: Rename kvfree_rcu() to kvfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:50 +0000 Message-Id: <20230315181902.4177819-3-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760459096242079783?= X-GMAIL-MSGID: =?utf-8?q?1760459096242079783?= From: "Uladzislau Rezki (Sony)" The kvfree_rcu() macro's single-argument form is deprecated. Therefore switch to the new kvfree_rcu_mightsleep() variant. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Steven Rostedt (VMware) Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Acked-by: Daniel Bristot de Oliveira --- kernel/trace/trace_osnoise.c | 2 +- kernel/trace/trace_probe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index 04f0fdae19a1..f68ca1e6460f 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -159,7 +159,7 @@ static void osnoise_unregister_instance(struct trace_array *tr) if (!found) return; - kvfree_rcu(inst); + kvfree_rcu_mightsleep(inst); } /* diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index 20d0c4a97633..2d2616678295 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -1172,7 +1172,7 @@ int trace_probe_remove_file(struct trace_probe *tp, return -ENOENT; list_del_rcu(&link->list); - kvfree_rcu(link); + kvfree_rcu_mightsleep(link); if (list_empty(&tp->event->files)) trace_probe_clear_flag(tp, TP_FLAG_TRACE);