From patchwork Wed Mar 15 16:35:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 70314 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp6229wrt; Wed, 15 Mar 2023 09:50:52 -0700 (PDT) X-Google-Smtp-Source: AK7set+5txN/KBlD9VDFGuV4MqgVinsA20qpc0c4LUhfYRVqp/gTBlgATHIY8Ux4x/yDrA6cRCh0 X-Received: by 2002:a17:902:f20c:b0:1a0:685f:5e47 with SMTP id m12-20020a170902f20c00b001a0685f5e47mr153071plc.26.1678899051814; Wed, 15 Mar 2023 09:50:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678899051; cv=none; d=google.com; s=arc-20160816; b=mE6X7fNN/0SVxfl53gcbaqOSCxdv2yYUjiw8flyIDpbpt4ZwUv24N0Ic8771YEMyoz Jy6rTRXVb7CR47/lQ5+bx5k0ENrRqRavAoQRubumyTRcH2vYinjzjYPpOlMWR2xxvgsV 1oDx/J8p10NArC7CyfyQwrhLMfeH9uZ0Gaa0LU3KljiHP2JMEjkwjGh87WdBXqsBTOX0 UGEMePnfsXycXGrs8+UJZHSQhoOgdL2lw3k0qxHJ1BOQDNnwiaID0BC5gmlhTJUxppmo 6vV2My+NPzQ4W3iSIyjfaFYBOJE33TsnykZeEpmTwGNE9p7u7612UfwynXtoLBLv8Jyr 4+Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w0CyxxuCfKyDxUhqZI8uZNDs4yTA+LT97JFfaSxmf5E=; b=FB3cZ5VIRxBjGPi8SG+ttE6FVG6+bjNYdb5S/Oz5SAVYUXwbe05IKeBZHh0Si9w5RK +w///6BsQCKeIx4GwFwblhMxEi9FfLOOcAxxeF4f4bdXRuW75bHHeSgu2f4U/Pyg0Ad2 V6ZQt2QsGy6s8OE1PgVLZ2NSaEmsifn7jRM4i3opKgZJu3ci58IQvMEah/LCg6Twa553 bKDm8Sn2fW6eNXZc8FlOU74JY8PBmjX5oMiRSFoQmGJ0ZeTo5yfl9+nefBoqiMW3icnW OuWzgIiiTiwuK7Y52V65en97WSXwkfcCNLjMGfo60WbCZjBGRG/x6keJfP7paxIVfqY4 1QUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cRPRo2QB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a170902768a00b0019a9ba66516si5139332pll.430.2023.03.15.09.50.39; Wed, 15 Mar 2023 09:50:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cRPRo2QB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232234AbjCOQid (ORCPT + 99 others); Wed, 15 Mar 2023 12:38:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232340AbjCOQhq (ORCPT ); Wed, 15 Mar 2023 12:37:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AD717C9F2 for ; Wed, 15 Mar 2023 09:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678898192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w0CyxxuCfKyDxUhqZI8uZNDs4yTA+LT97JFfaSxmf5E=; b=cRPRo2QBHtHJdxiU+7z5cjEFsuN+VeQDn5nQRuWBYUzOGa5n4f68ya2pYVR1BJZTo/BvFR JLFA47h/6BRiOFfDJHKBA6wMvHXU/T3hJxzCoAl6m9LSkbyI6eUY4iKFFUsbVHoHE6znpT z16+b8JLJ73yi7CV861MolR9KOe+3Yk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-503-KRZAb1KrMEG4we92PR2NZA-1; Wed, 15 Mar 2023 12:36:27 -0400 X-MC-Unique: KRZAb1KrMEG4we92PR2NZA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 316A48828C6; Wed, 15 Mar 2023 16:36:24 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6A4C2C164E7; Wed, 15 Mar 2023 16:36:21 +0000 (UTC) From: David Howells To: Jens Axboe , Al Viro , Christoph Hellwig Cc: David Howells , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dave Chinner , Christoph Hellwig Subject: [PATCH v19 10/15] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing Date: Wed, 15 Mar 2023 16:35:44 +0000 Message-Id: <20230315163549.295454-11-dhowells@redhat.com> In-Reply-To: <20230315163549.295454-1-dhowells@redhat.com> References: <20230315163549.295454-1-dhowells@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760453252068813484?= X-GMAIL-MSGID: =?utf-8?q?1760453252068813484?= ZERO_PAGE can't go away, no need to hold an extra reference. Signed-off-by: David Howells Reviewed-by: David Hildenbrand Reviewed-by: John Hubbard Reviewed-by: Dave Chinner Reviewed-by: Christoph Hellwig cc: Al Viro cc: linux-fsdevel@vger.kernel.org --- fs/iomap/direct-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index f771001574d0..850fb9870c2f 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -202,7 +202,7 @@ static void iomap_dio_zero(const struct iomap_iter *iter, struct iomap_dio *dio, bio->bi_private = dio; bio->bi_end_io = iomap_dio_bio_end_io; - get_page(page); + bio_set_flag(bio, BIO_NO_PAGE_REF); __bio_add_page(bio, page, len, 0); iomap_dio_submit_bio(iter, dio, bio, pos); }