From patchwork Wed Mar 15 12:18:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juri Lelli X-Patchwork-Id: 70203 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2319665wrd; Wed, 15 Mar 2023 06:10:44 -0700 (PDT) X-Google-Smtp-Source: AK7set9t0k4WttAisIpQ1EUHbWBC5DJGRZ/0+JdH0slCqknrV6BSPoU/KcGfmqQ8YKN1yR3x/afg X-Received: by 2002:a05:6a20:69a3:b0:c7:6f26:c99 with SMTP id t35-20020a056a2069a300b000c76f260c99mr63599202pzk.61.1678885843794; Wed, 15 Mar 2023 06:10:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678885843; cv=none; d=google.com; s=arc-20160816; b=boXEyjQ4Q2Co/+gIf2XXKH2UgRJxBQNTf+VGmjAtH83qLNJL1oMrOya9K9EHvyBQ6w 467pMo30uOCQAe8jseWQmEf+JLhefa/uQM/mh5h/rzrXsqPFwxfYPttYpv3XdmF1U2ew WFrPrWv/DZO1Cs8eU7vFtsmalwSTnsL4LVmg3bOZg0GjSBMipSxz1Bi7W3sTrYTnHLk3 s6QUD1WeCQmWPbfj4tBll5yUEGjwQAO7T9Vam2132Hc2pzQiE7W0P1uXKY+phw927Yi1 nqRsuBPZT3+Mm7npE9BdOMqkenKJ1Ymrsx0sh1itZ96JWq34+2OIw8I+/m5dQ9n2Ah8V bUog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2PRbwpAoEnOZK1WgHwlMyMBfG9nGKa4R9Y3iK9sv+Ts=; b=Qy4uBe+ZUEyiWEq0Uq/MC2RfzID9l900O3ikpl1neyODxPxFuULJNUK8KQbdv4QVFX 3QXVmHDH8CQ8MJStXJUjvZFGay/ZphvjBx8OpljspceUcQs8dEsuKXoJhVQ/mEtwykjE OOu8YJKMhrHoVVy2jqK/TiiKbVSZM1M5Ll1bQFfLQaL3yq1HfObAM2IjXOCKvG7YJiAC 2ws8PP4Y21fsUPg88WKbByezyLW66KjDxg9wR/B7ntJFxtqCOZgR+2ZZXEbdymAFQT/h 8MkRD2XBDF2zYGgWLZ+P0rSFAsQ42orks3lL2JUZct/1wpxoacaA4k2gO1y7cKZDlJm6 x/LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Y+tBqveN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x12-20020a63170c000000b004fcc0120074si5051980pgl.161.2023.03.15.06.10.04; Wed, 15 Mar 2023 06:10:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Y+tBqveN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232278AbjCOMUs (ORCPT + 99 others); Wed, 15 Mar 2023 08:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbjCOMUK (ORCPT ); Wed, 15 Mar 2023 08:20:10 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E7F541B6B for ; Wed, 15 Mar 2023 05:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678882755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2PRbwpAoEnOZK1WgHwlMyMBfG9nGKa4R9Y3iK9sv+Ts=; b=Y+tBqveNFkCebtVM4gYrrG2SGgqWwvmUO35LwZnrKiijncu5JgZeIOPiWW9AMo03pzySsS w2d7NMr40pM99rtR18P+xY1wMVXJfAL5Fq93Jt4gu+3g6MpbDKfxsGIPigLPe4rJecym2C p/DATnOJeUIke9vNCORpCO1liIFvNzE= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-Y6weJSA_PaW67LzxqlU1Pg-1; Wed, 15 Mar 2023 08:19:14 -0400 X-MC-Unique: Y6weJSA_PaW67LzxqlU1Pg-1 Received: by mail-qv1-f71.google.com with SMTP id pp11-20020a056214138b00b0056c228fa15cso11389784qvb.4 for ; Wed, 15 Mar 2023 05:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678882753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2PRbwpAoEnOZK1WgHwlMyMBfG9nGKa4R9Y3iK9sv+Ts=; b=2NaMkwOgLHbGy46YTenySSyOiDwc8yOlKSm3i7czwalZPnVlqQAGldj3NxYbBZLnFy 9prRvcU1Np6pzRXGhKtwpOfhmgWpOX2TEOXSKYlI95SPIZxLrQK2N0iZMSqbFH/6Hqws Qhf1TaEGpNW6/1x/NhjnXCHr0MFyKN7PduyI7sMm8qQjWLr88Ve7oFgcWKHZkYzTfq3/ BXEwnOQvBgJHlEJZJhkKSy+itp9gDZCcwZuwpgV+mc3WP9mAafWvaGoH4gvRzj6SH4gc sxToEA8V/YJXgxTfikLoMxDsGI0naDeCNdhypb642qLf7Zr+WrRJyTdrH+L393LjwBac znQQ== X-Gm-Message-State: AO0yUKWc7yJSuA2X6F1tkO1T7YIUAi4aHaC502zzvidS1Z3NCC7DglVP G3ZYhukSqCp39ounnksSgmayvC9EC7u5+redk2bvy44kkmDcLQqNgxgruQTrlUJDfBbJwzuFgVr oi+U7t5ADZo43j2befj6kNHIU X-Received: by 2002:ac8:7f4d:0:b0:3b9:a441:37f4 with SMTP id g13-20020ac87f4d000000b003b9a44137f4mr69515113qtk.52.1678882752883; Wed, 15 Mar 2023 05:19:12 -0700 (PDT) X-Received: by 2002:ac8:7f4d:0:b0:3b9:a441:37f4 with SMTP id g13-20020ac87f4d000000b003b9a44137f4mr69515075qtk.52.1678882752606; Wed, 15 Mar 2023 05:19:12 -0700 (PDT) Received: from localhost.localdomain.com ([2a00:23c6:4a21:6f01:ac73:9611:643a:5397]) by smtp.gmail.com with ESMTPSA id f11-20020ac8014b000000b003bd21323c80sm3672595qtg.11.2023.03.15.05.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 05:19:12 -0700 (PDT) From: Juri Lelli To: Peter Zijlstra , Ingo Molnar , Qais Yousef , Waiman Long , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo Cc: Dietmar Eggemann , Steven Rostedt , linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, cgroups@vger.kernel.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sudeep Holla , Juri Lelli Subject: [RFC PATCH 3/3] cgroup/cpuset: Iterate only if DEADLINE tasks are present Date: Wed, 15 Mar 2023 12:18:12 +0000 Message-Id: <20230315121812.206079-4-juri.lelli@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315121812.206079-1-juri.lelli@redhat.com> References: <20230315121812.206079-1-juri.lelli@redhat.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760439402666441506?= X-GMAIL-MSGID: =?utf-8?q?1760439402666441506?= update_tasks_root_domain currently iterates over all tasks even if no DEADLINE task is present on the cpuset/root domain for which bandwidth accounting is being rebuilt. This has been reported to introduce 10+ ms delays on suspend-resume operations. Skip the costly iteration for cpusets that don't contain DEADLINE tasks. Reported-by: Qais Yousef Signed-off-by: Juri Lelli --- kernel/cgroup/cpuset.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 57bc60112618..f46192d2e97e 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1090,6 +1090,9 @@ static void update_tasks_root_domain(struct cpuset *cs) struct css_task_iter it; struct task_struct *task; + if (cs->nr_deadline_tasks == 0) + return; + css_task_iter_start(&cs->css, 0, &it); while ((task = css_task_iter_next(&it)))