From patchwork Wed Mar 15 11:31:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 70158 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2273562wrd; Wed, 15 Mar 2023 04:34:33 -0700 (PDT) X-Google-Smtp-Source: AK7set9cCEEZt7PZxs5Pg47ygZJfhXtlzWUl9weE8lfEYc2p9/O+M7sID++vKR1WX/yDtZl0OkPH X-Received: by 2002:a17:90b:3907:b0:234:b964:5703 with SMTP id ob7-20020a17090b390700b00234b9645703mr43298810pjb.18.1678880073696; Wed, 15 Mar 2023 04:34:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678880073; cv=none; d=google.com; s=arc-20160816; b=D0eqxS74N8xzZu3lcXbYNDlQh0zIDfJz4rmr/rtPDjBLUD0VLYJS+RCaZxT0Xb7yjQ /kCIJFcaKQoFxfWjn8bcisa8Po/R3WVS9SoSa0QYeKA0ybwqQFph6RhmU7vRLIyx3fFP 3bT1tzVoRs/GyIewiQEGX9xN7fHG49sOTmgatjOzRVJpmNpqR88eWw7AvmxZGaLmdvx3 iFDv8g1rZhnCkpM+DAcYV2Ljzpu1f4nFcwXJT9AdiLlNsrOucyXX6KGnr6gM54wW8PXb LzvbPM6ksNboUmU02Vhc8Zsu3NGvVB2lIdWv3rR7dNymOjV8eaZrI1R1wzohqyRvH6Ex P/yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AT1GhwbDyWrvyJUMDRYHSLUugvLdHkN1MSYo/oKLUQE=; b=1HMqhsf22HgUMeMfOKaoMIeq/q3E8bpvx9+lOupftLP1r3U23YOmFzXSXBMksZ1wCk WKco0N+6SUuUvNFuEnedljr41fvgPFt3SExcZezzo17fE4E1Jq/DayN9/Zpa6faG4abZ 7zn1LU3tjsgEl+k9ydGiKEWcHPAvphxgmP9UCgewJ1OFMb005OYcldaefl7qJ0DGgILu achRIWJzwylZuVH2LKlEq9EjI/lNSf2cIG+CEyRPi44Ug3AmuTXsMglciKn10E7Ld2rw FYUgaNshiqvSDn8elU+N1u41XHLMEZzEE7b8ukYWQSUp29DMrWBkYN2pVa3JiaCrcH44 Ld9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n4qGSVd1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y15-20020a17090aa40f00b002341fe2f578si1411687pjp.138.2023.03.15.04.34.18; Wed, 15 Mar 2023 04:34:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n4qGSVd1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbjCOLcG (ORCPT + 99 others); Wed, 15 Mar 2023 07:32:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231566AbjCOLbr (ORCPT ); Wed, 15 Mar 2023 07:31:47 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5B965C47; Wed, 15 Mar 2023 04:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678879906; x=1710415906; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=52iLXUh9Y9J9QoTpEvXDHrqTMiCmRpr/0OkWw2Dmeo4=; b=n4qGSVd1KWwKf79MuJ+BWAiNhFJ/0cplH9BwCSUBi1SiKIl6/qJKh7K/ hUa+QY8L59Ugses5W+Wptllm24q0s8aiRZQ8US7skxhUrMFYitRhicw2k Gfq8U515nc+uCXnbTPkDrizOUgFdLzLYWAV/RZoNJD4plkHZ/ROCh3215 zcI39ZhPFwpsUP43lXMpizls8xdI0fzlleAgI8w5Ce5Z7yCHEfMvSZinF XCg6hUopBxNA4KVDUTw4v8KOTBPysR40ePTrR92bj6Y1TUEePfU6/OrgD k2fF4B9P+qucZjk+UIkHywzdQPRcw+8TP9tx5jR4Me2C7cO5CTn+6cLyn Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="340040125" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="340040125" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 04:31:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="768456012" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="768456012" Received: from nopopovi-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.33.48]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 04:31:43 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id E47DB10D684; Wed, 15 Mar 2023 14:31:35 +0300 (+03) From: "Kirill A. Shutemov" To: Andrew Morton , Mel Gorman , Vlastimil Babka , David Hildenbrand Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" , Christoph Lameter , Pekka Enberg Subject: [PATCH 08/10] mm/slub: Fix MAX_ORDER usage in calculate_order() Date: Wed, 15 Mar 2023 14:31:31 +0300 Message-Id: <20230315113133.11326-9-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> References: <20230315113133.11326-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760433352179584087?= X-GMAIL-MSGID: =?utf-8?q?1760433352179584087?= MAX_ORDER is not inclusive: the maximum allocation order buddy allocator can deliver is MAX_ORDER-1. Fix MAX_ORDER usage in calculate_order(). Signed-off-by: Kirill A. Shutemov Cc: Vlastimil Babka Cc: Christoph Lameter Cc: Pekka Enberg Reviewed-by: Vlastimil Babka --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 39327e98fce3..32eb6b50fe18 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4171,7 +4171,7 @@ static inline int calculate_order(unsigned int size) /* * Doh this slab cannot be placed using slub_max_order. */ - order = calc_slab_order(size, 1, MAX_ORDER, 1); + order = calc_slab_order(size, 1, MAX_ORDER - 1, 1); if (order < MAX_ORDER) return order; return -ENOSYS;