From patchwork Wed Mar 15 11:05:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 70142 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2267794wrd; Wed, 15 Mar 2023 04:21:47 -0700 (PDT) X-Google-Smtp-Source: AK7set/Y787FYTZh7YjllIv/VarZph8IulG1DkAG0oe8Ei8kGsJHLq7sTnb51VnFZvyB3LwIiAeP X-Received: by 2002:a62:546:0:b0:5a8:c3ec:e24e with SMTP id 67-20020a620546000000b005a8c3ece24emr29231134pff.4.1678879306904; Wed, 15 Mar 2023 04:21:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678879306; cv=none; d=google.com; s=arc-20160816; b=Hz6UTn8Ewu4t60WIC94zgq75XqFhSov8UOwKEDId+00IC8I8CTzB5h6azkqoD95lRZ XhRD6hH41RmjppYbyifjSG34lkbRyeQ30kEx40hjLvHcLAR9evy+sX4hKMx4x0RMyAJo wILX8yoqeO+M4GecBqmFX3vPLUBgEEKqrjg985It+65nQSPM/H1Ex0GSoCTQk8dIGOrT bnoILQu23gJjNPV/Vr2XNmsEDDCYLWAXvyivyU3eyWSSfXRXp39hzsaKazN7ayDwutDh gRHp3X+LOescv1CIbPHu+g0NQPMYGGDlGppclifFUxp8a5pUn0ETGldOinfYwdZtnZ8+ MDyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=k88g/tLODmL/T9qHyAnmUHflunm5no0E2q2FXlPGb3k=; b=0Wo94TYmLPnYy7v+8LAkXG4QHomU3SHx6rbuAi5o8x0WeQnGOKIbAH/aDF2eMNuE2l H1EO5kqcrFQmzPYAdrKdGM37//qx60Xp7EK3drbYZr41H7tmj8U6TNufOGxeyNZX9g1P LPV6J/Y0u8CbN04LnpiVZ6YWDawmkNN9GvOB1xRkq5KFVx0J9UEeh8su1oq216174JUL ZDyxoqyiPVZXFTv+Spziw2CLrovS+MbSsiVMkHDEcZKxuk45nCBh1XBqSl0Sw5/4p+SU 4wLuY/eQi5CiKHnAUmfCgd2dQlu3AlwC0sPearAlf2uGErLqhCkJ+UoZ3b6pod8ICydF O0MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=iZKxW14R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y3-20020aa79423000000b005941664b506si4176086pfo.224.2023.03.15.04.21.32; Wed, 15 Mar 2023 04:21:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=iZKxW14R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231924AbjCOLHE (ORCPT + 99 others); Wed, 15 Mar 2023 07:07:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbjCOLGh (ORCPT ); Wed, 15 Mar 2023 07:06:37 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D2A884F67 for ; Wed, 15 Mar 2023 04:06:28 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id m35so2734415wms.4 for ; Wed, 15 Mar 2023 04:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; t=1678878387; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k88g/tLODmL/T9qHyAnmUHflunm5no0E2q2FXlPGb3k=; b=iZKxW14RgsUryqrI2nACouoY4HQvKFciZnX+mzVHzb7eZV3v+LaHyKH6USAN/IZzTa 5wAVzBLUhv9sOWCHw0z6fwn/24ZvPbn8W/HFQEJZ4UIfjuSR8E+Tim2vIAPXenbZhbiZ NF4Jbsy7kQC1hPp04+n2TDP24eYex0b0+D1fX6ah5B/35LvyaYuYu5Dn0ghC+1W/7Sz9 YSdHSqymvR1SzogEzO3nuIsqe4s2LgO1F3YqJwXND+mollBw38h8Qb6C8X06YaIxzODx Ylj30ZPDF9xrTAPLrv5kFEo1jW5DZG5w3Q/gfl0xzG54ZUXC7ZdRTnbN5/GAvPqvXQGb kvOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678878387; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k88g/tLODmL/T9qHyAnmUHflunm5no0E2q2FXlPGb3k=; b=x/SiM20yDSt+Hc42yn/g4lzQ7vPDYo03jlsgxEnmk6UalALWEuE7pDbXQtltmir6yC RMBg+jHgoTiPf+ZRfKp71ItO4qVHDgISnBTl57R9HbY3dBzMvKeYXqgBb81zT3wH2TNU wg3FxfNwapo2hQhqlOA8XlZxxmojWXU4npGfOLy5+G7U8ih1grmx+fRMlTqSUZRiLn4T laCld7lzXoDQWYVnLR5V0klwZJpMFX4Ff6kNIbypDgoeqeHt6kitNFBddKqUOwp+RGQN pDvGAz1GB5U0Au6FmUxVG4srPOX5XM19d6XUG59UTUHhx0nITLQIR9wzSS1hJ9ppcIrV 96DA== X-Gm-Message-State: AO0yUKV5Xa8sSPhvEhU8+wLv57N/1KMWbvTtG+Gjbhlj83LPDwBgRJF/ Sdb/o2PHnt7O8WsKKX86V/k0MA== X-Received: by 2002:a05:600c:3107:b0:3dc:55d9:ec8 with SMTP id g7-20020a05600c310700b003dc55d90ec8mr16335974wmo.41.1678878386783; Wed, 15 Mar 2023 04:06:26 -0700 (PDT) Received: from blmsp.fritz.box ([2001:4090:a247:8056:be7d:83e:a6a5:4659]) by smtp.gmail.com with ESMTPSA id l4-20020a7bc444000000b003eafc47eb09sm1460563wmi.43.2023.03.15.04.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 04:06:26 -0700 (PDT) From: Markus Schneider-Pargmann To: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger Cc: Vincent MAILHOL , Simon Horman , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH v3 02/16] can: m_can: Always acknowledge all interrupts Date: Wed, 15 Mar 2023 12:05:32 +0100 Message-Id: <20230315110546.2518305-3-msp@baylibre.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315110546.2518305-1-msp@baylibre.com> References: <20230315110546.2518305-1-msp@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760432548004741057?= X-GMAIL-MSGID: =?utf-8?q?1760432548004741057?= The code already exits the function on !ir before this condition. No need to check again if anything is set as IR_ALL_INT is 0xffffffff. Signed-off-by: Markus Schneider-Pargmann Reviewed-by: Simon Horman --- drivers/net/can/m_can/m_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 563625a701fc..8eb327ae3bdf 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -1083,8 +1083,7 @@ static irqreturn_t m_can_isr(int irq, void *dev_id) return IRQ_NONE; /* ACK all irqs */ - if (ir & IR_ALL_INT) - m_can_write(cdev, M_CAN_IR, ir); + m_can_write(cdev, M_CAN_IR, ir); if (cdev->ops->clear_interrupts) cdev->ops->clear_interrupts(cdev);