diff mbox series

[02/15] arm64: defconfig: Add Nuvoton MA35 family support

Message ID	20230315072902.9298-3-ychuang570808@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Jacky Huang <ychuang570808@gmail.com> To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, schung@nuvoton.com, Jacky Huang <ychuang3@nuvoton.com> Subject: [PATCH 02/15] arm64: defconfig: Add Nuvoton MA35 family support Date: Wed, 15 Mar 2023 07:28:49 +0000 Message-Id: <20230315072902.9298-3-ychuang570808@gmail.com> In-Reply-To: <20230315072902.9298-1-ychuang570808@gmail.com> References: <20230315072902.9298-1-ychuang570808@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Introduce Nuvoton ma35d1 SoC \| [00/15] Introduce Nuvoton ma35d1 SoC [01/15] arm64: Kconfig.platforms: Add config for Nuvoton MA35 platform [02/15] arm64: defconfig: Add Nuvoton MA35 family support [03/15] mfd: Add the header file of Nuvoton ma35d1 system manager [04/15] dt-bindings: clock: nuvoton: add binding for ma35d1 clock controller [05/15] dt-bindings: reset: nuvoton: add binding for ma35d1 IP reset control [06/15] dt-bindings: mfd: syscon: Add nuvoton,ma35d1-sys compatible [07/15] dt-bindings: arm: Add initial bindings for Nuvoton platform [08/15] dt-bindings: clock: Document ma35d1 clock controller bindings [09/15] dt-bindings: reset: Document ma35d1 reset controller bindings [10/15] dt-bindings: serial: Document ma35d1 uart controller bindings [11/15] arm64: dts: nuvoton: Add initial ma35d1 device tree [12/15] clk: nuvoton: Add clock driver for ma35d1 clock controller [13/15] reset: Add Nuvoton ma35d1 reset driver support [14/15] tty: serial: Add Nuvoton ma35d1 serial driver support [15/15] MAINTAINERS: Add entry for NUVOTON MA35

Commit Message

Jacky Huang March 15, 2023, 7:28 a.m. UTC

  From: Jacky Huang <ychuang3@nuvoton.com>

Enable basic drivers for ma35d1 booting up support: architecture,
device tree, clock, reset, and uart.

Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann March 16, 2023, 2:23 p.m. UTC | #1

On Wed, Mar 15, 2023, at 08:28, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> Enable basic drivers for ma35d1 booting up support: architecture,
> device tree, clock, reset, and uart.
>
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>

The description does not seem to match the actual contents,
which only enable the platform but none of the drivers.

It's ok generally to enable options in the defconfig file
before you add the drivers, but if it's all part of a patch
series, I would probable more this bit to the end.

     Arnd

Jacky Huang March 17, 2023, 9:05 a.m. UTC | #2

Hi Anrd,

Thanks for your advice.

On 2023/3/16 下午 10:23, Arnd Bergmann wrote:
> On Wed, Mar 15, 2023, at 08:28, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> Enable basic drivers for ma35d1 booting up support: architecture,
>> device tree, clock, reset, and uart.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> The description does not seem to match the actual contents,
> which only enable the platform but none of the drivers.

I would like to rewrite it as:

arm64: defconfig: Add support for Nuvoton MA35 family SoCs

This adds support for the Nuvoton MA35 family SoCs which
are based on the Cortex-A35 Armv8-A 64-bit architecture.


> It's ok generally to enable options in the defconfig file
> before you add the drivers, but if it's all part of a patch
> series, I would probable more this bit to the end.
>
>       Arnd

Best regards,

Jacky Huang

diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 7790ee42c68a..c96189acb02c 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -53,6 +53,7 @@  CONFIG_ARCH_LAYERSCAPE=y
 CONFIG_ARCH_MXC=y
 CONFIG_ARCH_S32=y
 CONFIG_ARCH_NPCM=y
+CONFIG_ARCH_NUVOTON=y
 CONFIG_ARCH_QCOM=y
 CONFIG_ARCH_RENESAS=y
 CONFIG_ARCH_ROCKCHIP=y